{"id":807953,"url":"http://patchwork.ozlabs.org/api/1.0/patches/807953/?format=json","project":{"id":44,"url":"http://patchwork.ozlabs.org/api/1.0/projects/44/?format=json","name":"skiboot firmware development","link_name":"skiboot","list_id":"skiboot.lists.ozlabs.org","list_email":"skiboot@lists.ozlabs.org","web_url":"http://github.com/open-power/skiboot","scm_url":"http://github.com/open-power/skiboot","webscm_url":""},"msgid":"<1504132707-10406-2-git-send-email-arbab@linux.vnet.ibm.com>","date":"2017-08-30T22:38:25","name":"[1/3] npu2: hw-procedures: Add comments denoting procedure number","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"edd35bd9756146b1f2f6b5cfefff8df17509f4e9","submitter":{"id":69358,"url":"http://patchwork.ozlabs.org/api/1.0/people/69358/?format=json","name":"Reza Arbab","email":"arbab@linux.vnet.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/skiboot/patch/1504132707-10406-2-git-send-email-arbab@linux.vnet.ibm.com/mbox/","series":[{"id":711,"url":"http://patchwork.ozlabs.org/api/1.0/series/711/?format=json","date":"2017-08-30T22:38:27","name":"npu2: PHY initialization updates","version":1,"mbox":"http://patchwork.ozlabs.org/series/711/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/807953/checks/","tags":{},"headers":{"Return-Path":"<skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>","X-Original-To":["incoming@patchwork.ozlabs.org","skiboot@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","skiboot@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjL5y0gWTz9s83\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 31 Aug 2017 08:39:18 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xjL5x6x6XzDqZq\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 31 Aug 2017 08:39:17 +1000 (AEST)","from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com\n\t[148.163.158.5])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xjL581ZTBzDqNY\n\tfor <skiboot@lists.ozlabs.org>; Thu, 31 Aug 2017 08:38:35 +1000 (AEST)","from pps.filterd (m0098413.ppops.net [127.0.0.1])\n\tby mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv7UMaDkT142869\n\tfor <skiboot@lists.ozlabs.org>; Wed, 30 Aug 2017 18:38:33 -0400","from e18.ny.us.ibm.com (e18.ny.us.ibm.com [129.33.205.208])\n\tby mx0b-001b2d01.pphosted.com with ESMTP id 2cp2emvc7y-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor <skiboot@lists.ozlabs.org>; Wed, 30 Aug 2017 18:38:33 -0400","from localhost\n\tby e18.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <skiboot@lists.ozlabs.org> from <arbab@linux.vnet.ibm.com>;\n\tWed, 30 Aug 2017 18:38:32 -0400","from b01cxnp22035.gho.pok.ibm.com (9.57.198.25)\n\tby e18.ny.us.ibm.com (146.89.104.205) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tWed, 30 Aug 2017 18:38:29 -0400","from b01ledav002.gho.pok.ibm.com (b01ledav002.gho.pok.ibm.com\n\t[9.57.199.107])\n\tby b01cxnp22035.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP\n\tid v7UMcT1031981820; Wed, 30 Aug 2017 22:38:29 GMT","from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id C0EA012403F;\n\tWed, 30 Aug 2017 18:35:48 -0400 (EDT)","from arbab-laptop.localdomain (unknown [9.53.92.213])\n\tby b01ledav002.gho.pok.ibm.com (Postfix) with ESMTP id A63AD124035;\n\tWed, 30 Aug 2017 18:35:48 -0400 (EDT)","by arbab-laptop.localdomain (Postfix, from userid 152845)\n\tid CBD39460483; Wed, 30 Aug 2017 17:38:27 -0500 (CDT)"],"From":"Reza Arbab <arbab@linux.vnet.ibm.com>","To":"skiboot@lists.ozlabs.org","Date":"Wed, 30 Aug 2017 17:38:25 -0500","X-Mailer":"git-send-email 1.8.3.1","In-Reply-To":"<1504132707-10406-1-git-send-email-arbab@linux.vnet.ibm.com>","References":"<1504132707-10406-1-git-send-email-arbab@linux.vnet.ibm.com>","X-TM-AS-GCONF":"00","x-cbid":"17083022-0044-0000-0000-000003857BB0","X-IBM-SpamModules-Scores":"","X-IBM-SpamModules-Versions":"BY=3.00007638; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000226; SDB=6.00909922; UDB=6.00456405;\n\tIPR=6.00690207; \n\tBA=6.00005562; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00016933;\n\tXFM=3.00000015; UTC=2017-08-30 22:38:31","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17083022-0045-0000-0000-000007B3949E","Message-Id":"<1504132707-10406-2-git-send-email-arbab@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-08-30_09:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=1\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1708300344","Subject":"[Skiboot] [PATCH 1/3] npu2: hw-procedures: Add comments denoting\n\tprocedure number","X-BeenThere":"skiboot@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Mailing list for skiboot development <skiboot.lists.ozlabs.org>","List-Unsubscribe":"<https://lists.ozlabs.org/options/skiboot>,\n\t<mailto:skiboot-request@lists.ozlabs.org?subject=unsubscribe>","List-Archive":"<http://lists.ozlabs.org/pipermail/skiboot/>","List-Post":"<mailto:skiboot@lists.ozlabs.org>","List-Help":"<mailto:skiboot-request@lists.ozlabs.org?subject=help>","List-Subscribe":"<https://lists.ozlabs.org/listinfo/skiboot>,\n\t<mailto:skiboot-request@lists.ozlabs.org?subject=subscribe>","Cc":"Alistair Popple <alistair@popple.id.au>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"Skiboot\"\n\t<skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>"},"content":"There are comments in this file to indicate where each numbered\nprocedure from the programming guide is implemented, for easy searching.\n\nAdd a couple which were missing.\n\nSigned-off-by: Reza Arbab <arbab@linux.vnet.ibm.com>\n---\n hw/npu2-hw-procedures.c | 2 ++\n 1 file changed, 2 insertions(+)","diff":"diff --git a/hw/npu2-hw-procedures.c b/hw/npu2-hw-procedures.c\nindex c9e7673..ac5c919 100644\n--- a/hw/npu2-hw-procedures.c\n+++ b/hw/npu2-hw-procedures.c\n@@ -312,6 +312,7 @@ static uint32_t phy_reset_complete(struct npu2_dev *ndev)\n }\n DEFINE_PROCEDURE(phy_reset, phy_reset_wait, phy_reset_complete);\n \n+/* Procedure 1.2.6 - I/O PHY Tx Impedance Calibration */\n static uint32_t phy_tx_zcal(struct npu2_dev *ndev)\n {\n \tif (ndev->npu->tx_zcal_complete[ndev->index > 2])\n@@ -502,6 +503,7 @@ static uint32_t phy_enable_tx_rxcal(struct npu2_dev *ndev)\n }\n DEFINE_PROCEDURE(phy_enable_tx_rxcal);\n \n+/* Procedure 1.2.9 - Disable Downstream Link Training */\n static uint32_t phy_disable_tx_rxcal(struct npu2_dev *ndev)\n {\n \tint lane;\n","prefixes":["1/3"]}