{"id":807890,"url":"http://patchwork.ozlabs.org/api/1.0/patches/807890/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20170830210542.2153-2-eblake@redhat.com>","date":"2017-08-30T21:05:25","name":"[v6,01/18] block: Make bdrv_img_create() size selection easier to read","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"4f54a99c043ec77fc461d518ff80177b97862e28","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/1.0/people/6591/?format=json","name":"Eric Blake","email":"eblake@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170830210542.2153-2-eblake@redhat.com/mbox/","series":[{"id":700,"url":"http://patchwork.ozlabs.org/api/1.0/series/700/?format=json","date":"2017-08-30T21:05:25","name":"make dirty-bitmap byte-based","version":6,"mbox":"http://patchwork.ozlabs.org/series/700/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/807890/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjJ3M5ds7z9sP5\n\tfor ;\n\tThu, 31 Aug 2017 07:06:54 +1000 (AEST)","from localhost ([::1]:52687 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnACK-0003lo-1t\n\tfor incoming@patchwork.ozlabs.org; Wed, 30 Aug 2017 17:06:52 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:36797)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnABR-0003cO-Ur\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 17:05:59 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnABQ-0007KO-NV\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 17:05:57 -0400","from mx1.redhat.com ([209.132.183.28]:46278)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dnABL-0007CS-4N; Wed, 30 Aug 2017 17:05:51 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 10B005F739;\n\tWed, 30 Aug 2017 21:05:50 +0000 (UTC)","from red.redhat.com (ovpn-122-186.rdu2.redhat.com [10.10.122.186])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 222619815A;\n\tWed, 30 Aug 2017 21:05:48 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 10B005F739","From":"Eric Blake ","To":"qemu-devel@nongnu.org","Date":"Wed, 30 Aug 2017 16:05:25 -0500","Message-Id":"<20170830210542.2153-2-eblake@redhat.com>","In-Reply-To":"<20170830210542.2153-1-eblake@redhat.com>","References":"<20170830210542.2153-1-eblake@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tWed, 30 Aug 2017 21:05:50 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH v6 01/18] block: Make bdrv_img_create() size\n\tselection easier to read","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"kwolf@redhat.com, vsementsov@virtuozzo.com, jsnow@redhat.com,\n\tqemu-block@nongnu.org, Max Reitz ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"All callers of bdrv_img_create() pass in a size, or -1 to read the\nsize from the backing file. We then set that size as the QemuOpt\ndefault, which means we will reuse that default rather than the\nfinal parameter to qemu_opt_get_size() several lines later. But\nit is rather confusing to read subsequent checks of 'size == -1'\nwhen it looks (without seeing the full context) like size defaults\nto 0; it also doesn't help that a size of 0 is valid (for some\nformats).\n\nRework the logic to make things more legible.\n\nSigned-off-by: Eric Blake \nReviewed-by: John Snow \n\n---\nv6: Combine into a series rather than being a standalone patch (more for\nease of tracking than for being on topic)\n---\n block.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/block.c b/block.c\nindex 3308814bba..3f84d141a7 100644\n--- a/block.c\n+++ b/block.c\n@@ -4392,7 +4392,7 @@ void bdrv_img_create(const char *filename, const char *fmt,\n\n /* The size for the image must always be specified, unless we have a backing\n * file and we have not been forbidden from opening it. */\n- size = qemu_opt_get_size(opts, BLOCK_OPT_SIZE, 0);\n+ size = qemu_opt_get_size(opts, BLOCK_OPT_SIZE, img_size);\n if (backing_file && !(flags & BDRV_O_NO_BACKING)) {\n BlockDriverState *bs;\n char *full_backing = g_new0(char, PATH_MAX);\n","prefixes":["v6","01/18"]}