{"id":807876,"url":"http://patchwork.ozlabs.org/api/1.0/patches/807876/?format=json","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/1.0/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/"},"msgid":"<20170830194617.26621-9-clg@kaod.org>","date":"2017-08-30T19:46:17","name":"[v3,8/8] powerpc/xive: improve debugging macros","commit_ref":"5f121292f0a0873fa2cd3a0292fb4860a8953f38","pull_url":null,"state":"accepted","archived":false,"hash":"9225bdf66ed7ae9b72c6e67293f687c9d3d76124","submitter":{"id":68548,"url":"http://patchwork.ozlabs.org/api/1.0/people/68548/?format=json","name":"Cédric Le Goater","email":"clg@kaod.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20170830194617.26621-9-clg@kaod.org/mbox/","series":[{"id":695,"url":"http://patchwork.ozlabs.org/api/1.0/series/695/?format=json","date":"2017-08-30T19:46:17","name":"guest exploitation of the XIVE interrupt controller","version":3,"mbox":"http://patchwork.ozlabs.org/series/695/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/807876/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjGWQ4jffz9t2M\n\tfor ;\n\tThu, 31 Aug 2017 05:57:38 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xjGWQ3XDVzDqTr\n\tfor ;\n\tThu, 31 Aug 2017 05:57:38 +1000 (AEST)","from 6.mo68.mail-out.ovh.net (6.mo68.mail-out.ovh.net\n\t[46.105.63.100])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xjGTp20wnzDqN4\n\tfor ;\n\tThu, 31 Aug 2017 05:56:14 +1000 (AEST)","from player776.ha.ovh.net (b6.ovh.net [213.186.33.56])\n\tby mo68.mail-out.ovh.net (Postfix) with ESMTP id 028C07B7E8\n\tfor ;\n\tWed, 30 Aug 2017 21:47:22 +0200 (CEST)","from zorba.kaod.org.com (LFbn-1-2231-173.w90-76.abo.wanadoo.fr\n\t[90.76.52.173]) (Authenticated sender: clg@kaod.org)\n\tby player776.ha.ovh.net (Postfix) with ESMTPSA id CA62240006E;\n\tWed, 30 Aug 2017 21:47:16 +0200 (CEST)"],"X-Greylist":"delayed 529 seconds by postgrey-1.36 at bilbo;\n\tThu, 31 Aug 2017 05:56:14 AEST","From":"=?utf-8?q?C=C3=A9dric_Le_Goater?= ","To":"linuxppc-dev@lists.ozlabs.org","Subject":"[PATCH v3 8/8] powerpc/xive: improve debugging macros","Date":"Wed, 30 Aug 2017 21:46:17 +0200","Message-Id":"<20170830194617.26621-9-clg@kaod.org>","X-Mailer":"git-send-email 2.13.5","In-Reply-To":"<20170830194617.26621-1-clg@kaod.org>","References":"<20170830194617.26621-1-clg@kaod.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-Ovh-Tracer-Id":"1606096220790295485","X-VR-SPAMSTATE":"OK","X-VR-SPAMSCORE":"-100","X-VR-SPAMCAUSE":"gggruggvucftvghtrhhoucdtuddrfeelledrudeigddugedtucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddm","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"David Gibson , Paul Mackerras\n\t, =?utf-8?q?C=C3=A9dric_Le_Goater?= ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"},"content":"Having the CPU identifier in the debug logs is helpful when tracking\nissues. Also add some more logging and fix a compile issue in\nxive_do_source_eoi().\n\nSigned-off-by: Cédric Le Goater \n---\n arch/powerpc/sysdev/xive/common.c | 8 ++++++--\n 1 file changed, 6 insertions(+), 2 deletions(-)","diff":"diff --git a/arch/powerpc/sysdev/xive/common.c b/arch/powerpc/sysdev/xive/common.c\nindex 8fd58773c241..1c087ed7427f 100644\n--- a/arch/powerpc/sysdev/xive/common.c\n+++ b/arch/powerpc/sysdev/xive/common.c\n@@ -40,7 +40,8 @@\n #undef DEBUG_ALL\n \n #ifdef DEBUG_ALL\n-#define DBG_VERBOSE(fmt...)\tpr_devel(fmt)\n+#define DBG_VERBOSE(fmt, ...)\tpr_devel(\"cpu %d - \" fmt, \\\n+\t\t\t\t\t smp_processor_id(), ## __VA_ARGS__)\n #else\n #define DBG_VERBOSE(fmt...)\tdo { } while(0)\n #endif\n@@ -344,7 +345,7 @@ void xive_do_source_eoi(u32 hw_irq, struct xive_irq_data *xd)\n \t\t\txive_esb_read(xd, XIVE_ESB_LOAD_EOI);\n \t\telse {\n \t\t\teoi_val = xive_esb_read(xd, XIVE_ESB_SET_PQ_00);\n-\t\t\tDBG_VERBOSE(\"eoi_val=%x\\n\", offset, eoi_val);\n+\t\t\tDBG_VERBOSE(\"eoi_val=%x\\n\", eoi_val);\n \n \t\t\t/* Re-trigger if needed */\n \t\t\tif ((eoi_val & XIVE_ESB_VAL_Q) && xd->trig_mmio)\n@@ -1004,6 +1005,9 @@ static void xive_ipi_eoi(struct irq_data *d)\n {\n \tstruct xive_cpu *xc = __this_cpu_read(xive_cpu);\n \n+\tDBG_VERBOSE(\"IPI eoi: irq=%d [0x%lx] (HW IRQ 0x%x) pending=%02x\\n\",\n+\t\t d->irq, irqd_to_hwirq(d), xc->hw_ipi, xc->pending_prio);\n+\n \t/* Handle possible race with unplug and drop stale IPIs */\n \tif (!xc)\n \t\treturn;\n","prefixes":["v3","8/8"]}