{"id":807869,"url":"http://patchwork.ozlabs.org/api/1.0/patches/807869/?format=json","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.0/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20170830194313.9659-3-Larry.Finger@lwfinger.net>","date":"2017-08-30T19:43:13","name":"[2/2] staging: r8822be: Simplify deinit_priv()","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":true,"hash":"2ebae0a26ce57ab214d35ae6cf06416ff9d5f4f5","submitter":{"id":190,"url":"http://patchwork.ozlabs.org/api/1.0/people/190/?format=json","name":"Larry Finger","email":"Larry.Finger@lwfinger.net"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/1.0/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20170830194313.9659-3-Larry.Finger@lwfinger.net/mbox/","series":[{"id":692,"url":"http://patchwork.ozlabs.org/api/1.0/series/692/?format=json","date":"2017-08-30T19:43:11","name":"staging: r8822be: Remove some left-over debug code","version":1,"mbox":"http://patchwork.ozlabs.org/series/692/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/807869/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"LD2R4fwP\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjGC1009Nz9t2M\n\tfor ;\n\tThu, 31 Aug 2017 05:43:24 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751349AbdH3TnW (ORCPT );\n\tWed, 30 Aug 2017 15:43:22 -0400","from mail-oi0-f67.google.com ([209.85.218.67]:35686 \"EHLO\n\tmail-oi0-f67.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751264AbdH3TnU (ORCPT\n\t); Wed, 30 Aug 2017 15:43:20 -0400","by mail-oi0-f67.google.com with SMTP id k77so6471392oib.2\n\tfor ; Wed, 30 Aug 2017 12:43:20 -0700 (PDT)","from linux-4v1g.suse (cpe-24-31-249-175.kc.res.rr.com.\n\t[24.31.249.175]) by smtp.gmail.com with ESMTPSA id\n\ty9sm4523219oia.22.2017.08.30.12.43.18\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tWed, 30 Aug 2017 12:43:18 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=sender:from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=Qn6ApOnoKDY/LhnsnKDkpknyoEJPKP/rg7/XM4h+Hfg=;\n\tb=LD2R4fwPy/PU9Ppq51avp1YF9pZ8OqaDchds5x/1vlsPofhNorFBh+JoqD4gE0ylNF\n\t7Nr3+eO88iK58ppyNnUUoPWtYxrfL0QAGhdbBjREQWmC77mL2NHTvv1Qc0R/kS8XM2QA\n\t3A3KcJP590/2OomUldulACxRN880ZztC0kDV7reqDJMW9DmDYVgSiyWBLhpt3ayW4NuC\n\tikVDl2VW/lYt2RVYTfEn2hkaDNc1uXGVnZCBzugDn1MCche93Bep5e2flPlvkMyjkOTQ\n\t8annRjr8+G70HpjjzZhXeoRO4P6KWyF0QNn6s7GE7XklOmSU2cu8aKWpOGgWc1f+eV+/\n\ttnNQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id\n\t:in-reply-to:references;\n\tbh=Qn6ApOnoKDY/LhnsnKDkpknyoEJPKP/rg7/XM4h+Hfg=;\n\tb=EeH44ANkWTOFzjIHl7cjc/0qo8Gba2qIv4huYgTb9CsW/yuYlXp2DRO7k9/gYtwXvk\n\tY2Vm4vcoJFjjwcMgOQdFgNHGVkfaTazHjQH3szm9sPvzb1TqY4DiO1Habt1mzFNjMY6h\n\tx2nV+uK6bLfmEVdrl/Qf4wfo7zzYyFalcMqnbGdlLBhLNXOTvy/NjZ4IYvx0Ct910JYL\n\tZ0z668MWbTVMJ+HvQlHmEp4HNDGSACjyZUkPOWPJ7ww3QYhQvDmGPBdAVw0K+EhP1DIY\n\tciNmGU8YsYp55UuTcgnfOpOFxBIRWBBSn3QQG+IPAewGFlxp5FblOWEuWKDBddIFOHww\n\t7Vjg==","X-Gm-Message-State":"AHYfb5hN/jp3jII8qpTuHSZIAYtbr+WTIIRGwfaiSfiZwWU9fK3fgB/G\n\t/8rnqYuLX4R3FQ==","X-Received":"by 10.202.76.137 with SMTP id z131mr2346214oia.157.1504122199639;\n\tWed, 30 Aug 2017 12:43:19 -0700 (PDT)","From":"Larry Finger ","To":"gregkh@linuxfoundation.org","Cc":"netdev@vger.kernel.org, devel@driverdev.osuosl.org,\n\tLarry Finger ,\n\tPing-Ke Shih ,\n\tYan-Hsuan Chuang ,\n\tBirming Chiu ,\n\tShaofu , Steven Ting ","Subject":"[PATCH 2/2] staging: r8822be: Simplify deinit_priv()","Date":"Wed, 30 Aug 2017 14:43:13 -0500","Message-Id":"<20170830194313.9659-3-Larry.Finger@lwfinger.net>","X-Mailer":"git-send-email 2.12.3","In-Reply-To":"<20170830194313.9659-1-Larry.Finger@lwfinger.net>","References":"<20170830194313.9659-1-Larry.Finger@lwfinger.net>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"Now that the extraneous debugging code is removed, routine deinit_priv()\nclearly contains code that serves no useful purpose.\n\nA null test before a call to kfree() and a spurious cast are also removed.\n\nSigned-off-by: Larry Finger \nCc: Ping-Ke Shih \nCc: Yan-Hsuan Chuang \nCc: Birming Chiu \nCc: Shaofu \nCc: Steven Ting \n---\n drivers/staging/rtlwifi/halmac/rtl_halmac.c | 8 +-------\n 1 file changed, 1 insertion(+), 7 deletions(-)","diff":"diff --git a/drivers/staging/rtlwifi/halmac/rtl_halmac.c b/drivers/staging/rtlwifi/halmac/rtl_halmac.c\nindex 2b1c5fae64ef..6448a8bfc14b 100644\n--- a/drivers/staging/rtlwifi/halmac/rtl_halmac.c\n+++ b/drivers/staging/rtlwifi/halmac/rtl_halmac.c\n@@ -382,13 +382,7 @@ static void deinit_priv(struct rtl_halmac *halmac)\n \n \tindicator = halmac->indicator;\n \thalmac->indicator = NULL;\n-\tif (indicator) {\n-\t\tu32 count, size;\n-\n-\t\tcount = HALMAC_FEATURE_ALL + 1;\n-\t\tsize = sizeof(*indicator) * count;\n-\t\tkfree((u8 *)indicator);\n-\t}\n+\tkfree(indicator);\n }\n \n int rtl_halmac_init_adapter(struct rtl_priv *rtlpriv)\n","prefixes":["2/2"]}