{"id":807850,"url":"http://patchwork.ozlabs.org/api/1.0/patches/807850/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20170830182141.19996-2-danielhb@linux.vnet.ibm.com>","date":"2017-08-30T18:21:39","name":"[for-2.11,v3,1/3] hw/ppc/spapr_drc.c: change spapr_drc_needed to use drc->dev","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"bc7b5ba5990b8b9b0776959042bc83f7b1fe8ca2","submitter":{"id":64623,"url":"http://patchwork.ozlabs.org/api/1.0/people/64623/?format=json","name":"Daniel Henrique Barboza","email":"danielhb@linux.vnet.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170830182141.19996-2-danielhb@linux.vnet.ibm.com/mbox/","series":[{"id":681,"url":"http://patchwork.ozlabs.org/api/1.0/series/681/?format=json","date":"2017-08-30T18:21:38","name":"hw/ppc: CAS reset on early device hotplug","version":3,"mbox":"http://patchwork.ozlabs.org/series/681/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/807850/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjDRz1d68z9sPt\n\tfor ;\n\tThu, 31 Aug 2017 04:24:31 +1000 (AEST)","from localhost ([::1]:52130 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dn7fB-0006PR-1C\n\tfor incoming@patchwork.ozlabs.org; Wed, 30 Aug 2017 14:24:29 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:57197)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dn7cp-00052U-IZ\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 14:22:04 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dn7cm-0006Pt-LT\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 14:22:03 -0400","from mx0a-001b2d01.pphosted.com ([148.163.156.1]:44478)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dn7cm-0006Pc-DD\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 14:22:00 -0400","from pps.filterd (m0098404.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv7UIK3cr013782\n\tfor ; Wed, 30 Aug 2017 14:21:58 -0400","from e19.ny.us.ibm.com (e19.ny.us.ibm.com [129.33.205.209])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2cny3c4wey-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Wed, 30 Aug 2017 14:21:58 -0400","from localhost\n\tby e19.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tWed, 30 Aug 2017 14:21:57 -0400","from b01cxnp23034.gho.pok.ibm.com (9.57.198.29)\n\tby e19.ny.us.ibm.com (146.89.104.206) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tWed, 30 Aug 2017 14:21:54 -0400","from b01ledav005.gho.pok.ibm.com (b01ledav005.gho.pok.ibm.com\n\t[9.57.199.110])\n\tby b01cxnp23034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP\n\tid v7UILskI27197458; Wed, 30 Aug 2017 18:21:54 GMT","from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 4EE39AE03C;\n\tWed, 30 Aug 2017 14:22:18 -0400 (EDT)","from localhost.localdomain (unknown [9.80.235.18])\n\tby b01ledav005.gho.pok.ibm.com (Postfix) with ESMTP id F1C54AE04B;\n\tWed, 30 Aug 2017 14:22:16 -0400 (EDT)"],"From":"Daniel Henrique Barboza ","To":"qemu-devel@nongnu.org","Date":"Wed, 30 Aug 2017 15:21:39 -0300","X-Mailer":"git-send-email 2.9.4","In-Reply-To":"<20170830182141.19996-1-danielhb@linux.vnet.ibm.com>","References":"<20170830182141.19996-1-danielhb@linux.vnet.ibm.com>","X-TM-AS-GCONF":"00","x-cbid":"17083018-0056-0000-0000-000003BECCEE","X-IBM-SpamModules-Scores":"","X-IBM-SpamModules-Versions":"BY=3.00007637; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000226; SDB=6.00909837; UDB=6.00456354;\n\tIPR=6.00690121; \n\tBA=6.00005562; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00016930;\n\tXFM=3.00000015; UTC=2017-08-30 18:21:56","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17083018-0057-0000-0000-000007F4FDF8","Message-Id":"<20170830182141.19996-2-danielhb@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-08-30_08:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=1\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1708300278","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.156.1","Subject":"[Qemu-devel] [PATCH for-2.11 v3 1/3] hw/ppc/spapr_drc.c: change\n\tspapr_drc_needed to use drc->dev","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-ppc@nongnu.org, mdroth@linux.vnet.ibm.com,\n\tdavid@gibson.dropbear.id.au","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"This patch makes a small fix in 'spapr_drc_needed' to change how we detect\nif a DRC has a device attached. Previously it used dr_entity_sense for this,\nwhich works for physical DRCs.\n\nHowever, for logical DRCs, it didn't cover the case where a logical DRC has\na drc->dev but the state is LOGICAL_UNUSABLE (e.g. a hotplugged CPU before\nCAS). In this case, the dr_entity_sense of this DRC returns UNUSABLE and the\ncode was considering that there were no dev attached, making spapr_drc_needed\nreturn 'false' when in fact we would like to migrate the DRC.\n\nChanging it to check for drc->dev instead works for all DRC types.\n\nSigned-off-by: Daniel Henrique Barboza \n---\n hw/ppc/spapr_drc.c | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)","diff":"diff --git a/hw/ppc/spapr_drc.c b/hw/ppc/spapr_drc.c\nindex 6541a52..6670a76 100644\n--- a/hw/ppc/spapr_drc.c\n+++ b/hw/ppc/spapr_drc.c\n@@ -464,10 +464,9 @@ static bool spapr_drc_needed(void *opaque)\n {\n sPAPRDRConnector *drc = (sPAPRDRConnector *)opaque;\n sPAPRDRConnectorClass *drck = SPAPR_DR_CONNECTOR_GET_CLASS(drc);\n- sPAPRDREntitySense value = drck->dr_entity_sense(drc);\n \n /* If no dev is plugged in there is no need to migrate the DRC state */\n- if (value != SPAPR_DR_ENTITY_SENSE_PRESENT) {\n+ if (!drc->dev) {\n return false;\n }\n \n","prefixes":["for-2.11","v3","1/3"]}