{"id":807787,"url":"http://patchwork.ozlabs.org/api/1.0/patches/807787/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<8fe8ddad6b924b460ca4ed4a7e401c18d24c246f.1504112061.git.jcody@redhat.com>","date":"2017-08-30T16:57:00","name":"[v2,3/7] block/sheepdog: remove spurious NULL check","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"3a4785a768158e226a9880cfda972cac1359ac52","submitter":{"id":12159,"url":"http://patchwork.ozlabs.org/api/1.0/people/12159/?format=json","name":"Jeff Cody","email":"jcody@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/8fe8ddad6b924b460ca4ed4a7e401c18d24c246f.1504112061.git.jcody@redhat.com/mbox/","series":[{"id":664,"url":"http://patchwork.ozlabs.org/api/1.0/series/664/?format=json","date":"2017-08-30T16:56:58","name":"Code cleanup and minor fixes","version":2,"mbox":"http://patchwork.ozlabs.org/series/664/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/807787/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=jcody@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjCJL5Y9tz9sN7\n\tfor ;\n\tThu, 31 Aug 2017 03:32:50 +1000 (AEST)","from localhost ([::1]:51807 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dn6rA-00042h-Go\n\tfor incoming@patchwork.ozlabs.org; Wed, 30 Aug 2017 13:32:48 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:58342)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dn6Ij-0005Sw-Ck\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 12:57:14 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dn6Ii-0006p7-PX\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 12:57:13 -0400","from mx1.redhat.com ([209.132.183.28]:24651)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dn6Ig-0006mv-1B; Wed, 30 Aug 2017 12:57:10 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id DC7B881DE2;\n\tWed, 30 Aug 2017 16:57:08 +0000 (UTC)","from localhost (ovpn-116-70.phx2.redhat.com [10.3.116.70])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 8D06487FAE;\n\tWed, 30 Aug 2017 16:57:08 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com DC7B881DE2","From":"Jeff Cody ","To":"qemu-devel@nongnu.org","Date":"Wed, 30 Aug 2017 12:57:00 -0400","Message-Id":"<8fe8ddad6b924b460ca4ed4a7e401c18d24c246f.1504112061.git.jcody@redhat.com>","In-Reply-To":["",""],"References":["",""],"X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tWed, 30 Aug 2017 16:57:09 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH v2 3/7] block/sheepdog: remove spurious NULL\n\tcheck","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"mitake.hitoshi@lab.ntt.co.jp, namei.unix@gmail.com, kwolf@redhat.com,\n\trjones@redhat.com, qemu-block@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"'tag' is already checked in the lines immediately preceding this check,\nand set to non-NULL if NULL. No need to check again, it hasn't changed.\n\nSigned-off-by: Jeff Cody \n---\n block/sheepdog.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/block/sheepdog.c b/block/sheepdog.c\nindex abb2e79..bbbfa72 100644\n--- a/block/sheepdog.c\n+++ b/block/sheepdog.c\n@@ -1632,7 +1632,7 @@ static int sd_open(BlockDriverState *bs, QDict *options, int flags,\n if (!tag) {\n tag = \"\";\n }\n- if (tag && strlen(tag) >= SD_MAX_VDI_TAG_LEN) {\n+ if (strlen(tag) >= SD_MAX_VDI_TAG_LEN) {\n error_setg(errp, \"value of parameter 'tag' is too long\");\n ret = -EINVAL;\n goto err_no_fd;\n","prefixes":["v2","3/7"]}