{"id":807722,"url":"http://patchwork.ozlabs.org/api/1.0/patches/807722/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"","date":"2017-08-30T16:52:47","name":"[v3,5/5] qemu-iotests: add option to save temp files on error","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"c185007da3d62e3f9b2b1af1079608f60eb8e54d","submitter":{"id":12159,"url":"http://patchwork.ozlabs.org/api/1.0/people/12159/?format=json","name":"Jeff Cody","email":"jcody@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/e99a5e3feefe5fdb54d64fb80b09089618a0ff49.1504111803.git.jcody@redhat.com/mbox/","series":[{"id":657,"url":"http://patchwork.ozlabs.org/api/1.0/series/657/?format=json","date":"2017-08-30T16:52:47","name":"qemu-iotests: place output in unique dir","version":3,"mbox":"http://patchwork.ozlabs.org/series/657/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/807722/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=jcody@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjBRY51s2z9sPt\n\tfor ;\n\tThu, 31 Aug 2017 02:54:01 +1000 (AEST)","from localhost ([::1]:51614 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dn6Fb-0001Nz-Eg\n\tfor incoming@patchwork.ozlabs.org; Wed, 30 Aug 2017 12:53:59 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:56322)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dn6Er-0001Ls-Cc\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 12:53:14 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dn6Eq-0004wy-HQ\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 12:53:13 -0400","from mx1.redhat.com ([209.132.183.28]:36600)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dn6El-0004vX-Fj; Wed, 30 Aug 2017 12:53:07 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 656E213A47;\n\tWed, 30 Aug 2017 16:53:06 +0000 (UTC)","from localhost (ovpn-116-70.phx2.redhat.com [10.3.116.70])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 30FB68F341;\n\tWed, 30 Aug 2017 16:53:06 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 656E213A47","From":"Jeff Cody ","To":"qemu-devel@nongnu.org","Date":"Wed, 30 Aug 2017 12:52:47 -0400","Message-Id":"","In-Reply-To":["",""],"References":["",""],"X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]);\n\tWed, 30 Aug 2017 16:53:06 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH v3 5/5] qemu-iotests: add option to save temp\n\tfiles on error","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"kwolf@redhat.com, qemu-block@nongnu.org, armbru@redhat.com,\n\tstefanha@redhat.com, jsnow@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"Now that ./check takes care of cleaning up after each tests, it\ncan also selectively not clean up. Add option to leave all output from\ntests intact if that test encountered an error.\n\nNote: this currently only works for bash tests, as the python tests\nstill clean up after themselves manually.\n\nSigned-off-by: Jeff Cody \n---\n tests/qemu-iotests/check | 10 +++++++++-\n tests/qemu-iotests/common | 6 ++++++\n 2 files changed, 15 insertions(+), 1 deletion(-)","diff":"diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check\nindex f6ca85d..8a5fc0d 100755\n--- a/tests/qemu-iotests/check\n+++ b/tests/qemu-iotests/check\n@@ -370,7 +370,15 @@ do\n fi\n fi\n \n- rm -rf \"$TEST_DIR_SEQ\"\n+ #TODO: There is some intial work to save intermediate files\n+ # in python tests, but it is imperfect. Having each\n+ # test record its test name, and the tearDown function\n+ # just move intermediate images to a subdirectory with\n+ # the test name may prove more useful.\n+ if [ \"$save_on_err\" != \"true\" ] || [ \"$err\" != \"true\" ]\n+ then\n+ rm -rf \"$TEST_DIR_SEQ\"\n+ fi\n \n fi\n \ndiff --git a/tests/qemu-iotests/common b/tests/qemu-iotests/common\nindex d34c11c..d08b233 100644\n--- a/tests/qemu-iotests/common\n+++ b/tests/qemu-iotests/common\n@@ -42,6 +42,7 @@ expunge=true\n have_test_arg=false\n randomize=false\n cachemode=false\n+save_on_err=false\n rm -f $tmp.list $tmp.tmp $tmp.sed\n \n export IMGFMT=raw\n@@ -172,6 +173,7 @@ other options\n -T output timestamps\n -r randomize test order\n -c mode cache mode\n+ -s save test scratch directory on test failure\n \n testlist options\n -g group[,group...] include tests from these groups\n@@ -349,6 +351,10 @@ testlist options\n xgroup=true\n xpand=false\n ;;\n+ -s)\n+ save_on_err=true\n+ xpand=false\n+ ;;\n '[0-9][0-9][0-9] [0-9][0-9][0-9][0-9]')\n echo \"No tests?\"\n status=1\n","prefixes":["v3","5/5"]}