{"id":807702,"url":"http://patchwork.ozlabs.org/api/1.0/patches/807702/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20170830163609.50260-2-pasic@linux.vnet.ibm.com>","date":"2017-08-30T16:36:01","name":"[1/9] s390x/css: fix cc handling for XSCH","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"64b60ee2c50e378cb94d52e79be8b82df7594645","submitter":{"id":68297,"url":"http://patchwork.ozlabs.org/api/1.0/people/68297/?format=json","name":"Halil Pasic","email":"pasic@linux.vnet.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170830163609.50260-2-pasic@linux.vnet.ibm.com/mbox/","series":[{"id":648,"url":"http://patchwork.ozlabs.org/api/1.0/series/648/?format=json","date":"2017-08-30T16:36:02","name":"","version":1,"mbox":"http://patchwork.ozlabs.org/series/648/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/807702/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjB4C53xLz9sQl\n\tfor ;\n\tThu, 31 Aug 2017 02:37:14 +1000 (AEST)","from localhost ([::1]:51541 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dn5zL-0007Fu-G1\n\tfor incoming@patchwork.ozlabs.org; Wed, 30 Aug 2017 12:37:11 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:50120)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dn5yg-0007Ff-3J\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 12:36:30 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dn5yc-0006GG-Vl\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 12:36:30 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5]:54920\n\thelo=mx0a-001b2d01.pphosted.com)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dn5yc-0006Fp-Px\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 12:36:26 -0400","from pps.filterd (m0098420.ppops.net [127.0.0.1])\n\tby mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv7UGTBMS138568\n\tfor ; Wed, 30 Aug 2017 12:36:24 -0400","from e06smtp10.uk.ibm.com (e06smtp10.uk.ibm.com [195.75.94.106])\n\tby mx0b-001b2d01.pphosted.com with ESMTP id 2cnx0xp95j-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Wed, 30 Aug 2017 12:36:24 -0400","from localhost\n\tby e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tWed, 30 Aug 2017 17:36:22 +0100","from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194)\n\tby e06smtp10.uk.ibm.com (192.168.101.140) with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be prosecuted; \n\tWed, 30 Aug 2017 17:36:21 +0100","from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com\n\t[9.149.105.232])\n\tby b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v7UGaLNF19267738; Wed, 30 Aug 2017 16:36:21 GMT","from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 0849352041;\n\tWed, 30 Aug 2017 16:31:48 +0100 (BST)","from tuxmaker.boeblingen.de.ibm.com (unknown [9.152.85.9])\n\tby d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTPS id CECC95203F; \n\tWed, 30 Aug 2017 16:31:47 +0100 (BST)"],"From":"Halil Pasic ","To":"Cornelia Huck ","Date":"Wed, 30 Aug 2017 18:36:01 +0200","X-Mailer":"git-send-email 2.13.5","In-Reply-To":"<20170830163609.50260-1-pasic@linux.vnet.ibm.com>","References":"<20170830163609.50260-1-pasic@linux.vnet.ibm.com>","X-TM-AS-GCONF":"00","x-cbid":"17083016-0040-0000-0000-000003D471AC","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17083016-0041-0000-0000-000025D4E31C","Message-Id":"<20170830163609.50260-2-pasic@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-08-30_07:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1708300251","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.158.5","Subject":"[Qemu-devel] [PATCH 1/9] s390x/css: fix cc handling for XSCH","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Dong Jia Shi ,\n\tHalil Pasic ,\n\tPierre Morel , qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"The function ioinst_handle_xsch is presenting cc 2 when it's supposed to\npresent cc 1 and the other way around, because css_do_xsch has the error\ncodes mixed up. Fixing the error codes also fixes the priority.\n\nLet us fix this.\n\nSigned-off-by: Halil Pasic \nReported-by: Pierre Morel\n---\n hw/s390x/css.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/hw/s390x/css.c b/hw/s390x/css.c\nindex 1880b1a0ff..a50fb0727e 100644\n--- a/hw/s390x/css.c\n+++ b/hw/s390x/css.c\n@@ -1281,12 +1281,12 @@ int css_do_xsch(SubchDev *sch)\n (!(s->ctrl &\n (SCSW_ACTL_RESUME_PEND | SCSW_ACTL_START_PEND | SCSW_ACTL_SUSP))) ||\n (s->ctrl & SCSW_ACTL_SUBCH_ACTIVE)) {\n- ret = -EINPROGRESS;\n+ ret = -EBUSY;\n goto out;\n }\n \n if (s->ctrl & SCSW_CTRL_MASK_STCTL) {\n- ret = -EBUSY;\n+ ret = -EINPROGRESS;\n goto out;\n }\n \n","prefixes":["1/9"]}