{"id":807496,"url":"http://patchwork.ozlabs.org/api/1.0/patches/807496/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<1504081950-2528-2-git-send-email-peterx@redhat.com>","date":"2017-08-30T08:31:58","name":"[RFC,v2,01/33] bitmap: remove BITOP_WORD()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"3cd50175aa8a265cb9454a4137d7b6879db18339","submitter":{"id":67717,"url":"http://patchwork.ozlabs.org/api/1.0/people/67717/?format=json","name":"Peter Xu","email":"peterx@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/1504081950-2528-2-git-send-email-peterx@redhat.com/mbox/","series":[{"id":552,"url":"http://patchwork.ozlabs.org/api/1.0/series/552/?format=json","date":"2017-08-30T08:31:59","name":"Migration: postcopy failure recovery","version":2,"mbox":"http://patchwork.ozlabs.org/series/552/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/807496/checks/","tags":{},"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=peterx@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xhzW96tHPz9t1t\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 30 Aug 2017 18:41:25 +1000 (AEST)","from localhost ([::1]:49051 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dmyYt-0005L5-Kl\n\tfor incoming@patchwork.ozlabs.org; Wed, 30 Aug 2017 04:41:23 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:33872)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <peterx@redhat.com>) id 1dmyQY-0006hT-Nx\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 04:32:47 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <peterx@redhat.com>) id 1dmyQX-00036p-6O\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 04:32:46 -0400","from mx1.redhat.com ([209.132.183.28]:39230)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <peterx@redhat.com>) id 1dmyQX-00036R-0X\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 04:32:45 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id DF219883C6;\n\tWed, 30 Aug 2017 08:32:43 +0000 (UTC)","from pxdev.xzpeter.org.com (dhcp-14-103.nay.redhat.com\n\t[10.66.14.103])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id E94BE84792;\n\tWed, 30 Aug 2017 08:32:40 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com DF219883C6","From":"Peter Xu <peterx@redhat.com>","To":"qemu-devel@nongnu.org","Date":"Wed, 30 Aug 2017 16:31:58 +0800","Message-Id":"<1504081950-2528-2-git-send-email-peterx@redhat.com>","In-Reply-To":"<1504081950-2528-1-git-send-email-peterx@redhat.com>","References":"<1504081950-2528-1-git-send-email-peterx@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tWed, 30 Aug 2017 08:32:44 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [RFC v2 01/33] bitmap: remove BITOP_WORD()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Laurent Vivier <lvivier@redhat.com>,\n\tAndrea Arcangeli <aarcange@redhat.com>, \n\tJuan Quintela <quintela@redhat.com>,\n\tAlexey Perevalov <a.perevalov@samsung.com>, peterx@redhat.com,\n\t\"Dr . David Alan Gilbert\" <dgilbert@redhat.com>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"},"content":"We have BIT_WORD(). It's the same.\n\nSigned-off-by: Peter Xu <peterx@redhat.com>\n---\n util/bitops.c | 6 ++----\n 1 file changed, 2 insertions(+), 4 deletions(-)","diff":"diff --git a/util/bitops.c b/util/bitops.c\nindex b0c35dd..f236401 100644\n--- a/util/bitops.c\n+++ b/util/bitops.c\n@@ -14,15 +14,13 @@\n #include \"qemu/osdep.h\"\n #include \"qemu/bitops.h\"\n \n-#define BITOP_WORD(nr)\t\t((nr) / BITS_PER_LONG)\n-\n /*\n  * Find the next set bit in a memory region.\n  */\n unsigned long find_next_bit(const unsigned long *addr, unsigned long size,\n \t\t\t    unsigned long offset)\n {\n-    const unsigned long *p = addr + BITOP_WORD(offset);\n+    const unsigned long *p = addr + BIT_WORD(offset);\n     unsigned long result = offset & ~(BITS_PER_LONG-1);\n     unsigned long tmp;\n \n@@ -87,7 +85,7 @@ found_middle:\n unsigned long find_next_zero_bit(const unsigned long *addr, unsigned long size,\n \t\t\t\t unsigned long offset)\n {\n-    const unsigned long *p = addr + BITOP_WORD(offset);\n+    const unsigned long *p = addr + BIT_WORD(offset);\n     unsigned long result = offset & ~(BITS_PER_LONG-1);\n     unsigned long tmp;\n \n","prefixes":["RFC","v2","01/33"]}