{"id":807482,"url":"http://patchwork.ozlabs.org/api/1.0/patches/807482/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<1504081950-2528-3-git-send-email-peterx@redhat.com>","date":"2017-08-30T08:31:59","name":"[RFC,v2,02/33] bitmap: introduce bitmap_count_one()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"e2c7e5fe51271515c4468870e15ec219c03356b9","submitter":{"id":67717,"url":"http://patchwork.ozlabs.org/api/1.0/people/67717/?format=json","name":"Peter Xu","email":"peterx@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/1504081950-2528-3-git-send-email-peterx@redhat.com/mbox/","series":[{"id":552,"url":"http://patchwork.ozlabs.org/api/1.0/series/552/?format=json","date":"2017-08-30T08:31:59","name":"Migration: postcopy failure recovery","version":2,"mbox":"http://patchwork.ozlabs.org/series/552/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/807482/checks/","tags":{},"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=peterx@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xhzLB4GQ8z9sRq\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 30 Aug 2017 18:33:38 +1000 (AEST)","from localhost ([::1]:49006 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dmyRM-0006ly-9k\n\tfor incoming@patchwork.ozlabs.org; Wed, 30 Aug 2017 04:33:36 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:33891)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <peterx@redhat.com>) id 1dmyQb-0006ju-Dv\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 04:32:50 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <peterx@redhat.com>) id 1dmyQa-000388-JH\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 04:32:49 -0400","from mx1.redhat.com ([209.132.183.28]:37114)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <peterx@redhat.com>) id 1dmyQa-00037p-Cu\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 04:32:48 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 627BB80099;\n\tWed, 30 Aug 2017 08:32:47 +0000 (UTC)","from pxdev.xzpeter.org.com (dhcp-14-103.nay.redhat.com\n\t[10.66.14.103])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 68CD084792;\n\tWed, 30 Aug 2017 08:32:44 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 627BB80099","From":"Peter Xu <peterx@redhat.com>","To":"qemu-devel@nongnu.org","Date":"Wed, 30 Aug 2017 16:31:59 +0800","Message-Id":"<1504081950-2528-3-git-send-email-peterx@redhat.com>","In-Reply-To":"<1504081950-2528-1-git-send-email-peterx@redhat.com>","References":"<1504081950-2528-1-git-send-email-peterx@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]);\n\tWed, 30 Aug 2017 08:32:47 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [RFC v2 02/33] bitmap: introduce bitmap_count_one()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Laurent Vivier <lvivier@redhat.com>,\n\tAndrea Arcangeli <aarcange@redhat.com>, \n\tJuan Quintela <quintela@redhat.com>,\n\tAlexey Perevalov <a.perevalov@samsung.com>, peterx@redhat.com,\n\t\"Dr . David Alan Gilbert\" <dgilbert@redhat.com>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"},"content":"Count how many bits set in the bitmap.\n\nReviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>\nSigned-off-by: Peter Xu <peterx@redhat.com>\n---\n include/qemu/bitmap.h | 10 ++++++++++\n util/bitmap.c         | 15 +++++++++++++++\n 2 files changed, 25 insertions(+)","diff":"diff --git a/include/qemu/bitmap.h b/include/qemu/bitmap.h\nindex c318da1..a13bd28 100644\n--- a/include/qemu/bitmap.h\n+++ b/include/qemu/bitmap.h\n@@ -82,6 +82,7 @@ int slow_bitmap_andnot(unsigned long *dst, const unsigned long *bitmap1,\n                        const unsigned long *bitmap2, long bits);\n int slow_bitmap_intersects(const unsigned long *bitmap1,\n                            const unsigned long *bitmap2, long bits);\n+long slow_bitmap_count_one(const unsigned long *bitmap, long nbits);\n \n static inline unsigned long *bitmap_try_new(long nbits)\n {\n@@ -216,6 +217,15 @@ static inline int bitmap_intersects(const unsigned long *src1,\n     }\n }\n \n+static inline long bitmap_count_one(const unsigned long *bitmap, long nbits)\n+{\n+    if (small_nbits(nbits)) {\n+        return (ctpopl(*bitmap & BITMAP_LAST_WORD_MASK(nbits)));\n+    } else {\n+        return slow_bitmap_count_one(bitmap, nbits);\n+    }\n+}\n+\n void bitmap_set(unsigned long *map, long i, long len);\n void bitmap_set_atomic(unsigned long *map, long i, long len);\n void bitmap_clear(unsigned long *map, long start, long nr);\ndiff --git a/util/bitmap.c b/util/bitmap.c\nindex efced9a..3446d72 100644\n--- a/util/bitmap.c\n+++ b/util/bitmap.c\n@@ -355,3 +355,18 @@ int slow_bitmap_intersects(const unsigned long *bitmap1,\n     }\n     return 0;\n }\n+\n+long slow_bitmap_count_one(const unsigned long *bitmap, long nbits)\n+{\n+    long k, lim = nbits/BITS_PER_LONG, result = 0;\n+\n+    for (k = 0; k < lim; k++) {\n+        result += ctpopl(bitmap[k]);\n+    }\n+\n+    if (nbits % BITS_PER_LONG) {\n+        result += ctpopl(bitmap[k] & BITMAP_LAST_WORD_MASK(nbits));\n+    }\n+\n+    return result;\n+}\n","prefixes":["RFC","v2","02/33"]}