{"id":807433,"url":"http://patchwork.ozlabs.org/api/1.0/patches/807433/?format=json","project":{"id":44,"url":"http://patchwork.ozlabs.org/api/1.0/projects/44/?format=json","name":"skiboot firmware development","link_name":"skiboot","list_id":"skiboot.lists.ozlabs.org","list_email":"skiboot@lists.ozlabs.org","web_url":"http://github.com/open-power/skiboot","scm_url":"http://github.com/open-power/skiboot","webscm_url":""},"msgid":"<20170830062011.15199-4-npiggin@gmail.com>","date":"2017-08-30T06:20:11","name":"[3/3] init: add missing sync_icache after exception vector patching","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"c9abd9cc156f509610fa70848be7952c810abeb8","submitter":{"id":69518,"url":"http://patchwork.ozlabs.org/api/1.0/people/69518/?format=json","name":"Nicholas Piggin","email":"npiggin@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/skiboot/patch/20170830062011.15199-4-npiggin@gmail.com/mbox/","series":[{"id":532,"url":"http://patchwork.ozlabs.org/api/1.0/series/532/?format=json","date":"2017-08-30T06:20:08","name":"misc idle fixes","version":1,"mbox":"http://patchwork.ozlabs.org/series/532/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/807433/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","skiboot@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","skiboot@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xhwPn29tcz9sNc\n\tfor ;\n\tWed, 30 Aug 2017 16:21:33 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xhwPn12qZzDqHx\n\tfor ;\n\tWed, 30 Aug 2017 16:21:33 +1000 (AEST)","from mail-pf0-x244.google.com (mail-pf0-x244.google.com\n\t[IPv6:2607:f8b0:400e:c00::244])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xhwP108ndzDqJ3\n\tfor ; Wed, 30 Aug 2017 16:20:53 +1000 (AEST)","by mail-pf0-x244.google.com with SMTP id r187so3742430pfr.5\n\tfor ; Tue, 29 Aug 2017 23:20:52 -0700 (PDT)","from roar.au.ibm.com (203-219-56-202.tpgi.com.au. [203.219.56.202])\n\tby smtp.gmail.com with ESMTPSA id\n\t82sm8266783pgb.86.2017.08.29.23.20.47\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 29 Aug 2017 23:20:49 -0700 (PDT)"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"d1D/82RG\"; dkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"d1D/82RG\"; dkim-atps=neutral","lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"d1D/82RG\"; dkim-atps=neutral"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=Zrw5B37hH4V6zGRXXvG+GOgRv2wPgWLr6wcCsoJG2d8=;\n\tb=d1D/82RGz/vso7ib7nyLCy5J5OfXIre9o57E0ltScE7OQbgbF480sUlq9cvjS+/9Wl\n\tVt4ovocRd3FhCLqmtymKLnp0w80T3RomxBJNR0rHTBzmvmT5AtI2tQqLLolNYjP0k1Tn\n\tdEHsc/2MwduN/AYZtLoGtk8nPSKAnPitKogOGYUbKjI/5zdwBwj2uHBNLjnJxqTD80ZW\n\tdDvjzN/yfcuJoAQfsTehI3rExgHMl9PyNVVPrU0w8rvMDtrxOmxvkFne/K6SMF8Flf5e\n\t6PnSv871mcsCNq750B16IWUApajWyazG25LRWbedSO7nANqLwBbI/ubadJgH/PnwhUf+\n\tJT/Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=Zrw5B37hH4V6zGRXXvG+GOgRv2wPgWLr6wcCsoJG2d8=;\n\tb=RvOTezeoT8PGI7QqNYcZ3oUaAPvk753G5csLfx0Aic77e1KIVQLdPVZqv6IWsoUmRQ\n\tTZ7n+otE6BQW3XfsBy8IVLseVro8oq9a3bR6vF/a0Rb4pLl9cqhsvSD+W2bmWkJdUviO\n\t4EZIZwwI+IPDvxXWVdUtDZYonfXlnczF2TPM4XWzA8ryaHITWLH/dRRvtW5Q5efYbcLU\n\tXBX6wAGjgf+anmvy32jib4X+grLMpSjL0qgIlRcu31my6xcsH7FESW2MJj5x8SIgus7/\n\ty2IymAfiP4XPyepoxCXsMSucl6Q014OZZoqII4TndAWeK3HK8SrT6mbOcVhWkT2P3z10\n\ttU4A==","X-Gm-Message-State":"AHYfb5gyYnJ17c96zz206qPn0SBpO6Mhur+rjnC3mA/Cob/qO2PGTe33\n\tbMOOMwZTlRm5Y7fN","X-Received":"by 10.84.217.150 with SMTP id p22mr642489pli.178.1504074050662; \n\tTue, 29 Aug 2017 23:20:50 -0700 (PDT)","From":"Nicholas Piggin ","To":"skiboot@lists.ozlabs.org","Date":"Wed, 30 Aug 2017 16:20:11 +1000","Message-Id":"<20170830062011.15199-4-npiggin@gmail.com>","X-Mailer":"git-send-email 2.13.3","In-Reply-To":"<20170830062011.15199-1-npiggin@gmail.com>","References":"<20170830062011.15199-1-npiggin@gmail.com>","Subject":"[Skiboot] [PATCH 3/3] init: add missing sync_icache after exception\n\tvector patching","X-BeenThere":"skiboot@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Mailing list for skiboot development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"\"Gautham R . Shenoy\" ","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"Skiboot\"\n\t"},"content":"There are two cases where sync_icache is not called immediately\nafter instructions are modified.\n\nSigned-off-by: Nicholas Piggin \n---\n core/init.c | 2 ++\n 1 file changed, 2 insertions(+)","diff":"diff --git a/core/init.c b/core/init.c\nindex a96a69c8..8951e17b 100644\n--- a/core/init.c\n+++ b/core/init.c\n@@ -384,6 +384,7 @@ static bool load_kernel(void)\n \t\tif (kernel_entry < 0x2000) {\n \t\t\tcpu_set_pm_enable(false);\n \t\t\tmemcpy(NULL, old_vectors, 0x2000);\n+\t\t\tsync_icache();\n \t\t}\n \t\tdo_stb = true;\n \t\tstb_container = kh; /* probably incorrect */\n@@ -723,6 +724,7 @@ void setup_reset_vector(void)\n \tdst = (uint32_t *)0x100;\n \twhile(src < &reset_patch_end)\n \t\t*(dst++) = *(src++);\n+\tsync_icache();\n }\n \n void copy_exception_vectors(void)\n","prefixes":["3/3"]}