{"id":807354,"url":"http://patchwork.ozlabs.org/api/1.0/patches/807354/?format=json","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.0/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20170829232711.1465-6-tom@quantonium.net>","date":"2017-08-29T23:27:10","name":"[v2,net-next,5/6] fou: Support flow dissection","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":true,"hash":"93357d1b3e8f9b31e0b8db29b8de961e2e9ef5aa","submitter":{"id":72064,"url":"http://patchwork.ozlabs.org/api/1.0/people/72064/?format=json","name":"Tom Herbert","email":"tom@quantonium.net"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/1.0/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20170829232711.1465-6-tom@quantonium.net/mbox/","series":[{"id":503,"url":"http://patchwork.ozlabs.org/api/1.0/series/503/?format=json","date":"2017-08-29T23:27:05","name":"flow_dissector: Protocol specific flow dissector offload","version":2,"mbox":"http://patchwork.ozlabs.org/series/503/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/807354/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=quantonium-net.20150623.gappssmtp.com\n\theader.i=@quantonium-net.20150623.gappssmtp.com\n\theader.b=\"oGpqrV33\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhlDW0W4Fz9s9Y\n\tfor ;\n\tWed, 30 Aug 2017 09:27:55 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751829AbdH2X1p (ORCPT );\n\tTue, 29 Aug 2017 19:27:45 -0400","from mail-pg0-f53.google.com ([74.125.83.53]:38270 \"EHLO\n\tmail-pg0-f53.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751792AbdH2X1n (ORCPT\n\t); Tue, 29 Aug 2017 19:27:43 -0400","by mail-pg0-f53.google.com with SMTP id b8so14936960pgn.5\n\tfor ; Tue, 29 Aug 2017 16:27:43 -0700 (PDT)","from localhost.localdomain (67-207-98-108.static.wiline.com.\n\t[67.207.98.108]) by smtp.gmail.com with ESMTPSA id\n\tr73sm6445593pfa.143.2017.08.29.16.27.41\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 29 Aug 2017 16:27:42 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=quantonium-net.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=iTpwfmSqYm+U2pPyX4deOP8YcIK636yLP8yOe/K6Rxw=;\n\tb=oGpqrV33L3AV5+G9w87XwUYesviU9zZKxcqh9jZI66a8GN3X/gz/fjk3FcSOvOyy8l\n\t4JZuPehDx4qjz0LeUXxnEdRBdtbm/v6TQQaY0Y4E0dpIUkN0ayF+IAIAUiiFS4QyE/6r\n\tI8erVs/YwY6esib8yImlsTD2yPmS+aePYSiIkoAwIu58bxZivh4WK03Jk7n3f3m2M7bY\n\tvRCjL67nLTWSgorlT6BVXhkhbHA2XKiKtqK3WkjPLA+Xe7kUuVc/5U5tAkgcRzXCLuZq\n\tFZ3WMmXqN5p0//FGxLRy9LPDp3G3nBLI8D5K5iFwMrVBSu+C8hNCmYPi0K5dIWUphu8K\n\tViTQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=iTpwfmSqYm+U2pPyX4deOP8YcIK636yLP8yOe/K6Rxw=;\n\tb=mUujtgK3xqSLNqQX9sqyqOUVRJS5sESNise+fk8TX4O+/Y6uzRpWJ/T4Gy5pAZ5Xh9\n\ttsxaYg4rQVKijpVlFaL5p39iszRd92VyYGIRhfIL8dnAoJ3tVjZkHZHD9hvIFUQF8YPj\n\tleLexwUivB5OGckmAmpY5IU81nmGzwTHXTeqjBeO+N2NZYlRC1AAjoyIrD32P50+efB8\n\t2xCulRQTprlSkiXKJQ9HJaIYjZZFUU7QnbHznScSctkX8N0C8azUxpoSSuLUGW/vORo9\n\tFX1w7zdSK9bdA9YopleqFFDoLioZQu62sPilq6a5qvvcnDUu1KIDBLgJ7coYg5KZ5gXC\n\t7+tA==","X-Gm-Message-State":"AHYfb5jTCd6vXcLPTfVs/vmnqgm+FQRWL0jXN2cimn7b8BFOP2v+56TE\n\tXa4g0i1R4EluDu0K","X-Received":"by 10.98.41.68 with SMTP id p65mr1943657pfp.283.1504049263261;\n\tTue, 29 Aug 2017 16:27:43 -0700 (PDT)","From":"Tom Herbert ","To":"davem@davemloft.net","Cc":"netdev@vger.kernel.org, Tom Herbert ","Subject":"[PATCH v2 net-next 5/6] fou: Support flow dissection","Date":"Tue, 29 Aug 2017 16:27:10 -0700","Message-Id":"<20170829232711.1465-6-tom@quantonium.net>","X-Mailer":"git-send-email 2.11.0","In-Reply-To":"<20170829232711.1465-1-tom@quantonium.net>","References":"<20170829232711.1465-1-tom@quantonium.net>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"Populate offload flow_dissect callabck appropriately for fou and gue.\n\nSigned-off-by: Tom Herbert \n---\n net/ipv4/fou.c | 63 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++\n 1 file changed, 63 insertions(+)","diff":"diff --git a/net/ipv4/fou.c b/net/ipv4/fou.c\nindex 1540db65241a..a831dd49fb28 100644\n--- a/net/ipv4/fou.c\n+++ b/net/ipv4/fou.c\n@@ -282,6 +282,20 @@ static int fou_gro_complete(struct sock *sk, struct sk_buff *skb,\n \treturn err;\n }\n \n+static enum flow_dissect_ret fou_flow_dissect(struct sock *sk,\n+\t\t\tconst struct sk_buff *skb,\n+\t\t\tstruct flow_dissector_key_control *key_control,\n+\t\t\tstruct flow_dissector *flow_dissector,\n+\t\t\tvoid *target_container, void *data,\n+\t\t\t__be16 *p_proto, u8 *p_ip_proto, int *p_nhoff,\n+\t\t\tint *p_hlen, unsigned int flags)\n+{\n+\t*p_ip_proto = fou_from_sock(sk)->protocol;\n+\t*p_nhoff += sizeof(struct udphdr);\n+\n+\treturn FLOW_DISSECT_RET_IPPROTO_AGAIN;\n+}\n+\n static struct guehdr *gue_gro_remcsum(struct sk_buff *skb, unsigned int off,\n \t\t\t\t struct guehdr *guehdr, void *data,\n \t\t\t\t size_t hdrlen, struct gro_remcsum *grc,\n@@ -500,6 +514,53 @@ static int gue_gro_complete(struct sock *sk, struct sk_buff *skb, int nhoff)\n \treturn err;\n }\n \n+static enum flow_dissect_ret gue_flow_dissect(struct sock *sk,\n+\t\t\tconst struct sk_buff *skb,\n+\t\t\tstruct flow_dissector_key_control *key_control,\n+\t\t\tstruct flow_dissector *flow_dissector,\n+\t\t\tvoid *target_container, void *data,\n+\t\t\t__be16 *p_proto, u8 *p_ip_proto, int *p_nhoff,\n+\t\t\tint *p_hlen, unsigned int flags)\n+{\n+\tstruct guehdr *guehdr, _guehdr;\n+\n+\tguehdr = __skb_header_pointer(skb, *p_nhoff + sizeof(struct udphdr),\n+\t\t\t\t sizeof(_guehdr), data, *p_hlen, &_guehdr);\n+\tif (!guehdr)\n+\t\treturn FLOW_DISSECT_RET_OUT_BAD;\n+\n+\tswitch (guehdr->version) {\n+\tcase 0:\n+\t\tif (unlikely(guehdr->control))\n+\t\t\treturn FLOW_DISSECT_RET_CONTINUE;\n+\n+\t\t*p_ip_proto = guehdr->proto_ctype;\n+\t\t*p_nhoff += sizeof(struct udphdr) +\n+\t\t sizeof(*guehdr) + (guehdr->hlen << 2);\n+\n+\t\tbreak;\n+\tcase 1:\n+\t\tswitch (((struct iphdr *)guehdr)->version) {\n+\t\tcase 4:\n+\t\t\t*p_ip_proto = IPPROTO_IPIP;\n+\t\t\tbreak;\n+\t\tcase 6:\n+\t\t\t*p_ip_proto = IPPROTO_IPV6;\n+\t\t\tbreak;\n+\t\tdefault:\n+\t\t\treturn FLOW_DISSECT_RET_CONTINUE;\n+\t\t}\n+\n+\t\t*p_nhoff += sizeof(struct udphdr);\n+\n+\t\tbreak;\n+\tdefault:\n+\t\treturn FLOW_DISSECT_RET_CONTINUE;\n+\t}\n+\n+\treturn FLOW_DISSECT_RET_IPPROTO_AGAIN;\n+}\n+\n static int fou_add_to_port_list(struct net *net, struct fou *fou)\n {\n \tstruct fou_net *fn = net_generic(net, fou_net_id);\n@@ -570,12 +631,14 @@ static int fou_create(struct net *net, struct fou_cfg *cfg,\n \t\ttunnel_cfg.encap_rcv = fou_udp_recv;\n \t\ttunnel_cfg.gro_receive = fou_gro_receive;\n \t\ttunnel_cfg.gro_complete = fou_gro_complete;\n+\t\ttunnel_cfg.flow_dissect = fou_flow_dissect;\n \t\tfou->protocol = cfg->protocol;\n \t\tbreak;\n \tcase FOU_ENCAP_GUE:\n \t\ttunnel_cfg.encap_rcv = gue_udp_recv;\n \t\ttunnel_cfg.gro_receive = gue_gro_receive;\n \t\ttunnel_cfg.gro_complete = gue_gro_complete;\n+\t\ttunnel_cfg.flow_dissect = gue_flow_dissect;\n \t\tbreak;\n \tdefault:\n \t\terr = -EINVAL;\n","prefixes":["v2","net-next","5/6"]}