{"id":807272,"url":"http://patchwork.ozlabs.org/api/1.0/patches/807272/?format=json","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.0/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20170829201601.64312-7-sjg@chromium.org>","date":"2017-08-29T20:15:51","name":"[U-Boot,v2,06/16] dtoc: Handle 'reg' properties with unusual sizes","commit_ref":"5ec741fd84ec2c080a6c400feaaa7f335f5cb62f","pull_url":null,"state":"accepted","archived":false,"hash":"2b8ba2c796056eedcad22aa25925b03032e4c09b","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/1.0/people/6170/?format=json","name":"Simon Glass","email":"sjg@chromium.org"},"delegate":{"id":3184,"url":"http://patchwork.ozlabs.org/api/1.0/users/3184/?format=json","username":"sjg","first_name":"Simon","last_name":"Glass","email":"sjg@chromium.org"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20170829201601.64312-7-sjg@chromium.org/mbox/","series":[{"id":462,"url":"http://patchwork.ozlabs.org/api/1.0/series/462/?format=json","date":"2017-08-29T20:15:45","name":"dtoc: Add support for 64-bit addresses","version":2,"mbox":"http://patchwork.ozlabs.org/series/462/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/807272/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"eff51R3N\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhg4D73k5z9sR9\n\tfor ;\n\tWed, 30 Aug 2017 06:20:28 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 9E7E7C22600; Tue, 29 Aug 2017 20:18:25 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 7FD80C225BF;\n\tTue, 29 Aug 2017 20:16:35 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid CD8E1C21E1E; Tue, 29 Aug 2017 20:16:19 +0000 (UTC)","from mail-oi0-f52.google.com (mail-oi0-f52.google.com\n\t[209.85.218.52])\n\tby lists.denx.de (Postfix) with ESMTPS id 2FDB3C225DE\n\tfor ; Tue, 29 Aug 2017 20:16:16 +0000 (UTC)","by mail-oi0-f52.google.com with SMTP id k77so36400447oib.2\n\tfor ; Tue, 29 Aug 2017 13:16:16 -0700 (PDT)","from kiwi.bld.corp.google.com ([100.101.164.89])\n\tby smtp.gmail.com with ESMTPSA id\n\ta190sm3829121oib.38.2017.08.29.13.16.13\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 29 Aug 2017 13:16:13 -0700 (PDT)","by kiwi.bld.corp.google.com (Postfix, from userid 121222)\n\tid F3D4813FAB7; Tue, 29 Aug 2017 14:16:12 -0600 (MDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=sender:from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=K99ItINdMceuF4qW6y9gaE+eVHt+beRCPpQGhqL+6fQ=;\n\tb=eff51R3Nhe66d4HgS9i/vBhIs7vtcAXh6Ne/KVuuAwy3fkCZj4re/tvwynKJN5MrDE\n\tMxrzWbngPh0DxlLFbsq/gHZdoSbcwgA04QD94SR8XdaVJjMav+HNROqaUiKYFObKK17s\n\tneST8eE1l9TRw1mmEsVegdGd4iNIR6RPlSfj6xpIfEihHWFdFMd2snaU0XQ1wqloNCML\n\tInoJuEBQ6z4Y81IMz9ycGVHSQjxG2JbCp0D+6K+As/cV5Y+MhpIvQeM3/oxoYh/SMKuk\n\t60NoxPgQXTmMTgBOHG2b90AlnMVEGebBwPRqaTf+qDxy9bG55MbAS+7oWLda+fY751AB\n\tFFwg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id\n\t:in-reply-to:references;\n\tbh=K99ItINdMceuF4qW6y9gaE+eVHt+beRCPpQGhqL+6fQ=;\n\tb=DVbuGcydyAeMlASP7eoxRZTPtl/fDIEgAq7J4lPhXdnsA6KqIDK6Aj5wqFWIwdjEzS\n\trS39IgIVxzNnW7dfUfJUd2cZaoPVJfMfmtKorTLCI2f10hmE7aNiMPeSAcaGv+gMFUFW\n\tkzxQmeTSbuMrOUsiUU+iPo2Zx+aZywIMGNjDVZToZFRqm3mabNgs6gq9FvcgNOir38M3\n\tPx5DoYZ8HljAKiQAKjLhr74FBBYpYn84kkvpVKueadZSs0S7HjQzHlL3Jrl8lymX7QWG\n\t4R6HecB5V5gV6ibw/eCnWRZ53m3YzXGGnAHdAWrZYvk3KhvFdhKclYLL6grPyLhj0NGh\n\toWTw==","X-Gm-Message-State":"AHYfb5jQS3aiundIfv7wOI+ZpmixY8JT4FJJBpnq6wgtVAOkzSDkXKav\n\tCGGD2dXNbHOjltIg","X-Google-Smtp-Source":"ADKCNb7zbHN+/OVp6578nxOCT1lsOvtUBgb/MYT7P0RCwJ1PgkgHS8IWY8Z7IEdsPju46cI/FiKjJg==","X-Received":"by 10.202.79.205 with SMTP id d196mr1393778oib.18.1504037774654; \n\tTue, 29 Aug 2017 13:16:14 -0700 (PDT)","From":"Simon Glass ","To":"U-Boot Mailing List ","Date":"Tue, 29 Aug 2017 14:15:51 -0600","Message-Id":"<20170829201601.64312-7-sjg@chromium.org>","X-Mailer":"git-send-email 2.14.1.342.g6490525c54-goog","In-Reply-To":"<20170829201601.64312-1-sjg@chromium.org>","References":"<20170829201601.64312-1-sjg@chromium.org>","Cc":"Tom Rini ","Subject":"[U-Boot] [PATCH v2 06/16] dtoc: Handle 'reg' properties with\n\tunusual sizes","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "},"content":"At present dtoc assumes that all 'reg' properties have both an address and\na size. For I2C devices we do not have this. Adjust dtoc to cope.\n\nReported-by: Philipp Tomsich \nSigned-off-by: Simon Glass \n---\n\nChanges in v2: None\n\n tools/dtoc/dtoc_test_simple.dts | 14 ++++++++++++++\n tools/dtoc/test_dtoc.py | 24 ++++++++++++++++++++++++\n 2 files changed, 38 insertions(+)","diff":"diff --git a/tools/dtoc/dtoc_test_simple.dts b/tools/dtoc/dtoc_test_simple.dts\nindex c736686263..6afe674b1f 100644\n--- a/tools/dtoc/dtoc_test_simple.dts\n+++ b/tools/dtoc/dtoc_test_simple.dts\n@@ -9,6 +9,8 @@\n /dts-v1/;\n \n / {\n+\t#address-cells = <1>;\n+\t#size-cells = <1>;\n \tspl-test {\n \t\tu-boot,dm-pre-reloc;\n \t\tcompatible = \"sandbox,spl-test\";\n@@ -45,4 +47,16 @@\n \t\tcompatible = \"sandbox,spl-test.2\";\n \t};\n \n+\ti2c@0 {\n+\t\tcompatible = \"sandbox,i2c-test\";\n+\t\tu-boot,dm-pre-reloc;\n+\t\t#address-cells = <1>;\n+\t\t#size-cells = <0>;\n+\t\tpmic@9 {\n+\t\t\tcompatible = \"sandbox,pmic-test\";\n+\t\t\tu-boot,dm-pre-reloc;\n+\t\t\treg = <9>;\n+\t\t\tlow-power;\n+\t\t};\n+\t};\n };\ndiff --git a/tools/dtoc/test_dtoc.py b/tools/dtoc/test_dtoc.py\nindex 09cfddaaaa..62460acb7c 100644\n--- a/tools/dtoc/test_dtoc.py\n+++ b/tools/dtoc/test_dtoc.py\n@@ -121,6 +121,12 @@ class TestDtoc(unittest.TestCase):\n data = infile.read()\n self.assertEqual('''#include \n #include \n+struct dtd_sandbox_i2c_test {\n+};\n+struct dtd_sandbox_pmic_test {\n+\\tbool\\t\\tlow_power;\n+\\tfdt64_t\\t\\treg[2];\n+};\n struct dtd_sandbox_spl_test {\n \\tbool\\t\\tboolval;\n \\tunsigned char\\tbytearray[3];\n@@ -192,6 +198,24 @@ U_BOOT_DEVICE(spl_test4) = {\n \\t.platdata_size\\t= sizeof(dtv_spl_test4),\n };\n \n+static struct dtd_sandbox_i2c_test dtv_i2c_at_0 = {\n+};\n+U_BOOT_DEVICE(i2c_at_0) = {\n+\\t.name\\t\\t= \"sandbox_i2c_test\",\n+\\t.platdata\\t= &dtv_i2c_at_0,\n+\\t.platdata_size\\t= sizeof(dtv_i2c_at_0),\n+};\n+\n+static struct dtd_sandbox_pmic_test dtv_pmic_at_9 = {\n+\\t.low_power\\t\\t= true,\n+\\t.reg\\t\\t\\t= {0x9, 0x0},\n+};\n+U_BOOT_DEVICE(pmic_at_9) = {\n+\\t.name\\t\\t= \"sandbox_pmic_test\",\n+\\t.platdata\\t= &dtv_pmic_at_9,\n+\\t.platdata_size\\t= sizeof(dtv_pmic_at_9),\n+};\n+\n ''', data)\n \n def test_phandle(self):\n","prefixes":["U-Boot","v2","06/16"]}