{"id":807270,"url":"http://patchwork.ozlabs.org/api/1.0/patches/807270/?format=json","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.0/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20170829201601.64312-5-sjg@chromium.org>","date":"2017-08-29T20:15:49","name":"[U-Boot,v2,04/16] dtoc: Avoid very long lines in output","commit_ref":"21d54ac353d76d46848cb7fae14a07775cc3bacf","pull_url":null,"state":"accepted","archived":false,"hash":"85088f1e9149221694d995891c600ad95bf17afe","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/1.0/people/6170/?format=json","name":"Simon Glass","email":"sjg@chromium.org"},"delegate":{"id":3184,"url":"http://patchwork.ozlabs.org/api/1.0/users/3184/?format=json","username":"sjg","first_name":"Simon","last_name":"Glass","email":"sjg@chromium.org"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20170829201601.64312-5-sjg@chromium.org/mbox/","series":[{"id":462,"url":"http://patchwork.ozlabs.org/api/1.0/series/462/?format=json","date":"2017-08-29T20:15:45","name":"dtoc: Add support for 64-bit addresses","version":2,"mbox":"http://patchwork.ozlabs.org/series/462/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/807270/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"nUMQCFhb\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhg2c4bz2z9sR9\n\tfor ;\n\tWed, 30 Aug 2017 06:19:04 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 4F77FC226AE; Tue, 29 Aug 2017 20:17:55 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 134C3C225F0;\n\tTue, 29 Aug 2017 20:16:31 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 1922DC22602; Tue, 29 Aug 2017 20:16:18 +0000 (UTC)","from mail-oi0-f41.google.com (mail-oi0-f41.google.com\n\t[209.85.218.41])\n\tby lists.denx.de (Postfix) with ESMTPS id 43963C22455\n\tfor ; Tue, 29 Aug 2017 20:16:15 +0000 (UTC)","by mail-oi0-f41.google.com with SMTP id k77so36400153oib.2\n\tfor ; Tue, 29 Aug 2017 13:16:15 -0700 (PDT)","from kiwi.bld.corp.google.com ([100.101.164.89])\n\tby smtp.gmail.com with ESMTPSA id\n\to7sm3248850oia.44.2017.08.29.13.16.11\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 29 Aug 2017 13:16:12 -0700 (PDT)","by kiwi.bld.corp.google.com (Postfix, from userid 121222)\n\tid C9B6E13FCAB; Tue, 29 Aug 2017 14:16:10 -0600 (MDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=sender:from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=VLkYkWx3bjbErVKmAZikiJnqX3U9hVOFxdBRwJnUeTg=;\n\tb=nUMQCFhb/lmcb4iF0/OvWElSBVtYgbRx20T5zruS0kSaJLyCksTkfUtyWudN/2/MXz\n\tCqQQ6bHWyfxXuUa9f0C/G26Hou71NnYNaI+kbV4YlZr1/u4GBru+bFzGgf4cOOx+nOw1\n\tribZ30LwQJqKVfFq1yhtc7OdWeLHHzC+NOw44hFbIG5m2VC4GzDepb7H6iQ5SmfrYcnx\n\t0WVpakD5BD/ZQDfjKQxRf7/sUOsRcU0BsPSE7lU5/duZ90eZg+25Y45oRqoLeESPP+/0\n\tkbFlQ11+AxoulCLOIlzN094lN11JvmQRdZFf9eje2UJgoInluhL7eZppviO6K6cdSsEI\n\tnNyQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id\n\t:in-reply-to:references;\n\tbh=VLkYkWx3bjbErVKmAZikiJnqX3U9hVOFxdBRwJnUeTg=;\n\tb=Z+v6ZxOFXuRkRK/m3UIayOc6XmkcJaviOcMRPkkTWp7olr0q+7c5ZzjctL13jyfh7z\n\tOHxROg0nlFXXLQsvRboO1yq+lKRw3kjsCYSQq8d5Kvr7AggbL9SY8yEmAWagGLzAwzIs\n\ttuiqJPBzys+3jpmrjh49wXNBJ1Zh4A/sxeWM54Y141g+/sOamzHoViZE3OzETdef8Oue\n\t1C3BXpDdh34HKGeu3EoZ8OVVpEk4vwQlcUjIjnYiMjOz+B7UIzCfhN+M7M76Lb4/O8bi\n\tUqO/BP63hkXw8i06ZgZIwfpHYFp7IO+67QCA4gzaquZfO84HaqN0m4D4yPlpvxkb55+Q\n\t8Lkw==","X-Gm-Message-State":"AHYfb5jXO5JBlUBOIFBwE8p40pYHfGAGrat9ZLNHmW+0iT++byqVunds\n\thWo+xI0dkn90gtu4oUSnVw==","X-Google-Smtp-Source":"ADKCNb4xeqXckYzmtG6fAdYD5celWIa64JQtvU9jCdV9PmaM5HXxNi6TiE9cFXnYMUC4B5wtA0Zo+g==","X-Received":"by 10.202.199.198 with SMTP id\n\tx189mr1494720oif.279.1504037773656; \n\tTue, 29 Aug 2017 13:16:13 -0700 (PDT)","From":"Simon Glass ","To":"U-Boot Mailing List ","Date":"Tue, 29 Aug 2017 14:15:49 -0600","Message-Id":"<20170829201601.64312-5-sjg@chromium.org>","X-Mailer":"git-send-email 2.14.1.342.g6490525c54-goog","In-Reply-To":"<20170829201601.64312-1-sjg@chromium.org>","References":"<20170829201601.64312-1-sjg@chromium.org>","Cc":"Tom Rini ","Subject":"[U-Boot] [PATCH v2 04/16] dtoc: Avoid very long lines in output","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "},"content":"Large arrays can result in lines with hundreds or thousands of characters\nwhich is not very editor-friendly. To avoid this, addjust the tool to\ngroup values 8 per line.\n\nSigned-off-by: Simon Glass \n---\n\nChanges in v2: None\n\n tools/dtoc/dtb_platdata.py | 7 ++++++-\n tools/dtoc/test_dtoc.py | 6 ++++--\n 2 files changed, 10 insertions(+), 3 deletions(-)","diff":"diff --git a/tools/dtoc/dtb_platdata.py b/tools/dtoc/dtb_platdata.py\nindex 4a1162a9fa..3243bccfe8 100644\n--- a/tools/dtoc/dtb_platdata.py\n+++ b/tools/dtoc/dtb_platdata.py\n@@ -385,7 +385,12 @@ class DtbPlatdata(object):\n else:\n for val in prop.value:\n vals.append(get_value(prop.type, val))\n- self.buf(', '.join(vals))\n+\n+ # Put 8 values per line to avoid very long lines.\n+ for i in xrange(0, len(vals), 8):\n+ if i:\n+ self.buf(',\\n\\t\\t')\n+ self.buf(', '.join(vals[i:i + 8]))\n self.buf('}')\n else:\n self.buf(get_value(prop.type, prop.value))\ndiff --git a/tools/dtoc/test_dtoc.py b/tools/dtoc/test_dtoc.py\nindex 8b95c4124f..5040f23325 100644\n--- a/tools/dtoc/test_dtoc.py\n+++ b/tools/dtoc/test_dtoc.py\n@@ -146,7 +146,8 @@ static struct dtd_sandbox_spl_test dtv_spl_test = {\n \\t.bytearray\\t\\t= {0x6, 0x0, 0x0},\n \\t.byteval\\t\\t= 0x5,\n \\t.intval\\t\\t\\t= 0x1,\n-\\t.longbytearray\\t\\t= {0x9, 0xa, 0xb, 0xc, 0xd, 0xe, 0xf, 0x10, 0x11},\n+\\t.longbytearray\\t\\t= {0x9, 0xa, 0xb, 0xc, 0xd, 0xe, 0xf, 0x10,\n+\\t\\t0x11},\n \\t.stringval\\t\\t= \"message\",\n \\t.boolval\\t\\t= true,\n \\t.intarray\\t\\t= {0x2, 0x3, 0x4, 0x0},\n@@ -162,7 +163,8 @@ static struct dtd_sandbox_spl_test dtv_spl_test2 = {\n \\t.bytearray\\t\\t= {0x1, 0x23, 0x34},\n \\t.byteval\\t\\t= 0x8,\n \\t.intval\\t\\t\\t= 0x3,\n-\\t.longbytearray\\t\\t= {0x9, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0},\n+\\t.longbytearray\\t\\t= {0x9, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0,\n+\\t\\t0x0},\n \\t.stringval\\t\\t= \"message2\",\n \\t.intarray\\t\\t= {0x5, 0x0, 0x0, 0x0},\n \\t.stringarray\\t\\t= {\"another\", \"multi-word\", \"message\"},\n","prefixes":["U-Boot","v2","04/16"]}