{"id":807141,"url":"http://patchwork.ozlabs.org/api/1.0/patches/807141/?format=json","project":{"id":35,"url":"http://patchwork.ozlabs.org/api/1.0/projects/35/?format=json","name":"Linux I2C development","link_name":"linux-i2c","list_id":"linux-i2c.vger.kernel.org","list_email":"linux-i2c@vger.kernel.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<1504018610-10822-6-git-send-email-ulf.hansson@linaro.org>","date":"2017-08-29T14:56:47","name":"[v3,5/8] PM / ACPI: Split acpi_lpss_suspend_late|resume_early()","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"410801fe0bdac2bcb7b7b495c12168b730d628ca","submitter":{"id":21036,"url":"http://patchwork.ozlabs.org/api/1.0/people/21036/?format=json","name":"Ulf Hansson","email":"ulf.hansson@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-i2c/patch/1504018610-10822-6-git-send-email-ulf.hansson@linaro.org/mbox/","series":[{"id":387,"url":"http://patchwork.ozlabs.org/api/1.0/series/387/?format=json","date":"2017-08-29T14:56:42","name":"PM / ACPI / i2c: Deploy runtime PM centric path for system sleep","version":3,"mbox":"http://patchwork.ozlabs.org/series/387/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/807141/checks/","tags":{},"headers":{"Return-Path":"<linux-i2c-owner@vger.kernel.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-i2c-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"gUg8qNZd\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhWvV447Sz9sR9\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 30 Aug 2017 00:57:26 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1754678AbdH2O5M (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tTue, 29 Aug 2017 10:57:12 -0400","from mail-lf0-f42.google.com ([209.85.215.42]:35501 \"EHLO\n\tmail-lf0-f42.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1754611AbdH2O5K (ORCPT\n\t<rfc822; linux-i2c@vger.kernel.org>); Tue, 29 Aug 2017 10:57:10 -0400","by mail-lf0-f42.google.com with SMTP id k186so14377668lfe.2\n\tfor <linux-i2c@vger.kernel.org>; Tue, 29 Aug 2017 07:57:09 -0700 (PDT)","from localhost.localdomain (h-158-174-22-67.NA.cust.bahnhof.se.\n\t[158.174.22.67]) by smtp.gmail.com with ESMTPSA id\n\ty23sm652454ljd.19.2017.08.29.07.57.07\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tTue, 29 Aug 2017 07:57:08 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=f36S30elag1XUSQJ2xs8/bYVZoa7ATy6lX0aBxlSVbM=;\n\tb=gUg8qNZdgTFXYBikNQpTwlNrIoJ1Rqbkn8/MrtmNa4CdqTegSsIx0mLvBr3RLROVvD\n\tKc/plvnQ2oDlQuxWCyDykDw35gFxLyjzHikJvFDopc65ihv9EvDxYrJDAynZlAiw7KAG\n\t6He1UHzicDQavqHgg7qPfGNiGZjF//vGPM7Kc=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=f36S30elag1XUSQJ2xs8/bYVZoa7ATy6lX0aBxlSVbM=;\n\tb=eeNBSwg80rxI92Q0h3hI1ADVMLC4XhVKOCR4JBvKX+UKm+fIJ7YG5UO2VM6LZQpAt5\n\tsaUrNPgezS5oRoecwJBDyvfspINB5g6yZzP+eAxZlv5/WGTRybstffyiWbPptVmROR1S\n\tlGM2slId7D2kLgrXzu7lusGR18mGNTUxtTkRWIOdnapvrRjJkfI2PJ8IKRFfSkISNlAI\n\t/E2CMc07xIDisX4Ad4Ugv/3t45S/RdqKjMhkdyTCzJmruVFaI7p6LiIY8X/dzMxMRx9K\n\tpK6qg0+1bdx8RcVfFcVgliIjD+UCYtOY1j+mvTVE1aRXYXIhhtItXbNWvsokwhX2cl+7\n\tRsjA==","X-Gm-Message-State":"AHYfb5gJQE/LocDnIM36+hPFjvJYZSWVlrlDRYvTX7C6W1LkdBuHXquL\n\tn7ehbbgnIiHC6LTN","X-Received":"by 10.25.31.136 with SMTP id f130mr156330lff.135.1504018628870; \n\tTue, 29 Aug 2017 07:57:08 -0700 (PDT)","From":"Ulf Hansson <ulf.hansson@linaro.org>","To":"Wolfram Sang <wsa@the-dreams.de>,\n\t\"Rafael J . Wysocki\" <rjw@rjwysocki.net>,\n\tLen Brown <lenb@kernel.org>, linux-acpi@vger.kernel.org,\n\tlinux-pm@vger.kernel.org","Cc":"Kevin Hilman <khilman@kernel.org>,\n\tJarkko Nikula <jarkko.nikula@linux.intel.com>,\n\tAndy Shevchenko <andriy.shevchenko@linux.intel.com>,\n\tMika Westerberg <mika.westerberg@linux.intel.com>,\n\tJisheng Zhang <jszhang@marvell.com>,\n\tJohn Stultz <john.stultz@linaro.org>, Guodong Xu <guodong.xu@linaro.org>,\n\tSumit Semwal <sumit.semwal@linaro.org>,\n\tHaojian Zhuang <haojian.zhuang@linaro.org>,\n\tJohannes Stezenbach <js@sig21.net>,\n\tlinux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org,\n\tUlf Hansson <ulf.hansson@linaro.org>","Subject":"[PATCH v3 5/8] PM / ACPI: Split\n\tacpi_lpss_suspend_late|resume_early()","Date":"Tue, 29 Aug 2017 16:56:47 +0200","Message-Id":"<1504018610-10822-6-git-send-email-ulf.hansson@linaro.org>","X-Mailer":"git-send-email 2.7.4","In-Reply-To":"<1504018610-10822-1-git-send-email-ulf.hansson@linaro.org>","References":"<1504018610-10822-1-git-send-email-ulf.hansson@linaro.org>","Sender":"linux-i2c-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<linux-i2c.vger.kernel.org>","X-Mailing-List":"linux-i2c@vger.kernel.org"},"content":"Move the code which is special to ACPI LPSS into separate functions. This\nmay clarify the code a bit, but the main purpose of this change, is instead\nto prepare for additional changes on top. Ideally the following changes\nshould then become easier to review.\n\nSigned-off-by: Ulf Hansson <ulf.hansson@linaro.org>\n---\n\nChanges in v3:\n\t- None.\n\n---\n drivers/acpi/acpi_lpss.c | 29 +++++++++++++++++++++++------\n 1 file changed, 23 insertions(+), 6 deletions(-)","diff":"diff --git a/drivers/acpi/acpi_lpss.c b/drivers/acpi/acpi_lpss.c\nindex 0c84d15..e726173 100644\n--- a/drivers/acpi/acpi_lpss.c\n+++ b/drivers/acpi/acpi_lpss.c\n@@ -717,22 +717,28 @@ static void acpi_lpss_dismiss(struct device *dev)\n }\n \n #ifdef CONFIG_PM_SLEEP\n-static int acpi_lpss_suspend_late(struct device *dev)\n+static int lpss_suspend_late(struct device *dev)\n {\n \tstruct lpss_private_data *pdata = acpi_driver_data(ACPI_COMPANION(dev));\n+\n+\tif (pdata->dev_desc->flags & LPSS_SAVE_CTX)\n+\t\tacpi_lpss_save_ctx(dev, pdata);\n+\n+\treturn acpi_dev_suspend_late(dev);\n+}\n+\n+static int acpi_lpss_suspend_late(struct device *dev)\n+{\n \tint ret;\n \n \tret = pm_generic_suspend_late(dev);\n \tif (ret)\n \t\treturn ret;\n \n-\tif (pdata->dev_desc->flags & LPSS_SAVE_CTX)\n-\t\tacpi_lpss_save_ctx(dev, pdata);\n-\n-\treturn acpi_dev_suspend_late(dev);\n+\treturn lpss_suspend_late(dev);\n }\n \n-static int acpi_lpss_resume_early(struct device *dev)\n+static int lpss_resume_early(struct device *dev)\n {\n \tstruct lpss_private_data *pdata = acpi_driver_data(ACPI_COMPANION(dev));\n \tint ret;\n@@ -746,6 +752,17 @@ static int acpi_lpss_resume_early(struct device *dev)\n \tif (pdata->dev_desc->flags & LPSS_SAVE_CTX)\n \t\tacpi_lpss_restore_ctx(dev, pdata);\n \n+\treturn 0;\n+}\n+\n+static int acpi_lpss_resume_early(struct device *dev)\n+{\n+\tint ret;\n+\n+\tret = lpss_resume_early(dev);\n+\tif (ret)\n+\t\treturn ret;\n+\n \treturn pm_generic_resume_early(dev);\n }\n #endif /* CONFIG_PM_SLEEP */\n","prefixes":["v3","5/8"]}