{"id":807077,"url":"http://patchwork.ozlabs.org/api/1.0/patches/807077/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20170829122745.14309-3-stefanha@redhat.com>","date":"2017-08-29T12:27:44","name":"[v2,2/3] qemu-iotests: improve nbd-fault-injector.py startup protocol","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"301a35118ff3e9cbf1c93ac38cc47592d14394bb","submitter":{"id":17227,"url":"http://patchwork.ozlabs.org/api/1.0/people/17227/?format=json","name":"Stefan Hajnoczi","email":"stefanha@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170829122745.14309-3-stefanha@redhat.com/mbox/","series":[{"id":359,"url":"http://patchwork.ozlabs.org/api/1.0/series/359/?format=json","date":"2017-08-29T12:27:42","name":"nbd-client: enter read_reply_co during init to avoid crash","version":2,"mbox":"http://patchwork.ozlabs.org/series/359/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/807077/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=stefanha@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xhSc90G3rz9t2x\n\tfor ;\n\tTue, 29 Aug 2017 22:28:56 +1000 (AEST)","from localhost ([::1]:44703 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dmfdW-0005hR-9f\n\tfor incoming@patchwork.ozlabs.org; Tue, 29 Aug 2017 08:28:54 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:43106)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dmfcn-0005f5-Cm\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 08:28:10 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dmfcm-0002mh-GZ\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 08:28:09 -0400","from mx1.redhat.com ([209.132.183.28]:37020)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dmfcf-0002kW-BJ; Tue, 29 Aug 2017 08:28:01 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 61710C058EB7;\n\tTue, 29 Aug 2017 12:28:00 +0000 (UTC)","from localhost (ovpn-117-175.ams2.redhat.com [10.36.117.175])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id AB8A87FB50;\n\tTue, 29 Aug 2017 12:27:57 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 61710C058EB7","From":"Stefan Hajnoczi ","To":"","Date":"Tue, 29 Aug 2017 13:27:44 +0100","Message-Id":"<20170829122745.14309-3-stefanha@redhat.com>","In-Reply-To":"<20170829122745.14309-1-stefanha@redhat.com>","References":"<20170829122745.14309-1-stefanha@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.32]);\n\tTue, 29 Aug 2017 12:28:00 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH v2 2/3] qemu-iotests: improve\n\tnbd-fault-injector.py startup protocol","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Kevin Wolf ,\n\tVladimir Sementsov-Ogievskiy ,\n\tqemu-block@nongnu.org, Stefan Hajnoczi ,\n\tPaolo Bonzini ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"Currently 083 waits for the nbd-fault-injector.py server to start up by\nlooping until netstat shows the TCP listen socket.\n\nThe startup protocol can be simplified by passing a 0 port number to\nnbd-fault-injector.py. The kernel will allocate a port in bind(2) and\nthe final port number can be printed by nbd-fault-injector.py.\n\nThis should make it slightly nicer and less TCP-specific to wait for\nserver startup. This patch changes nbd-fault-injector.py, the next one\nwill rewrite server startup in 083.\n\nReviewed-by: Eric Blake \nSigned-off-by: Stefan Hajnoczi \n---\n tests/qemu-iotests/nbd-fault-injector.py | 4 ++++\n 1 file changed, 4 insertions(+)","diff":"diff --git a/tests/qemu-iotests/nbd-fault-injector.py b/tests/qemu-iotests/nbd-fault-injector.py\nindex 6c07191a5a..1c10dcb51c 100755\n--- a/tests/qemu-iotests/nbd-fault-injector.py\n+++ b/tests/qemu-iotests/nbd-fault-injector.py\n@@ -235,11 +235,15 @@ def open_socket(path):\n sock = socket.socket()\n sock.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR, 1)\n sock.bind((host, int(port)))\n+\n+ # If given port was 0 the final port number is now available\n+ path = '%s:%d' % sock.getsockname()\n else:\n sock = socket.socket(socket.AF_UNIX)\n sock.bind(path)\n sock.listen(0)\n print 'Listening on %s' % path\n+ sys.stdout.flush() # another process may be waiting, show message now\n return sock\n \n def usage(args):\n","prefixes":["v2","2/3"]}