{"id":806974,"url":"http://patchwork.ozlabs.org/api/1.0/patches/806974/?format=json","project":{"id":44,"url":"http://patchwork.ozlabs.org/api/1.0/projects/44/?format=json","name":"skiboot firmware development","link_name":"skiboot","list_id":"skiboot.lists.ozlabs.org","list_email":"skiboot@lists.ozlabs.org","web_url":"http://github.com/open-power/skiboot","scm_url":"http://github.com/open-power/skiboot","webscm_url":""},"msgid":"<20170829062506.8317-8-cyril.bur@au1.ibm.com>","date":"2017-08-29T06:25:00","name":"[RFC,07/13] libflash/libffs: Always add entries to the end of the TOC","commit_ref":null,"pull_url":null,"state":"rfc","archived":false,"hash":"7417bb78a826b00c3e4c4f4d64fd23d4f62cb392","submitter":{"id":64738,"url":"http://patchwork.ozlabs.org/api/1.0/people/64738/?format=json","name":"Cyril Bur","email":"cyril.bur@au1.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/skiboot/patch/20170829062506.8317-8-cyril.bur@au1.ibm.com/mbox/","series":[{"id":313,"url":"http://patchwork.ozlabs.org/api/1.0/series/313/?format=json","date":"2017-08-29T06:24:53","name":"Rework flash TOC generation","version":1,"mbox":"http://patchwork.ozlabs.org/series/313/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/806974/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","skiboot@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","skiboot@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xhJxR0BHjz9ryr\n\tfor ;\n\tTue, 29 Aug 2017 16:43:23 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xhJxQ6T4QzDqp3\n\tfor ;\n\tTue, 29 Aug 2017 16:43:22 +1000 (AEST)","from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com\n\t[148.163.158.5])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xhJY83sZFzDqZq\n\tfor ; Tue, 29 Aug 2017 16:25:48 +1000 (AEST)","from pps.filterd (m0098416.ppops.net [127.0.0.1])\n\tby mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv7T6OCRn076863\n\tfor ; Tue, 29 Aug 2017 02:25:42 -0400","from e23smtp08.au.ibm.com (e23smtp08.au.ibm.com [202.81.31.141])\n\tby mx0b-001b2d01.pphosted.com with ESMTP id 2cn1hye6n7-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Tue, 29 Aug 2017 02:25:41 -0400","from localhost\n\tby e23smtp08.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tTue, 29 Aug 2017 16:25:38 +1000","from d23relay10.au.ibm.com (202.81.31.229)\n\tby e23smtp08.au.ibm.com (202.81.31.205) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tTue, 29 Aug 2017 16:25:37 +1000","from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.235.139])\n\tby d23relay10.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n\tv7T6PaJF23593034\n\tfor ; Tue, 29 Aug 2017 16:25:36 +1000","from d23av04.au.ibm.com (localhost [127.0.0.1])\n\tby d23av04.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id\n\tv7T6PaR8017768\n\tfor ; Tue, 29 Aug 2017 16:25:37 +1000","from ozlabs.au.ibm.com (ozlabs.au.ibm.com [9.192.253.14])\n\tby d23av04.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id\n\tv7T6PaU8017743; Tue, 29 Aug 2017 16:25:36 +1000","from camb691.ozlabs.ibm.com (haven.au.ibm.com [9.192.254.114])\n\t(using TLSv1.2 with cipher DHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby ozlabs.au.ibm.com (Postfix) with ESMTPSA id 5DC22A027E;\n\tTue, 29 Aug 2017 16:25:35 +1000 (AEST)"],"From":"Cyril Bur ","To":"skiboot@lists.ozlabs.org, stewart@linux.vnet.ibm.com","Date":"Tue, 29 Aug 2017 16:25:00 +1000","X-Mailer":"git-send-email 2.14.1","In-Reply-To":"<20170829062506.8317-1-cyril.bur@au1.ibm.com>","References":"<20170829062506.8317-1-cyril.bur@au1.ibm.com>","X-TM-AS-MML":"disable","x-cbid":"17082906-0048-0000-0000-0000025A39C9","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17082906-0049-0000-0000-0000480E7DF1","Message-Id":"<20170829062506.8317-8-cyril.bur@au1.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-08-29_01:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1708290096","Subject":"[Skiboot] [RFC PATCH 07/13] libflash/libffs: Always add entries to\n\tthe end of the TOC","X-BeenThere":"skiboot@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Mailing list for skiboot development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"Skiboot\"\n\t"},"content":"It turns out that sorted order isn't the best idea. This removes\nflexibility from the caller. If the user wants their partitions in\nsorted order, they should insert them in sorted order.\n\nSigned-off-by: Cyril Bur \n---\n libflash/libffs.c | 20 +-------------------\n 1 file changed, 1 insertion(+), 19 deletions(-)","diff":"diff --git a/libflash/libffs.c b/libflash/libffs.c\nindex 822169b7..0159c07b 100644\n--- a/libflash/libffs.c\n+++ b/libflash/libffs.c\n@@ -598,25 +598,7 @@ static int __ffs_entry_add(struct ffs_hdr *hdr, struct ffs_entry *entry)\n \t\treturn FFS_ERR_BAD_PART_BASE;\n \t}\n \n-\t/*\n-\t * A header can't have zero entries. Was asserted.\n-\t */\n-\tlist_for_each(&hdr->entries, ent, list)\n-\t\tif (entry->base < ent->base)\n-\t\t\tbreak;\n-\n-\tif (ent == list_top(&hdr->entries, struct ffs_entry, list)) {\n-\t\t/*\n-\t\t * This should never happen because the partition entry\n-\t\t * should ALWAYS be here\n-\t\t */\n-\t\tfprintf(stderr, \"Warning: replacing first entry in FFS header\\n\");\n-\t\tlist_add(&hdr->entries, &entry->list);\n-\t} else if (!ent) {\n-\t\tlist_add_tail(&hdr->entries, &entry->list);\n-\t} else {\n-\t\tlist_add_before(&hdr->entries, &entry->list, &ent->list);\n-\t}\n+\tlist_add_tail(&hdr->entries, &entry->list);\n \n \treturn 0;\n }\n","prefixes":["RFC","07/13"]}