{"id":806960,"url":"http://patchwork.ozlabs.org/api/1.0/patches/806960/?format=json","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/1.0/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/"},"msgid":"<1503987820-31933-7-git-send-email-sukadev@linux.vnet.ibm.com>","date":"2017-08-29T06:23:36","name":"[v8,06/10] powerpc/vas: Define helpers to alloc/free windows","commit_ref":"bbfe59f8a7057f80f67a74e77fb4e941240e90b9","pull_url":null,"state":"accepted","archived":false,"hash":"a1f0b5537be22d37ec01806b4a61be22062f9fe5","submitter":{"id":984,"url":"http://patchwork.ozlabs.org/api/1.0/people/984/?format=json","name":"Sukadev Bhattiprolu","email":"sukadev@linux.vnet.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/1503987820-31933-7-git-send-email-sukadev@linux.vnet.ibm.com/mbox/","series":[{"id":310,"url":"http://patchwork.ozlabs.org/api/1.0/series/310/?format=json","date":"2017-08-29T06:23:30","name":"Enable VAS","version":8,"mbox":"http://patchwork.ozlabs.org/series/310/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/806960/checks/","tags":{},"headers":{"Return-Path":"<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org","linuxppc-dev@ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xhJlS0Njjz9t2x\n\tfor <patchwork-incoming@ozlabs.org>;\n\tTue, 29 Aug 2017 16:34:44 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xhJlR6fwRzDr0K\n\tfor <patchwork-incoming@ozlabs.org>;\n\tTue, 29 Aug 2017 16:34:43 +1000 (AEST)","from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xhJWF0PsWzDqV5\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tTue, 29 Aug 2017 16:24:09 +1000 (AEST)","from ozlabs.org (bilbo.ozlabs.org [103.22.144.67])\n\tby bilbo.ozlabs.org (Postfix) with ESMTP id 3xhJWD5Kp6z8vmR\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tTue, 29 Aug 2017 16:24:08 +1000 (AEST)","by ozlabs.org (Postfix)\n\tid 3xhJWD3B6Lz9t3J; Tue, 29 Aug 2017 16:24:08 +1000 (AEST)","from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com\n\t[148.163.158.5])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xhJWC25xLz9t3t\n\tfor <linuxppc-dev@ozlabs.org>; Tue, 29 Aug 2017 16:24:07 +1000 (AEST)","from pps.filterd (m0098420.ppops.net [127.0.0.1])\n\tby mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv7T6NY8a014208\n\tfor <linuxppc-dev@ozlabs.org>; Tue, 29 Aug 2017 02:24:04 -0400","from e17.ny.us.ibm.com (e17.ny.us.ibm.com [129.33.205.207])\n\tby mx0b-001b2d01.pphosted.com with ESMTP id 2cmx9uj400-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor <linuxppc-dev@ozlabs.org>; Tue, 29 Aug 2017 02:24:04 -0400","from localhost\n\tby e17.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <linuxppc-dev@ozlabs.org> from <sukadev@linux.vnet.ibm.com>;\n\tTue, 29 Aug 2017 02:24:04 -0400","from b01cxnp22035.gho.pok.ibm.com (9.57.198.25)\n\tby e17.ny.us.ibm.com (146.89.104.204) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tTue, 29 Aug 2017 02:24:00 -0400","from b01ledav005.gho.pok.ibm.com (b01ledav005.gho.pok.ibm.com\n\t[9.57.199.110])\n\tby b01cxnp22035.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP\n\tid v7T6NwXU33095826; Tue, 29 Aug 2017 06:23:59 GMT","from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 600FAAE03B;\n\tTue, 29 Aug 2017 02:24:23 -0400 (EDT)","from suka-w540.usor.ibm.com (unknown [9.70.94.25])\n\tby b01ledav005.gho.pok.ibm.com (Postfix) with ESMTP id 86315AE034;\n\tTue, 29 Aug 2017 02:24:22 -0400 (EDT)"],"Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=linux.vnet.ibm.com\n\t(client-ip=148.163.158.5; helo=mx0a-001b2d01.pphosted.com;\n\tenvelope-from=sukadev@linux.vnet.ibm.com; receiver=<UNKNOWN>)","From":"Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>","To":"Michael Ellerman <mpe@ellerman.id.au>","Subject":"[PATCH v8 06/10] powerpc/vas: Define helpers to alloc/free windows","Date":"Mon, 28 Aug 2017 23:23:36 -0700","X-Mailer":"git-send-email 2.7.4","In-Reply-To":"<1503987820-31933-1-git-send-email-sukadev@linux.vnet.ibm.com>","References":"<1503987820-31933-1-git-send-email-sukadev@linux.vnet.ibm.com>","X-TM-AS-GCONF":"00","x-cbid":"17082906-0040-0000-0000-00000396FE4B","X-IBM-SpamModules-Scores":"","X-IBM-SpamModules-Versions":"BY=3.00007631; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000226; SDB=6.00909146; UDB=6.00455922;\n\tIPR=6.00689402; \n\tBA=6.00005559; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00016912;\n\tXFM=3.00000015; UTC=2017-08-29 06:24:02","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17082906-0041-0000-0000-0000078B2FD2","Message-Id":"<1503987820-31933-7-git-send-email-sukadev@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-08-29_01:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=2\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1708290094","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t<linuxppc-dev.lists.ozlabs.org>","List-Unsubscribe":"<https://lists.ozlabs.org/options/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>","List-Archive":"<http://lists.ozlabs.org/pipermail/linuxppc-dev/>","List-Post":"<mailto:linuxppc-dev@lists.ozlabs.org>","List-Help":"<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>","List-Subscribe":"<https://lists.ozlabs.org/listinfo/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>","Cc":"stewart@linux.vnet.ibm.com, mikey@neuling.org, linuxppc-dev@ozlabs.org, \n\tlinux-kernel@vger.kernel.org, apopple@au1.ibm.com, oohall@gmail.com","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>"},"content":"Define helpers to allocate/free VAS window objects. These will\nbe used in follow-on patches when opening/closing windows.\n\nChangelog[v8]:\n\t- [Michael Ellerman] Make some functions static; retry if\n\t  ida_get_new() fails with EAGAIN; fix a couple of leak in ids\n\nSigned-off-by: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>\n---\n arch/powerpc/platforms/powernv/vas-window.c | 73 +++++++++++++++++++++++++++++\n 1 file changed, 73 insertions(+)","diff":"diff --git a/arch/powerpc/platforms/powernv/vas-window.c b/arch/powerpc/platforms/powernv/vas-window.c\nindex 68dfe53..bfc9dba 100644\n--- a/arch/powerpc/platforms/powernv/vas-window.c\n+++ b/arch/powerpc/platforms/powernv/vas-window.c\n@@ -485,6 +485,79 @@ int init_winctx_regs(struct vas_window *window, struct vas_winctx *winctx)\n \treturn 0;\n }\n \n+static DEFINE_SPINLOCK(vas_ida_lock);\n+\n+static void vas_release_window_id(struct ida *ida, int winid)\n+{\n+\tspin_lock(&vas_ida_lock);\n+\tida_remove(ida, winid);\n+\tspin_unlock(&vas_ida_lock);\n+}\n+\n+static int vas_assign_window_id(struct ida *ida)\n+{\n+\tint rc, winid;\n+\n+\tdo {\n+\t\trc = ida_pre_get(ida, GFP_KERNEL);\n+\t\tif (!rc)\n+\t\t\treturn -EAGAIN;\n+\n+\t\tspin_lock(&vas_ida_lock);\n+\t\trc = ida_get_new(ida, &winid);\n+\t\tspin_unlock(&vas_ida_lock);\n+\t} while (rc == -EAGAIN);\n+\n+\tif (rc)\n+\t\treturn rc;\n+\n+\tif (winid > VAS_WINDOWS_PER_CHIP) {\n+\t\tpr_err(\"Too many (%d) open windows\\n\", winid);\n+\t\tvas_release_window_id(ida, winid);\n+\t\treturn -EAGAIN;\n+\t}\n+\n+\treturn winid;\n+}\n+\n+void vas_window_free(struct vas_window *window)\n+{\n+\tint winid = window->winid;\n+\tstruct vas_instance *vinst = window->vinst;\n+\n+\tunmap_winctx_mmio_bars(window);\n+\tkfree(window);\n+\n+\tvas_release_window_id(&vinst->ida, winid);\n+}\n+\n+struct vas_window *vas_window_alloc(struct vas_instance *vinst)\n+{\n+\tint winid;\n+\tstruct vas_window *window;\n+\n+\twinid = vas_assign_window_id(&vinst->ida);\n+\tif (winid < 0)\n+\t\treturn ERR_PTR(winid);\n+\n+\twindow = kzalloc(sizeof(*window), GFP_KERNEL);\n+\tif (!window)\n+\t\tgoto out_free;\n+\n+\twindow->vinst = vinst;\n+\twindow->winid = winid;\n+\n+\tif (map_winctx_mmio_bars(window))\n+\t\tgoto out_free;\n+\n+\treturn window;\n+\n+out_free:\n+\tkfree(window);\n+\tvas_release_window_id(&vinst->ida, winid);\n+\treturn ERR_PTR(-ENOMEM);\n+}\n+\n /* stub for now */\n int vas_win_close(struct vas_window *window)\n {\n","prefixes":["v8","06/10"]}