{"id":806920,"url":"http://patchwork.ozlabs.org/api/1.0/patches/806920/?format=json","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/1.0/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/"},"msgid":"<1503972142-289376-7-git-send-email-pasha.tatashin@oracle.com>","date":"2017-08-29T02:02:17","name":"[v7,06/11] mm: zero struct pages during initialization","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"bbba9dd70f2b4ea93ef2afb134b614f5c710b8fc","submitter":{"id":71010,"url":"http://patchwork.ozlabs.org/api/1.0/people/71010/?format=json","name":"Pavel Tatashin","email":"pasha.tatashin@oracle.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/1503972142-289376-7-git-send-email-pasha.tatashin@oracle.com/mbox/","series":[{"id":286,"url":"http://patchwork.ozlabs.org/api/1.0/series/286/?format=json","date":"2017-08-29T02:02:21","name":"complete deferred page initialization","version":7,"mbox":"http://patchwork.ozlabs.org/series/286/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/806920/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xhC8c5ydSz9s7f\n\tfor ;\n\tTue, 29 Aug 2017 12:22:40 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xhC8c5715zDqXk\n\tfor ;\n\tTue, 29 Aug 2017 12:22:40 +1000 (AEST)","from userp1040.oracle.com (userp1040.oracle.com [156.151.31.81])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xhBl51zhxzDqKl\n\tfor ;\n\tTue, 29 Aug 2017 12:04:01 +1000 (AEST)","from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71])\n\tby userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with\n\tESMTP id v7T22Zrs022420\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Tue, 29 Aug 2017 02:02:36 GMT","from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72])\n\tby userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id v7T22Zmn007054\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Tue, 29 Aug 2017 02:02:35 GMT","from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17])\n\tby userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id\n\tv7T22Yh5011205; Tue, 29 Aug 2017 02:02:34 GMT","from ca-ldom-ol-build-1.us.oracle.com (/10.129.68.23)\n\tby default (Oracle Beehive Gateway v4.0)\n\twith ESMTP ; Mon, 28 Aug 2017 19:02:34 -0700"],"From":"Pavel Tatashin ","To":"linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org,\n\tlinux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org,\n\tlinux-s390@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n\tx86@kernel.org, kasan-dev@googlegroups.com, borntraeger@de.ibm.com,\n\theiko.carstens@de.ibm.com, davem@davemloft.net, willy@infradead.org, \n\tmhocko@kernel.org, ard.biesheuvel@linaro.org, will.deacon@arm.com,\n\tcatalin.marinas@arm.com, sam@ravnborg.org, mgorman@techsingularity.net,\n\tSteven.Sistare@oracle.com, daniel.m.jordan@oracle.com,\n\tbob.picco@oracle.com","Subject":"[PATCH v7 06/11] mm: zero struct pages during initialization","Date":"Mon, 28 Aug 2017 22:02:17 -0400","Message-Id":"<1503972142-289376-7-git-send-email-pasha.tatashin@oracle.com>","X-Mailer":"git-send-email 1.7.1","In-Reply-To":"<1503972142-289376-1-git-send-email-pasha.tatashin@oracle.com>","References":"<1503972142-289376-1-git-send-email-pasha.tatashin@oracle.com>","X-Source-IP":"userv0021.oracle.com [156.151.31.71]","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"},"content":"Add struct page zeroing as a part of initialization of other fields in\n__init_single_page().\n\nThis single thread performance collected on: Intel(R) Xeon(R) CPU E7-8895\nv3 @ 2.60GHz with 1T of memory (268400646 pages in 8 nodes):\n\n BASE FIX\nsparse_init 11.244671836s 0.007199623s\nzone_sizes_init 4.879775891s 8.355182299s\n --------------------------\nTotal 16.124447727s 8.362381922s\n\nsparse_init is where memory for struct pages is zeroed, and the zeroing\npart is moved later in this patch into __init_single_page(), which is\ncalled from zone_sizes_init().\n\nSigned-off-by: Pavel Tatashin \nReviewed-by: Steven Sistare \nReviewed-by: Daniel Jordan \nReviewed-by: Bob Picco \nAcked-by: Michal Hocko \n---\n include/linux/mm.h | 9 +++++++++\n mm/page_alloc.c | 1 +\n 2 files changed, 10 insertions(+)","diff":"diff --git a/include/linux/mm.h b/include/linux/mm.h\nindex 46b9ac5e8569..183ac5e733db 100644\n--- a/include/linux/mm.h\n+++ b/include/linux/mm.h\n@@ -93,6 +93,15 @@ extern int mmap_rnd_compat_bits __read_mostly;\n #define mm_forbids_zeropage(X)\t(0)\n #endif\n \n+/*\n+ * On some architectures it is expensive to call memset() for small sizes.\n+ * Those architectures should provide their own implementation of \"struct page\"\n+ * zeroing by defining this macro in .\n+ */\n+#ifndef mm_zero_struct_page\n+#define mm_zero_struct_page(pp) ((void)memset((pp), 0, sizeof(struct page)))\n+#endif\n+\n /*\n * Default maximum number of active map areas, this limits the number of vmas\n * per mm struct. Users can overwrite this number by sysctl but there is a\ndiff --git a/mm/page_alloc.c b/mm/page_alloc.c\nindex 8293815ca85d..4d67fe3dd172 100644\n--- a/mm/page_alloc.c\n+++ b/mm/page_alloc.c\n@@ -1169,6 +1169,7 @@ static void free_one_page(struct zone *zone,\n static void __meminit __init_single_page(struct page *page, unsigned long pfn,\n \t\t\t\tunsigned long zone, int nid)\n {\n+\tmm_zero_struct_page(page);\n \tset_page_links(page, zone, nid, pfn);\n \tinit_page_count(page);\n \tpage_mapcount_reset(page);\n","prefixes":["v7","06/11"]}