{"id":806906,"url":"http://patchwork.ozlabs.org/api/1.0/patches/806906/?format=json","project":{"id":10,"url":"http://patchwork.ozlabs.org/api/1.0/projects/10/?format=json","name":"Linux SPARC Development ","link_name":"sparclinux","list_id":"sparclinux.vger.kernel.org","list_email":"sparclinux@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<1503972142-289376-11-git-send-email-pasha.tatashin@oracle.com>","date":"2017-08-29T02:02:21","name":"[v7,10/11] arm64/kasan: explicitly zero kasan shadow memory","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"4a7d07044b8da9c612c9f9679ff9897cfada769a","submitter":{"id":71010,"url":"http://patchwork.ozlabs.org/api/1.0/people/71010/?format=json","name":"Pavel Tatashin","email":"pasha.tatashin@oracle.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/1.0/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/sparclinux/patch/1503972142-289376-11-git-send-email-pasha.tatashin@oracle.com/mbox/","series":[{"id":285,"url":"http://patchwork.ozlabs.org/api/1.0/series/285/?format=json","date":"2017-08-29T02:02:11","name":"complete deferred page initialization","version":7,"mbox":"http://patchwork.ozlabs.org/series/285/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/806906/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=sparclinux-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhBnd4VyGz9sRV\n\tfor ;\n\tTue, 29 Aug 2017 12:06:13 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751286AbdH2CDw (ORCPT );\n\tMon, 28 Aug 2017 22:03:52 -0400","from aserp1040.oracle.com ([141.146.126.69]:25864 \"EHLO\n\taserp1040.oracle.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751237AbdH2CDu (ORCPT\n\t); Mon, 28 Aug 2017 22:03:50 -0400","from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74])\n\tby aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with\n\tESMTP id v7T22enm011093\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Tue, 29 Aug 2017 02:02:41 GMT","from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75])\n\tby userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id v7T22e0J005404\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Tue, 29 Aug 2017 02:02:40 GMT","from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17])\n\tby userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id\n\tv7T22dYK012178; Tue, 29 Aug 2017 02:02:39 GMT","from ca-ldom-ol-build-1.us.oracle.com (/10.129.68.23)\n\tby default (Oracle Beehive Gateway v4.0)\n\twith ESMTP ; Mon, 28 Aug 2017 19:02:38 -0700"],"From":"Pavel Tatashin ","To":"linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org,\n\tlinux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org,\n\tlinux-s390@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n\tx86@kernel.org, kasan-dev@googlegroups.com, borntraeger@de.ibm.com,\n\theiko.carstens@de.ibm.com, davem@davemloft.net,\n\twilly@infradead.org, mhocko@kernel.org, ard.biesheuvel@linaro.org,\n\twill.deacon@arm.com, catalin.marinas@arm.com, sam@ravnborg.org,\n\tmgorman@techsingularity.net, Steven.Sistare@oracle.com,\n\tdaniel.m.jordan@oracle.com, bob.picco@oracle.com","Subject":"[PATCH v7 10/11] arm64/kasan: explicitly zero kasan shadow memory","Date":"Mon, 28 Aug 2017 22:02:21 -0400","Message-Id":"<1503972142-289376-11-git-send-email-pasha.tatashin@oracle.com>","X-Mailer":"git-send-email 1.7.1","In-Reply-To":"<1503972142-289376-1-git-send-email-pasha.tatashin@oracle.com>","References":"<1503972142-289376-1-git-send-email-pasha.tatashin@oracle.com>","X-Source-IP":"userv0022.oracle.com [156.151.31.74]","Sender":"sparclinux-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"sparclinux@vger.kernel.org"},"content":"To optimize the performance of struct page initialization,\nvmemmap_populate() will no longer zero memory.\n\nWe must explicitly zero the memory that is allocated by vmemmap_populate()\nfor kasan, as this memory does not go through struct page initialization\npath.\n\nSigned-off-by: Pavel Tatashin \nReviewed-by: Steven Sistare \nReviewed-by: Daniel Jordan \nReviewed-by: Bob Picco \n---\n arch/arm64/mm/kasan_init.c | 42 ++++++++++++++++++++++++++++++++++++++++++\n 1 file changed, 42 insertions(+)","diff":"diff --git a/arch/arm64/mm/kasan_init.c b/arch/arm64/mm/kasan_init.c\nindex 81f03959a4ab..e78a9ecbb687 100644\n--- a/arch/arm64/mm/kasan_init.c\n+++ b/arch/arm64/mm/kasan_init.c\n@@ -135,6 +135,41 @@ static void __init clear_pgds(unsigned long start,\n \t\tset_pgd(pgd_offset_k(start), __pgd(0));\n }\n \n+/*\n+ * Memory that was allocated by vmemmap_populate is not zeroed, so we must\n+ * zero it here explicitly.\n+ */\n+static void\n+zero_vmemmap_populated_memory(void)\n+{\n+\tstruct memblock_region *reg;\n+\tu64 start, end;\n+\n+\tfor_each_memblock(memory, reg) {\n+\t\tstart = __phys_to_virt(reg->base);\n+\t\tend = __phys_to_virt(reg->base + reg->size);\n+\n+\t\tif (start >= end)\n+\t\t\tbreak;\n+\n+\t\tstart = (u64)kasan_mem_to_shadow((void *)start);\n+\t\tend = (u64)kasan_mem_to_shadow((void *)end);\n+\n+\t\t/* Round to the start end of the mapped pages */\n+\t\tstart = round_down(start, SWAPPER_BLOCK_SIZE);\n+\t\tend = round_up(end, SWAPPER_BLOCK_SIZE);\n+\t\tmemset((void *)start, 0, end - start);\n+\t}\n+\n+\tstart = (u64)kasan_mem_to_shadow(_text);\n+\tend = (u64)kasan_mem_to_shadow(_end);\n+\n+\t/* Round to the start end of the mapped pages */\n+\tstart = round_down(start, SWAPPER_BLOCK_SIZE);\n+\tend = round_up(end, SWAPPER_BLOCK_SIZE);\n+\tmemset((void *)start, 0, end - start);\n+}\n+\n void __init kasan_init(void)\n {\n \tu64 kimg_shadow_start, kimg_shadow_end;\n@@ -205,8 +240,15 @@ void __init kasan_init(void)\n \t\t\tpfn_pte(sym_to_pfn(kasan_zero_page), PAGE_KERNEL_RO));\n \n \tmemset(kasan_zero_page, 0, PAGE_SIZE);\n+\n \tcpu_replace_ttbr1(lm_alias(swapper_pg_dir));\n \n+\t/*\n+\t * vmemmap_populate does not zero the memory, so we need to zero it\n+\t * explicitly\n+\t */\n+\tzero_vmemmap_populated_memory();\n+\n \t/* At this point kasan is fully initialized. Enable error messages */\n \tinit_task.kasan_depth = 0;\n \tpr_info(\"KernelAddressSanitizer initialized\\n\");\n","prefixes":["v7","10/11"]}