{"id":806892,"url":"http://patchwork.ozlabs.org/api/1.0/patches/806892/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<1503965694-10794-9-git-send-email-mdroth@linux.vnet.ibm.com>","date":"2017-08-29T00:13:43","name":"[08/79] migration: setup bi-directional I/O channel for exec: protocol","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"73525ada771ee07be78c43fab1a1a0b93fd5aa31","submitter":{"id":5549,"url":"http://patchwork.ozlabs.org/api/1.0/people/5549/?format=json","name":"Michael Roth","email":"mdroth@linux.vnet.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/1503965694-10794-9-git-send-email-mdroth@linux.vnet.ibm.com/mbox/","series":[{"id":281,"url":"http://patchwork.ozlabs.org/api/1.0/series/281/?format=json","date":"2017-08-29T00:13:45","name":"Patch Round-up for stable 2.9.1, freeze on 2017-09-04","version":1,"mbox":"http://patchwork.ozlabs.org/series/281/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/806892/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xh9fw3Fbmz9sP5\n\tfor ;\n\tTue, 29 Aug 2017 11:15:20 +1000 (AEST)","from localhost ([::1]:42224 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dmV7e-0003T6-AP\n\tfor incoming@patchwork.ozlabs.org; Mon, 28 Aug 2017 21:15:18 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:49228)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dmUD1-00020W-1O\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 20:16:50 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dmUCx-0006Nm-Rq\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 20:16:46 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5]:58369\n\thelo=mx0a-001b2d01.pphosted.com)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dmUCx-0006NS-Ke\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 20:16:43 -0400","from pps.filterd (m0098420.ppops.net [127.0.0.1])\n\tby mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv7T0E8J5099513\n\tfor ; Mon, 28 Aug 2017 20:16:43 -0400","from e16.ny.us.ibm.com (e16.ny.us.ibm.com [129.33.205.206])\n\tby mx0b-001b2d01.pphosted.com with ESMTP id 2cmr22ykuc-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Mon, 28 Aug 2017 20:16:43 -0400","from localhost\n\tby e16.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tMon, 28 Aug 2017 20:16:42 -0400","from b01cxnp22035.gho.pok.ibm.com (9.57.198.25)\n\tby e16.ny.us.ibm.com (146.89.104.203) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tMon, 28 Aug 2017 20:16:41 -0400","from b01ledav002.gho.pok.ibm.com (b01ledav002.gho.pok.ibm.com\n\t[9.57.199.107])\n\tby b01cxnp22035.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP\n\tid v7T0GdYZ32309280; Tue, 29 Aug 2017 00:16:40 GMT","from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id F0BE712404E;\n\tMon, 28 Aug 2017 20:14:00 -0400 (EDT)","from localhost (unknown [9.80.85.217])\n\tby b01ledav002.gho.pok.ibm.com (Postfix) with ESMTP id C3276124044;\n\tMon, 28 Aug 2017 20:14:00 -0400 (EDT)"],"From":"Michael Roth ","To":"qemu-devel@nongnu.org","Date":"Mon, 28 Aug 2017 19:13:43 -0500","X-Mailer":"git-send-email 2.7.4","In-Reply-To":"<1503965694-10794-1-git-send-email-mdroth@linux.vnet.ibm.com>","References":"<1503965694-10794-1-git-send-email-mdroth@linux.vnet.ibm.com>","X-TM-AS-GCONF":"00","x-cbid":"17082900-0024-0000-0000-000002C6D2EA","X-IBM-SpamModules-Scores":"","X-IBM-SpamModules-Versions":"BY=3.00007630; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000226; SDB=6.00909028; UDB=6.00455849;\n\tIPR=6.00689279; \n\tBA=6.00005557; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00016909;\n\tXFM=3.00000015; UTC=2017-08-29 00:16:42","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17082900-0025-0000-0000-0000453E639C","Message-Id":"<1503965694-10794-9-git-send-email-mdroth@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-08-28_13:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=1\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1708290001","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.158.5","Subject":"[Qemu-devel] [PATCH 08/79] migration: setup bi-directional I/O\n\tchannel for exec: protocol","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-stable@nongnu.org, Juan Quintela ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"From: \"Daniel P. Berrange\" \n\nHistorically the migration data channel has only needed to be\nunidirectional. Thus the 'exec:' protocol was requesting an\nI/O channel with O_RDONLY on incoming side, and O_WRONLY on\nthe outgoing side.\n\nThis is fine for classic migration, but if you then try to run\nTLS over it, this fails because the TLS handshake requires a\nbi-directional channel.\n\nSigned-off-by: Daniel P. Berrange \nReviewed-by: Juan Quintela \nSigned-off-by: Juan Quintela \n(cherry picked from commit 062d81f0e968fe1597474735f3ea038065027372)\nSigned-off-by: Michael Roth \n---\n migration/exec.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/migration/exec.c b/migration/exec.c\nindex 9157721..aba9089 100644\n--- a/migration/exec.c\n+++ b/migration/exec.c\n@@ -32,7 +32,7 @@ void exec_start_outgoing_migration(MigrationState *s, const char *command, Error\n \n trace_migration_exec_outgoing(command);\n ioc = QIO_CHANNEL(qio_channel_command_new_spawn(argv,\n- O_WRONLY,\n+ O_RDWR,\n errp));\n if (!ioc) {\n return;\n@@ -59,7 +59,7 @@ void exec_start_incoming_migration(const char *command, Error **errp)\n \n trace_migration_exec_incoming(command);\n ioc = QIO_CHANNEL(qio_channel_command_new_spawn(argv,\n- O_RDONLY,\n+ O_RDWR,\n errp));\n if (!ioc) {\n return;\n","prefixes":["08/79"]}