{"id":806862,"url":"http://patchwork.ozlabs.org/api/1.0/patches/806862/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<1503965694-10794-39-git-send-email-mdroth@linux.vnet.ibm.com>","date":"2017-08-29T00:14:13","name":"[38/79] blkdebug: Sanity check block layer guarantees","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"1de0fd58f2d73a194bbea4cb10a4ec3173f1b603","submitter":{"id":5549,"url":"http://patchwork.ozlabs.org/api/1.0/people/5549/?format=json","name":"Michael Roth","email":"mdroth@linux.vnet.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/1503965694-10794-39-git-send-email-mdroth@linux.vnet.ibm.com/mbox/","series":[{"id":281,"url":"http://patchwork.ozlabs.org/api/1.0/series/281/?format=json","date":"2017-08-29T00:13:45","name":"Patch Round-up for stable 2.9.1, freeze on 2017-09-04","version":1,"mbox":"http://patchwork.ozlabs.org/series/281/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/806862/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xh9BJ0gCdz9s7M\n\tfor ;\n\tTue, 29 Aug 2017 10:54:00 +1000 (AEST)","from localhost ([::1]:42095 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dmUmz-00013l-SU\n\tfor incoming@patchwork.ozlabs.org; Mon, 28 Aug 2017 20:53:57 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:48055)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dmUCT-0001Hl-Hl\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 20:16:16 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dmUCQ-0005Sl-BP\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 20:16:13 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5]:53239\n\thelo=mx0a-001b2d01.pphosted.com)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dmUCQ-0005SD-5r\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 20:16:10 -0400","from pps.filterd (m0098421.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv7T0E9gi081527\n\tfor ; Mon, 28 Aug 2017 20:16:09 -0400","from e37.co.us.ibm.com (e37.co.us.ibm.com [32.97.110.158])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2cmurncrm9-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Mon, 28 Aug 2017 20:16:09 -0400","from localhost\n\tby e37.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tMon, 28 Aug 2017 18:16:08 -0600","from b03cxnp08026.gho.boulder.ibm.com (9.17.130.18)\n\tby e37.co.us.ibm.com (192.168.1.137) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tMon, 28 Aug 2017 18:16:05 -0600","from b03ledav005.gho.boulder.ibm.com\n\t(b03ledav005.gho.boulder.ibm.com [9.17.130.236])\n\tby b03cxnp08026.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v7T0G5L762849082; Mon, 28 Aug 2017 17:16:05 -0700","from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id DCBE7BE040;\n\tMon, 28 Aug 2017 18:16:04 -0600 (MDT)","from localhost (unknown [9.80.85.217])\n\tby b03ledav005.gho.boulder.ibm.com (Postfix) with ESMTP id A9C12BE038;\n\tMon, 28 Aug 2017 18:16:04 -0600 (MDT)"],"From":"Michael Roth ","To":"qemu-devel@nongnu.org","Date":"Mon, 28 Aug 2017 19:14:13 -0500","X-Mailer":"git-send-email 2.7.4","In-Reply-To":"<1503965694-10794-1-git-send-email-mdroth@linux.vnet.ibm.com>","References":"<1503965694-10794-1-git-send-email-mdroth@linux.vnet.ibm.com>","X-TM-AS-GCONF":"00","x-cbid":"17082900-0024-0000-0000-0000171CE4B8","X-IBM-SpamModules-Scores":"","X-IBM-SpamModules-Versions":"BY=3.00007630; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000226; SDB=6.00909028; UDB=6.00455849;\n\tIPR=6.00689279; \n\tBA=6.00005557; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00016909;\n\tXFM=3.00000015; UTC=2017-08-29 00:16:07","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17082900-0025-0000-0000-00004C7F0529","Message-Id":"<1503965694-10794-39-git-send-email-mdroth@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-08-28_13:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=1\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1708290001","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.158.5","Subject":"[Qemu-devel] [PATCH 38/79] blkdebug: Sanity check block layer\n\tguarantees","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-stable@nongnu.org, Max Reitz ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"From: Eric Blake \n\nCommits 04ed95f4 and 1a62d0ac updated the block layer to auto-fragment\nany I/O to fit within device boundaries. Additionally, when using a\nminimum alignment of 4k, we want to ensure the block layer does proper\nread-modify-write rather than requesting I/O on a slice of a sector.\nLet's enforce that the contract is obeyed when using blkdebug. For\nnow, blkdebug only allows alignment overrides, and just inherits other\nlimits from whatever device it is wrapping, but a future patch will\nfurther enhance things.\n\nSigned-off-by: Eric Blake \nReviewed-by: Kevin Wolf \nReviewed-by: Max Reitz \nMessage-id: 20170429191419.30051-5-eblake@redhat.com\nSigned-off-by: Max Reitz \n(cherry picked from commit e0ef439588ce1ede747f82b77d893190c1cc9f4d)\n* prereq for 81c219a\nSigned-off-by: Michael Roth \n---\n block/blkdebug.c | 14 ++++++++++++++\n 1 file changed, 14 insertions(+)","diff":"diff --git a/block/blkdebug.c b/block/blkdebug.c\nindex 46bd08a..b2cee0c 100644\n--- a/block/blkdebug.c\n+++ b/block/blkdebug.c\n@@ -429,6 +429,13 @@ blkdebug_co_preadv(BlockDriverState *bs, uint64_t offset, uint64_t bytes,\n BDRVBlkdebugState *s = bs->opaque;\n BlkdebugRule *rule = NULL;\n \n+ /* Sanity check block layer guarantees */\n+ assert(QEMU_IS_ALIGNED(offset, bs->bl.request_alignment));\n+ assert(QEMU_IS_ALIGNED(bytes, bs->bl.request_alignment));\n+ if (bs->bl.max_transfer) {\n+ assert(bytes <= bs->bl.max_transfer);\n+ }\n+\n QSIMPLEQ_FOREACH(rule, &s->active_rules, active_next) {\n uint64_t inject_offset = rule->options.inject.offset;\n \n@@ -453,6 +460,13 @@ blkdebug_co_pwritev(BlockDriverState *bs, uint64_t offset, uint64_t bytes,\n BDRVBlkdebugState *s = bs->opaque;\n BlkdebugRule *rule = NULL;\n \n+ /* Sanity check block layer guarantees */\n+ assert(QEMU_IS_ALIGNED(offset, bs->bl.request_alignment));\n+ assert(QEMU_IS_ALIGNED(bytes, bs->bl.request_alignment));\n+ if (bs->bl.max_transfer) {\n+ assert(bytes <= bs->bl.max_transfer);\n+ }\n+\n QSIMPLEQ_FOREACH(rule, &s->active_rules, active_next) {\n uint64_t inject_offset = rule->options.inject.offset;\n \n","prefixes":["38/79"]}