{"id":806853,"url":"http://patchwork.ozlabs.org/api/1.0/patches/806853/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<1503965694-10794-35-git-send-email-mdroth@linux.vnet.ibm.com>","date":"2017-08-29T00:14:09","name":"[34/79] virtio-scsi: Unset hotplug handler when unrealize","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"55dea03583cf9fcc2a4ad0dab65ee0d0889dd210","submitter":{"id":5549,"url":"http://patchwork.ozlabs.org/api/1.0/people/5549/?format=json","name":"Michael Roth","email":"mdroth@linux.vnet.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/1503965694-10794-35-git-send-email-mdroth@linux.vnet.ibm.com/mbox/","series":[{"id":281,"url":"http://patchwork.ozlabs.org/api/1.0/series/281/?format=json","date":"2017-08-29T00:13:45","name":"Patch Round-up for stable 2.9.1, freeze on 2017-09-04","version":1,"mbox":"http://patchwork.ozlabs.org/series/281/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/806853/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xh92f6Bflz9s7M\n\tfor ;\n\tTue, 29 Aug 2017 10:47:22 +1000 (AEST)","from localhost ([::1]:42057 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dmUga-0003ub-MK\n\tfor incoming@patchwork.ozlabs.org; Mon, 28 Aug 2017 20:47:20 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:47962)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dmUCQ-0001Dx-Lz\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 20:16:11 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dmUCN-0005Po-Ek\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 20:16:10 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5]:41806\n\thelo=mx0a-001b2d01.pphosted.com)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dmUCN-0005PV-9L\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 20:16:07 -0400","from pps.filterd (m0098414.ppops.net [127.0.0.1])\n\tby mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv7T0E8Bm019422\n\tfor ; Mon, 28 Aug 2017 20:16:06 -0400","from e33.co.us.ibm.com (e33.co.us.ibm.com [32.97.110.151])\n\tby mx0b-001b2d01.pphosted.com with ESMTP id 2cmsfn2w86-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Mon, 28 Aug 2017 20:16:06 -0400","from localhost\n\tby e33.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tMon, 28 Aug 2017 18:16:06 -0600","from b03cxnp08028.gho.boulder.ibm.com (9.17.130.20)\n\tby e33.co.us.ibm.com (192.168.1.133) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tMon, 28 Aug 2017 18:16:01 -0600","from b03ledav001.gho.boulder.ibm.com\n\t(b03ledav001.gho.boulder.ibm.com [9.17.130.232])\n\tby b03cxnp08028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v7T0G1RP30408896; Mon, 28 Aug 2017 17:16:01 -0700","from b03ledav001.gho.boulder.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 46EB26E040;\n\tMon, 28 Aug 2017 18:16:01 -0600 (MDT)","from localhost (unknown [9.80.85.217])\n\tby b03ledav001.gho.boulder.ibm.com (Postfix) with ESMTP id 1E0496E03D;\n\tMon, 28 Aug 2017 18:16:01 -0600 (MDT)"],"From":"Michael Roth ","To":"qemu-devel@nongnu.org","Date":"Mon, 28 Aug 2017 19:14:09 -0500","X-Mailer":"git-send-email 2.7.4","In-Reply-To":"<1503965694-10794-1-git-send-email-mdroth@linux.vnet.ibm.com>","References":"<1503965694-10794-1-git-send-email-mdroth@linux.vnet.ibm.com>","X-TM-AS-GCONF":"00","x-cbid":"17082900-0008-0000-0000-0000087D385B","X-IBM-SpamModules-Scores":"","X-IBM-SpamModules-Versions":"BY=3.00007630; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000226; SDB=6.00909028; UDB=6.00455849;\n\tIPR=6.00689279; \n\tBA=6.00005557; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00016909;\n\tXFM=3.00000015; UTC=2017-08-29 00:16:04","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17082900-0009-0000-0000-000043C046C3","Message-Id":"<1503965694-10794-35-git-send-email-mdroth@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-08-28_13:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=3\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1708290001","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.158.5","Subject":"[Qemu-devel] [PATCH 34/79] virtio-scsi: Unset hotplug handler when\n\tunrealize","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Paolo Bonzini , Fam Zheng ,\n\tqemu-stable@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"From: Fam Zheng \n\nThis matches the qbus_set_hotplug_handler in realize, and it releases\nthe final reference to the embedded VirtIODevice so that it is\nproperly finalized.\n\nA use-after-free is fixed with this patch, indirectly:\nvirtio_device_instance_finalize wasn't called at hot-unplug, and the\nvdev->listener would be a dangling pointer in the global and the per\naddress space listener list. See also RHBZ 1449031.\n\nCc: qemu-stable@nongnu.org\nSigned-off-by: Fam Zheng \nMessage-Id: <20170518102808.30046-1-famz@redhat.com>\nSigned-off-by: Paolo Bonzini \n(cherry picked from commit 2cbe2de5454cf9af44b620b2b40d56361a12a45f)\nSigned-off-by: Michael Roth \n---\n hw/scsi/virtio-scsi.c | 3 +++\n 1 file changed, 3 insertions(+)","diff":"diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c\nindex bd62d08..cb1c123 100644\n--- a/hw/scsi/virtio-scsi.c\n+++ b/hw/scsi/virtio-scsi.c\n@@ -915,6 +915,9 @@ void virtio_scsi_common_unrealize(DeviceState *dev, Error **errp)\n \n static void virtio_scsi_device_unrealize(DeviceState *dev, Error **errp)\n {\n+ VirtIOSCSI *s = VIRTIO_SCSI(dev);\n+\n+ qbus_set_hotplug_handler(BUS(&s->bus), NULL, &error_abort);\n virtio_scsi_common_unrealize(dev, errp);\n }\n \n","prefixes":["34/79"]}