{"id":806811,"url":"http://patchwork.ozlabs.org/api/1.0/patches/806811/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<1503965694-10794-12-git-send-email-mdroth@linux.vnet.ibm.com>","date":"2017-08-29T00:13:46","name":"[11/79] ACPI: don't call acpi_pcihp_device_plug_cb on xen","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"ed41998b92250b978e908af228f7141e391eaf3d","submitter":{"id":5549,"url":"http://patchwork.ozlabs.org/api/1.0/people/5549/?format=json","name":"Michael Roth","email":"mdroth@linux.vnet.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/1503965694-10794-12-git-send-email-mdroth@linux.vnet.ibm.com/mbox/","series":[{"id":281,"url":"http://patchwork.ozlabs.org/api/1.0/series/281/?format=json","date":"2017-08-29T00:13:45","name":"Patch Round-up for stable 2.9.1, freeze on 2017-09-04","version":1,"mbox":"http://patchwork.ozlabs.org/series/281/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/806811/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xh8PZ371Gz9s7v\n\tfor ;\n\tTue, 29 Aug 2017 10:18:42 +1000 (AEST)","from localhost ([::1]:41885 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dmUEq-000371-6X\n\tfor incoming@patchwork.ozlabs.org; Mon, 28 Aug 2017 20:18:40 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:47342)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dmUC6-0000r2-GK\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 20:15:53 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dmUC2-00053w-3p\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 20:15:50 -0400","from mx0a-001b2d01.pphosted.com ([148.163.156.1]:37381)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dmUC1-000535-Rt\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 20:15:46 -0400","from pps.filterd (m0098409.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv7T0EDJ6090293\n\tfor ; Mon, 28 Aug 2017 20:15:45 -0400","from e14.ny.us.ibm.com (e14.ny.us.ibm.com [129.33.205.204])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2cmvyehjxw-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Mon, 28 Aug 2017 20:15:44 -0400","from localhost\n\tby e14.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tMon, 28 Aug 2017 20:15:43 -0400","from b01cxnp23034.gho.pok.ibm.com (9.57.198.29)\n\tby e14.ny.us.ibm.com (146.89.104.201) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tMon, 28 Aug 2017 20:15:40 -0400","from b01ledav002.gho.pok.ibm.com (b01ledav002.gho.pok.ibm.com\n\t[9.57.199.107])\n\tby b01cxnp23034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP\n\tid v7T0Ferg25231586; Tue, 29 Aug 2017 00:15:40 GMT","from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 602B8124035;\n\tMon, 28 Aug 2017 20:13:00 -0400 (EDT)","from localhost (unknown [9.80.85.217])\n\tby b01ledav002.gho.pok.ibm.com (Postfix) with ESMTP id 32E7F12403F;\n\tMon, 28 Aug 2017 20:13:00 -0400 (EDT)"],"From":"Michael Roth ","To":"qemu-devel@nongnu.org","Date":"Mon, 28 Aug 2017 19:13:46 -0500","X-Mailer":"git-send-email 2.7.4","In-Reply-To":"<1503965694-10794-1-git-send-email-mdroth@linux.vnet.ibm.com>","References":"<1503965694-10794-1-git-send-email-mdroth@linux.vnet.ibm.com>","X-TM-AS-GCONF":"00","x-cbid":"17082900-0052-0000-0000-00000257331B","X-IBM-SpamModules-Scores":"","X-IBM-SpamModules-Versions":"BY=3.00007630; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000226; SDB=6.00909028; UDB=6.00455849;\n\tIPR=6.00689279; \n\tBA=6.00005557; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00016909;\n\tXFM=3.00000015; UTC=2017-08-29 00:15:42","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17082900-0053-0000-0000-000051D1D903","Message-Id":"<1503965694-10794-12-git-send-email-mdroth@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-08-28_13:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=1\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1708290001","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.156.1","Subject":"[Qemu-devel] [PATCH 11/79] ACPI: don't call\n\tacpi_pcihp_device_plug_cb on xen","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"\"Michael S . Tsirkin\" , qemu-stable@nongnu.org,\n\tBruce Rogers ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"From: Bruce Rogers \n\nCommit f0c9d64a exposed the issue that with a xenfv machine using\npci passthrough, acpi pci hotplug code was being executed by mistake.\nGuard calls to acpi_pcihp_device_plug_cb (and corresponding\nacpi_pcihp_device_unplug_cb) with a check for xen_enabled(). Without\nthis check I am seeing an error that the bus doesn't have the\nacpi-pcihp-bsel property set.\n\nSigned-off-by: Bruce Rogers \nReviewed-by: Igor Mammedov \nReviewed-by: Michael S. Tsirkin \nSigned-off-by: Michael S. Tsirkin \n(cherry picked from commit 153eba4726dfa1bdfc31d1fe973b2a61b9035492)\nSigned-off-by: Michael Roth \n---\n hw/acpi/piix4.c | 11 ++++++++---\n 1 file changed, 8 insertions(+), 3 deletions(-)","diff":"diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c\nindex a553a7e..c409374 100644\n--- a/hw/acpi/piix4.c\n+++ b/hw/acpi/piix4.c\n@@ -385,7 +385,10 @@ static void piix4_device_plug_cb(HotplugHandler *hotplug_dev,\n dev, errp);\n }\n } else if (object_dynamic_cast(OBJECT(dev), TYPE_PCI_DEVICE)) {\n- acpi_pcihp_device_plug_cb(hotplug_dev, &s->acpi_pci_hotplug, dev, errp);\n+ if (!xen_enabled()) {\n+ acpi_pcihp_device_plug_cb(hotplug_dev, &s->acpi_pci_hotplug, dev,\n+ errp);\n+ }\n } else if (object_dynamic_cast(OBJECT(dev), TYPE_CPU)) {\n if (s->cpu_hotplug_legacy) {\n legacy_acpi_cpu_plug_cb(hotplug_dev, &s->gpe_cpu, dev, errp);\n@@ -408,8 +411,10 @@ static void piix4_device_unplug_request_cb(HotplugHandler *hotplug_dev,\n acpi_memory_unplug_request_cb(hotplug_dev, &s->acpi_memory_hotplug,\n dev, errp);\n } else if (object_dynamic_cast(OBJECT(dev), TYPE_PCI_DEVICE)) {\n- acpi_pcihp_device_unplug_cb(hotplug_dev, &s->acpi_pci_hotplug, dev,\n- errp);\n+ if (!xen_enabled()) {\n+ acpi_pcihp_device_unplug_cb(hotplug_dev, &s->acpi_pci_hotplug, dev,\n+ errp);\n+ }\n } else if (object_dynamic_cast(OBJECT(dev), TYPE_CPU) &&\n !s->cpu_hotplug_legacy) {\n acpi_cpu_unplug_request_cb(hotplug_dev, &s->cpuhp_state, dev, errp);\n","prefixes":["11/79"]}