{"id":806792,"url":"http://patchwork.ozlabs.org/api/1.0/patches/806792/?format=json","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.0/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<1503956111-36652-23-git-send-email-keescook@chromium.org>","date":"2017-08-28T21:35:03","name":"[v2,22/30] sctp: Copy struct sctp_sock.autoclose to userspace using put_user()","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":true,"hash":"15ef045aee2b414c411110ab21ce8bfd04cdb32f","submitter":{"id":10641,"url":"http://patchwork.ozlabs.org/api/1.0/people/10641/?format=json","name":"Kees Cook","email":"keescook@chromium.org"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/1.0/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/1503956111-36652-23-git-send-email-keescook@chromium.org/mbox/","series":[{"id":266,"url":"http://patchwork.ozlabs.org/api/1.0/series/266/?format=json","date":"2017-08-28T21:35:01","name":null,"version":2,"mbox":"http://patchwork.ozlabs.org/series/266/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/806792/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"inUPgrhF\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xh5640yRZz9t69\n\tfor ;\n\tTue, 29 Aug 2017 07:50:04 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751378AbdH1Vnz (ORCPT );\n\tMon, 28 Aug 2017 17:43:55 -0400","from mail-pg0-f49.google.com ([74.125.83.49]:34352 \"EHLO\n\tmail-pg0-f49.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751341AbdH1Vnw (ORCPT\n\t); Mon, 28 Aug 2017 17:43:52 -0400","by mail-pg0-f49.google.com with SMTP id y15so5061597pgc.1\n\tfor ; Mon, 28 Aug 2017 14:43:52 -0700 (PDT)","from www.outflux.net\n\t(173-164-112-133-Oregon.hfc.comcastbusiness.net. [173.164.112.133])\n\tby smtp.gmail.com with ESMTPSA id\n\tx4sm2016851pfx.63.2017.08.28.14.43.50\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 28 Aug 2017 14:43:50 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=9cyBftQfPqK7PDY8LWTFN/JFh3fIaaX1WPYrgMl9lFo=;\n\tb=inUPgrhFrQe9FFzy/s7DuqBpL7b9u9IOC7YvzWKS2LRhp2h7wBfqWbsSfUs/StH/9L\n\txPhCCKMaBikNPP/leGVZsAkhTnvDt9daJXYJDSMRmppjTLwMQcGi+iuhIoYLsLc0Plzt\n\tj6ZM3lcDA+tEwZvnkFZnQlSWL3ILH9IYsbbdE=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=9cyBftQfPqK7PDY8LWTFN/JFh3fIaaX1WPYrgMl9lFo=;\n\tb=DWPZpvZDHvpOtP57djFkDMmukNRyvuBvVmJVOVEPIqut9iiB62N34gkjzeT24SKrdW\n\tVgB09An9fIqs94AKGufH/oniqa3QWJsQzaP7NjWH+IPAota9lonCUMlVCkJf3A09q4aj\n\tHN8eyZYqCYZ8SCoaf/aIBR3om2NFNGV9TQAciU8yu9jUx8f9hvgzI1+cG4BrX7FBsdZQ\n\tST3lVsV+SUZbkpLPxSCChWw4ofi3NeIlRZPXsaP4d8WLD6yjoIo5T7PRFh/0yil0zBHI\n\tjxylF//GyzBo14sZ/pw/V6Fa3lmEdPrUbQ8PnDfmyPekATuyBwpLT5A5nWS+WJRJId9/\n\tZUdA==","X-Gm-Message-State":"AHYfb5j2yubuX0dS9bKqxF3nc/dio9UNxRtB18ECZzZ74DAjTye8yWM1\n\taM8biw0x8gINh/JW","X-Received":"by 10.84.254.7 with SMTP id b7mr2386319plm.292.1503956631339;\n\tMon, 28 Aug 2017 14:43:51 -0700 (PDT)","From":"Kees Cook ","To":"linux-kernel@vger.kernel.org","Cc":"Kees Cook , David Windsor ,\n\tVlad Yasevich , Neil Horman ,\n\t\"David S. Miller\" ,\n\tlinux-sctp@vger.kernel.org, netdev@vger.kernel.org,\n\tlinux-mm@kvack.org, kernel-hardening@lists.openwall.com","Subject":"[PATCH v2 22/30] sctp: Copy struct sctp_sock.autoclose to userspace\n\tusing put_user()","Date":"Mon, 28 Aug 2017 14:35:03 -0700","Message-Id":"<1503956111-36652-23-git-send-email-keescook@chromium.org>","X-Mailer":"git-send-email 2.7.4","In-Reply-To":"<1503956111-36652-1-git-send-email-keescook@chromium.org>","References":"<1503956111-36652-1-git-send-email-keescook@chromium.org>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"From: David Windsor \n\nThe autoclose field can be copied with put_user(), so there is no need to\nuse copy_to_user(). In both cases, hardened usercopy is being bypassed\nsince the size is constant, and not open to runtime manipulation.\n\nThis patch is verbatim from Brad Spengler/PaX Team's PAX_USERCOPY\nwhitelisting code in the last public patch of grsecurity/PaX based on my\nunderstanding of the code. Changes or omissions from the original code are\nmine and don't reflect the original grsecurity/PaX code.\n\nSigned-off-by: David Windsor \n[kees: adjust commit log]\nCc: Vlad Yasevich \nCc: Neil Horman \nCc: \"David S. Miller\" \nCc: linux-sctp@vger.kernel.org\nCc: netdev@vger.kernel.org\nSigned-off-by: Kees Cook \n---\n net/sctp/socket.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/net/sctp/socket.c b/net/sctp/socket.c\nindex c8784cb216e4..a29e41e19d64 100644\n--- a/net/sctp/socket.c\n+++ b/net/sctp/socket.c\n@@ -4882,7 +4882,7 @@ static int sctp_getsockopt_autoclose(struct sock *sk, int len, char __user *optv\n \tlen = sizeof(int);\n \tif (put_user(len, optlen))\n \t\treturn -EFAULT;\n-\tif (copy_to_user(optval, &sctp_sk(sk)->autoclose, sizeof(int)))\n+\tif (put_user(sctp_sk(sk)->autoclose, (int __user *)optval))\n \t\treturn -EFAULT;\n \treturn 0;\n }\n","prefixes":["v2","22/30"]}