{"id":806758,"url":"http://patchwork.ozlabs.org/api/1.0/patches/806758/?format=json","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.0/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<1503951789-31836-1-git-send-email-dsahern@gmail.com>","date":"2017-08-28T20:23:09","name":"[net-next] Revert \"ipv4: make net_protocol const\"","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"b0407fd597fd6a1107a69d6ad261e6589c0490b9","submitter":{"id":6918,"url":"http://patchwork.ozlabs.org/api/1.0/people/6918/?format=json","name":"David Ahern","email":"dsahern@gmail.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/1.0/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/1503951789-31836-1-git-send-email-dsahern@gmail.com/mbox/","series":[{"id":252,"url":"http://patchwork.ozlabs.org/api/1.0/series/252/?format=json","date":"2017-08-28T20:23:09","name":"[net-next] Revert \"ipv4: make net_protocol const\"","version":1,"mbox":"http://patchwork.ozlabs.org/series/252/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/806758/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"KiuPkhxx\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xh39x6jQzz9s7p\n\tfor ;\n\tTue, 29 Aug 2017 06:23:17 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751215AbdH1UXP (ORCPT );\n\tMon, 28 Aug 2017 16:23:15 -0400","from mail-pf0-f194.google.com ([209.85.192.194]:38668 \"EHLO\n\tmail-pf0-f194.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750735AbdH1UXO (ORCPT\n\t); Mon, 28 Aug 2017 16:23:14 -0400","by mail-pf0-f194.google.com with SMTP id r187so952880pfr.5\n\tfor ; Mon, 28 Aug 2017 13:23:14 -0700 (PDT)","from kenny.it.cumulusnetworks.com. (fw.cumulusnetworks.com.\n\t[216.129.126.126]) by smtp.googlemail.com with ESMTPSA id\n\ts73sm2478148pfe.65.2017.08.28.13.23.13\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tMon, 28 Aug 2017 13:23:13 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id;\n\tbh=tS4eV5x8eMwfwLI0eMdZYfijWT4uC3yJtBiV3WhykDQ=;\n\tb=KiuPkhxxDvEDA2eM9nFzDP79hx7zKgJ8vt0yYPOOCKTxWFV+KzM01f39SJt64T2YUP\n\tDV8AyQQ5zMiHkFO+ibzYWCc7Nb9Xi8kd51Snku27pDjhmHQGHw44lFCIEo25SvYZ4/Pa\n\tCFa+qEIgH1WZmibSN1bY6xh1FMpDFzfSGQSY/OQo5oFX34hxHVITRnoJ7m7IvkGIO1c2\n\twWlcLnMHWq6u04EAcwFILKU7YQoRZYrz4dLiFnq/cdmzP3OCdikZ/MTIgVGEuhPeOxQR\n\th8SCHMr4lopKqJqKhJVGC41Dz2xfHenan23jiOvnqCYT5Sf0vYypPqazm4wPhAhuBRZ3\n\tnx9w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=tS4eV5x8eMwfwLI0eMdZYfijWT4uC3yJtBiV3WhykDQ=;\n\tb=t9kWmQy0R+U1nPb19eF4Ty54mokZDn8EhzHJVJAOUtFomCWomJ/Tt6+2J02gQuulZ+\n\t84qHEwQDE5D325wX5nDKdCGPKPK3gZPvztCmrtgR5d+nE3u9hieMKnyPLHh409o+Pkbx\n\tI8/N5OnvOtOBuXFiBOVP6u1L1qOQQaCXwXR8yzKrIX2DRYhp1UG+u21qzZkT4M3Gesxy\n\tiDRlZbyTu0LTCHUHprOc2VC4/pLl1pAftofc8FGmPRuY41F6cf3arwam+Eq+WHY448mu\n\t86/NhVYc8XyANuwNlGDDhhwVzm4iTcYwC3SnR77GtrepTax4O2fY7qWPGNMswnbd+x/I\n\tU0jg==","X-Gm-Message-State":"AHYfb5iCXZNQVHZDtNn8bquiQlzt+uhmE1YjWOAIynpzaf+HycmGbTyw\n\tsKHJHdhAFi0GTwps","X-Received":"by 10.84.151.69 with SMTP id i63mr2193884pli.343.1503951793889; \n\tMon, 28 Aug 2017 13:23:13 -0700 (PDT)","From":"David Ahern ","To":"netdev@vger.kernel.org, bhumirks@gmail.com, davem@davemloft.net","Cc":"David Ahern ","Subject":"[PATCH net-next] Revert \"ipv4: make net_protocol const\"","Date":"Mon, 28 Aug 2017 13:23:09 -0700","Message-Id":"<1503951789-31836-1-git-send-email-dsahern@gmail.com>","X-Mailer":"git-send-email 2.1.4","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"This reverts commit aa8db499ea67cff1f5f049033810ffede2fe5ae4.\n\nEarly demux structs can not be made const. Doing so results in:\n[ 84.967355] BUG: unable to handle kernel paging request at ffffffff81684b10\n[ 84.969272] IP: proc_configure_early_demux+0x1e/0x3d\n[ 84.970544] PGD 1a0a067\n[ 84.970546] P4D 1a0a067\n[ 84.971212] PUD 1a0b063\n[ 84.971733] PMD 80000000016001e1\n\n[ 84.972669] Oops: 0003 [#1] SMP\n[ 84.973065] Modules linked in: ip6table_filter ip6_tables veth vrf\n[ 84.973833] CPU: 0 PID: 955 Comm: sysctl Not tainted 4.13.0-rc6+ #22\n[ 84.974612] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.7.5-20140531_083030-gandalf 04/01/2014\n[ 84.975855] task: ffff88003854ce00 task.stack: ffffc900005a4000\n[ 84.976580] RIP: 0010:proc_configure_early_demux+0x1e/0x3d\n[ 84.977253] RSP: 0018:ffffc900005a7dd0 EFLAGS: 00010246\n[ 84.977891] RAX: ffffffff81684b10 RBX: 0000000000000001 RCX: 0000000000000000\n[ 84.978759] RDX: 0000000000000000 RSI: 0000000000000006 RDI: 0000000000000000\n[ 84.979628] RBP: ffffc900005a7dd0 R08: 0000000000000000 R09: 0000000000000000\n[ 84.980501] R10: 0000000000000001 R11: 0000000000000008 R12: 0000000000000001\n[ 84.981373] R13: ffffffffffffffea R14: ffffffff81a9b4c0 R15: 0000000000000002\n[ 84.982249] FS: 00007feb237b7700(0000) GS:ffff88003fc00000(0000) knlGS:0000000000000000\n[ 84.983231] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033\n[ 84.983941] CR2: ffffffff81684b10 CR3: 0000000038492000 CR4: 00000000000406f0\n[ 84.984817] Call Trace:\n[ 84.985133] proc_tcp_early_demux+0x29/0x30\n\nI think this is the second time such a patch has been reverted.\n\nCc: Bhumika Goyal \nSigned-off-by: David Ahern \n---\nBhumika: How are you testing these constify changes? In this case a simple\nsysctl -w net.ipv4.tcp_early_demux=1 would have shown the problem\n\n net/ipv4/af_inet.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c\nindex 19aee073ba29..d678820e4306 100644\n--- a/net/ipv4/af_inet.c\n+++ b/net/ipv4/af_inet.c\n@@ -1596,7 +1596,7 @@ static const struct net_protocol igmp_protocol = {\n };\n #endif\n \n-static const struct net_protocol tcp_protocol = {\n+static struct net_protocol tcp_protocol = {\n \t.early_demux\t=\ttcp_v4_early_demux,\n \t.early_demux_handler = tcp_v4_early_demux,\n \t.handler\t=\ttcp_v4_rcv,\n@@ -1606,7 +1606,7 @@ static const struct net_protocol tcp_protocol = {\n \t.icmp_strict_tag_validation = 1,\n };\n \n-static const struct net_protocol udp_protocol = {\n+static struct net_protocol udp_protocol = {\n \t.early_demux =\tudp_v4_early_demux,\n \t.early_demux_handler =\tudp_v4_early_demux,\n \t.handler =\tudp_rcv,\n","prefixes":["net-next"]}