{"id":806742,"url":"http://patchwork.ozlabs.org/api/1.0/patches/806742/?format=json","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.0/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20170828191748.19492-11-vivien.didelot@savoirfairelinux.com>","date":"2017-08-28T19:17:48","name":"[net-next,v2,10/10] net: dsa: debugfs: add port vlan","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":true,"hash":"35acb0130abd406f179370d54828f44b4c862965","submitter":{"id":15889,"url":"http://patchwork.ozlabs.org/api/1.0/people/15889/?format=json","name":"Vivien Didelot","email":"vivien.didelot@savoirfairelinux.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/1.0/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20170828191748.19492-11-vivien.didelot@savoirfairelinux.com/mbox/","series":[{"id":246,"url":"http://patchwork.ozlabs.org/api/1.0/series/246/?format=json","date":"2017-08-28T19:17:41","name":"net: dsa: add generic debugfs interface","version":2,"mbox":"http://patchwork.ozlabs.org/series/246/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/806742/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xh24R0c4Kz9t0M\n\tfor ;\n\tTue, 29 Aug 2017 05:33:27 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751801AbdH1TXR (ORCPT );\n\tMon, 28 Aug 2017 15:23:17 -0400","from mail.savoirfairelinux.com ([208.88.110.44]:36452 \"EHLO\n\tmail.savoirfairelinux.com\" rhost-flags-OK-OK-OK-OK) by\n\tvger.kernel.org with ESMTP id S1751288AbdH1TVl (ORCPT\n\t); Mon, 28 Aug 2017 15:21:41 -0400","from localhost (localhost [127.0.0.1])\n\tby mail.savoirfairelinux.com (Postfix) with ESMTP id D10E39C2377;\n\tMon, 28 Aug 2017 15:21:40 -0400 (EDT)","from mail.savoirfairelinux.com ([127.0.0.1])\n\tby localhost (mail.savoirfairelinux.com [127.0.0.1]) (amavisd-new,\n\tport 10032)\n\twith ESMTP id 6NnOnwdULqXr; Mon, 28 Aug 2017 15:21:40 -0400 (EDT)","from localhost (localhost [127.0.0.1])\n\tby mail.savoirfairelinux.com (Postfix) with ESMTP id 61C889C1BAC;\n\tMon, 28 Aug 2017 15:21:38 -0400 (EDT)","from mail.savoirfairelinux.com ([127.0.0.1])\n\tby localhost (mail.savoirfairelinux.com [127.0.0.1]) (amavisd-new,\n\tport 10026)\n\twith ESMTP id KSG4TE4fd4-P; Mon, 28 Aug 2017 15:21:38 -0400 (EDT)","from weeman.mtl.sfl (unknown [192.168.50.91])\n\tby mail.savoirfairelinux.com (Postfix) with ESMTPSA id E73039C1BC9;\n\tMon, 28 Aug 2017 15:21:37 -0400 (EDT)"],"X-Virus-Scanned":"amavisd-new at mail.savoirfairelinux.com","From":"Vivien Didelot ","To":"netdev@vger.kernel.org","Cc":"linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com,\n\t\"David S. Miller\" ,\n\tFlorian Fainelli , Andrew Lunn ,\n\tEgil Hjelmeland ,\n\tJohn Crispin , Woojung Huh ,\n\tSean Wang ,\n\tNikita Yushchenko ,\n\tChris Healy ,\n\tVivien Didelot ","Subject":"[PATCH net-next v2 10/10] net: dsa: debugfs: add port vlan","Date":"Mon, 28 Aug 2017 15:17:48 -0400","Message-Id":"<20170828191748.19492-11-vivien.didelot@savoirfairelinux.com>","X-Mailer":"git-send-email 2.14.1","In-Reply-To":"<20170828191748.19492-1-vivien.didelot@savoirfairelinux.com>","References":"<20170828191748.19492-1-vivien.didelot@savoirfairelinux.com>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"Add a debug filesystem \"vlan\" entry to query a port's hardware VLAN\nentries through the .port_vlan_dump switch operation.\n\nThis is really convenient to query directly the hardware or inspect DSA\nor CPU links, since these ports are not exposed to userspace.\n\nHere are the VLAN entries for a CPU port:\n\n # cat port5/vlan\n vid 1 untagged pvid\n vid 42 tagged\n\nSigned-off-by: Vivien Didelot \nReviewed-by: Florian Fainelli \nReviewed-by: Andrew Lunn \n---\n net/dsa/debugfs.c | 29 +++++++++++++++++++++++++++++\n 1 file changed, 29 insertions(+)","diff":"diff --git a/net/dsa/debugfs.c b/net/dsa/debugfs.c\nindex bed8e1d5cfe1..40fe19872ab1 100644\n--- a/net/dsa/debugfs.c\n+++ b/net/dsa/debugfs.c\n@@ -250,6 +250,30 @@ static const struct dsa_debugfs_ops dsa_debugfs_tree_ops = {\n \t.read = dsa_debugfs_tree_read,\n };\n \n+static int dsa_debugfs_vlan_dump_cb(u16 vid, bool pvid, bool untagged,\n+\t\t\t\t void *data)\n+{\n+\tstruct seq_file *seq = data;\n+\n+\tseq_printf(seq, \"vid %d %s %s\\n\", vid,\n+\t\t untagged ? \"untagged\" : \"tagged\", pvid ? \"pvid\" : \"\");\n+\n+\treturn 0;\n+}\n+\n+static int dsa_debugfs_vlan_read(struct dsa_switch *ds, int id,\n+\t\t\t\t struct seq_file *seq)\n+{\n+\tif (!ds->ops->port_vlan_dump)\n+\t\treturn -EOPNOTSUPP;\n+\n+\treturn ds->ops->port_vlan_dump(ds, id, dsa_debugfs_vlan_dump_cb, seq);\n+}\n+\n+static const struct dsa_debugfs_ops dsa_debugfs_vlan_ops = {\n+\t.read = dsa_debugfs_vlan_read,\n+};\n+\n static int dsa_debugfs_create_port(struct dsa_switch *ds, int port)\n {\n \tstruct dentry *dir;\n@@ -282,6 +306,11 @@ static int dsa_debugfs_create_port(struct dsa_switch *ds, int port)\n \tif (err)\n \t\treturn err;\n \n+\terr = dsa_debugfs_create_file(ds, dir, \"vlan\", port,\n+\t\t\t\t &dsa_debugfs_vlan_ops);\n+\tif (err)\n+\t\treturn err;\n+\n \treturn 0;\n }\n \n","prefixes":["net-next","v2","10/10"]}