{"id":806733,"url":"http://patchwork.ozlabs.org/api/1.0/patches/806733/?format=json","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.0/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20170828190738.26829-2-aring@mojatatu.com>","date":"2017-08-28T19:07:35","name":"[iproute2,1/4] tc: m_ife: allow ife type to zero","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"df8fd5a5c150e488d68930718f11294b4cc51628","submitter":{"id":72245,"url":"http://patchwork.ozlabs.org/api/1.0/people/72245/?format=json","name":"Alexander Aring","email":"aring@mojatatu.com"},"delegate":{"id":389,"url":"http://patchwork.ozlabs.org/api/1.0/users/389/?format=json","username":"shemminger","first_name":"stephen","last_name":"hemminger","email":"shemminger@vyatta.com"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20170828190738.26829-2-aring@mojatatu.com/mbox/","series":[{"id":244,"url":"http://patchwork.ozlabs.org/api/1.0/series/244/?format=json","date":"2017-08-28T19:07:34","name":"tc: m_ife: handle IFE ethertype value","version":1,"mbox":"http://patchwork.ozlabs.org/series/244/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/806733/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=mojatatu-com.20150623.gappssmtp.com\n\theader.i=@mojatatu-com.20150623.gappssmtp.com\n\theader.b=\"0NwJ/Fd5\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xh1XG0bgcz9sNc\n\tfor ;\n\tTue, 29 Aug 2017 05:09:02 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751646AbdH1TIt (ORCPT );\n\tMon, 28 Aug 2017 15:08:49 -0400","from mail-io0-f193.google.com ([209.85.223.193]:36221 \"EHLO\n\tmail-io0-f193.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751488AbdH1TIq (ORCPT\n\t); Mon, 28 Aug 2017 15:08:46 -0400","by mail-io0-f193.google.com with SMTP id v96so1096913ioi.3\n\tfor ; Mon, 28 Aug 2017 12:08:46 -0700 (PDT)","from x220t.lan ([64.26.149.125]) by smtp.gmail.com with ESMTPSA id\n\tm192sm40144itb.14.2017.08.28.12.08.44\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 28 Aug 2017 12:08:44 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=mojatatu-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=9ZU24b0ZfQfTyw2vOViKy1MmoBCaL5wvC2xp7jeWgPw=;\n\tb=0NwJ/Fd51nszSMptoYX5V8NL9xVN5VJIasm2+GRfrmIX1kVSJwkU8yWcMzUkZFMpEZ\n\tvVqv/l2vfaSU4H/a3hkC24iJE5RzCa6rtUj9ryfjrGeBxyoYJ4+D17LcPUDCOQWK/gFR\n\tD6lvZUwVs+xe0DI9blluWOe0lQFXcOTsVr9IqIsTGrNC6hB1cytSOs1FMd3qkB5TfwA6\n\tUPHCnhXVPkaOSLzvNH3gtT3fHFILpr/ovXT8z+oe/t5yNe3HA2qXZOKAi4slZFBgJa0o\n\txOVBftIEf2BSXfzqHFimtAO5I15uidLEJAWMhaFwblASxUpOkzMIkFmEV4kjrQNYKMqw\n\tHqdQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=9ZU24b0ZfQfTyw2vOViKy1MmoBCaL5wvC2xp7jeWgPw=;\n\tb=nyyU8lGmNS/LoB6DRkQHJ2hAoGgh8xB0P69gFFC+w2Me9P6sJsYvwkKlNavW59UpFD\n\tWPoehITkxQatvfRnBthC/RCtxyVJ6tX0dL1gBoPU2PU7/5lGyMik936xFmG++eYVDWmP\n\teEGQn7wUYkPlHTsmsUZPakRB+xlwr+qG+tA9tAs8wHCWaKO+CezzUT8rCbR6ZiMQgPP4\n\tzQyKRr/iGQCwA+WQs1o5TNz5Il9BjuLkD9FlT25IhZ8yAv3tZFxbfDZO/pKM9bq/JDN/\n\t2atR/5UFMRCqvPMAJZfwxyF/w6IPl6oa1c11/TIFjJwkGtMlHt0X3Ch8Vo6BbBIxCTYA\n\tOWZw==","X-Gm-Message-State":"AHYfb5jzuTf7VUglDSrwMW4tmdmvaCRaG/sNMVHHtLfOweGPCmpj+ET6\n\t3xF7zI/oticdTpnv","X-Received":"by 10.107.157.78 with SMTP id g75mr1605636ioe.190.1503947326123; \n\tMon, 28 Aug 2017 12:08:46 -0700 (PDT)","From":"Alexander Aring ","To":"jhs@mojatatu.com","Cc":"yotamg@mellanox.com, xiyou.wangcong@gmail.com, jiri@resnulli.us,\n\tnetdev@vger.kernel.org, Alexander Aring ","Subject":"[PATCH iproute2 1/4] tc: m_ife: allow ife type to zero","Date":"Mon, 28 Aug 2017 15:07:35 -0400","Message-Id":"<20170828190738.26829-2-aring@mojatatu.com>","X-Mailer":"git-send-email 2.11.0","In-Reply-To":"<20170828190738.26829-1-aring@mojatatu.com>","References":"<20170828190738.26829-1-aring@mojatatu.com>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"This patch allows to set an ethertype for IFE which is zero. There is no\nkernel side validation which forbids a type to zero.\n\nSigned-off-by: Alexander Aring \n---\n tc/m_ife.c | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)","diff":"diff --git a/tc/m_ife.c b/tc/m_ife.c\nindex e3521e62..e05e2276 100644\n--- a/tc/m_ife.c\n+++ b/tc/m_ife.c\n@@ -63,6 +63,7 @@ static int parse_ife(struct action_util *a, int *argc_p, char ***argv_p,\n \tchar dbuf[ETH_ALEN];\n \tchar sbuf[ETH_ALEN];\n \t__u16 ife_type = 0;\n+\tint user_type = 0;\n \t__u32 ife_prio = 0;\n \t__u32 ife_prio_v = 0;\n \t__u32 ife_mark = 0;\n@@ -125,6 +126,7 @@ static int parse_ife(struct action_util *a, int *argc_p, char ***argv_p,\n \t\t\tif (get_u16(&ife_type, *argv, 0))\n \t\t\t\tinvarg(\"ife type is invalid\", *argv);\n \t\t\tfprintf(stderr, \"IFE type 0x%x\\n\", ife_type);\n+\t\t\tuser_type = 1;\n \t\t} else if (matches(*argv, \"dst\") == 0) {\n \t\t\tNEXT_ARG();\n \t\t\tdaddr = *argv;\n@@ -185,7 +187,7 @@ static int parse_ife(struct action_util *a, int *argc_p, char ***argv_p,\n \n \tif (daddr)\n \t\taddattr_l(n, MAX_MSG, TCA_IFE_DMAC, dbuf, ETH_ALEN);\n-\tif (ife_type)\n+\tif (user_type)\n \t\taddattr_l(n, MAX_MSG, TCA_IFE_TYPE, &ife_type, 2);\n \tif (saddr)\n \t\taddattr_l(n, MAX_MSG, TCA_IFE_SMAC, sbuf, ETH_ALEN);\n","prefixes":["iproute2","1/4"]}