{"id":806722,"url":"http://patchwork.ozlabs.org/api/1.0/patches/806722/?format=json","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.0/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<1503946718-23973-1-git-send-email-agust@denx.de>","date":"2017-08-28T18:58:38","name":"[U-Boot] imx6: drop duplicated bss memset and board_init_r() call","commit_ref":"30df9f770b22f3c89d61947950da362117c43c63","pull_url":null,"state":"accepted","archived":false,"hash":"1a2b087ea80e87d64b47d45406634bdf9ffee00b","submitter":{"id":872,"url":"http://patchwork.ozlabs.org/api/1.0/people/872/?format=json","name":"Anatolij Gustschin","email":"agust@denx.de"},"delegate":{"id":1693,"url":"http://patchwork.ozlabs.org/api/1.0/users/1693/?format=json","username":"sbabic","first_name":"Stefano","last_name":"Babic","email":"sbabic@denx.de"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/1503946718-23973-1-git-send-email-agust@denx.de/mbox/","series":[{"id":241,"url":"http://patchwork.ozlabs.org/api/1.0/series/241/?format=json","date":"2017-08-28T18:58:38","name":"[U-Boot] imx6: drop duplicated bss memset and board_init_r() call","version":1,"mbox":"http://patchwork.ozlabs.org/series/241/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/806722/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xh1Jc405Zz9s9Y\n\tfor ;\n\tTue, 29 Aug 2017 04:58:54 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 93EFFC225FF; Mon, 28 Aug 2017 18:58:34 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 20D32C22565;\n\tMon, 28 Aug 2017 18:58:31 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 82AF0C22565; Mon, 28 Aug 2017 18:58:28 +0000 (UTC)","from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9])\n\tby lists.denx.de (Postfix) with ESMTPS id 2BDA1C2254A\n\tfor ; Mon, 28 Aug 2017 18:58:28 +0000 (UTC)","from frontend01.mail.m-online.net (unknown [192.168.8.182])\n\tby mail-out.m-online.net (Postfix) with ESMTP id 3xh1J349Wbz1rCgj;\n\tMon, 28 Aug 2017 20:58:27 +0200 (CEST)","from localhost (dynscan1.mnet-online.de [192.168.6.70])\n\tby mail.m-online.net (Postfix) with ESMTP id 3xh1J32Ft0z3jgYb;\n\tMon, 28 Aug 2017 20:58:27 +0200 (CEST)","from mail.mnet-online.de ([192.168.8.182])\n\tby localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id kgMJfET1x4HP; Mon, 28 Aug 2017 20:58:25 +0200 (CEST)","from crub.agik.hopto.org (p4FCB44C5.dip0.t-ipconnect.de\n\t[79.203.68.197]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mail.mnet-online.de (Postfix) with ESMTPSA;\n\tMon, 28 Aug 2017 20:58:25 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,\n\tRCVD_IN_MSPIKE_H3,\n\tRCVD_IN_MSPIKE_WL autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","X-Virus-Scanned":"amavisd-new at mnet-online.de","X-Auth-Info":"75j8xzRnEWoQOLO9lxoHxFZaNRs7cpt8ZXI7ANYx+AM=","From":"Anatolij Gustschin ","To":"u-boot@lists.denx.de","Date":"Mon, 28 Aug 2017 20:58:38 +0200","Message-Id":"<1503946718-23973-1-git-send-email-agust@denx.de>","X-Mailer":"git-send-email 2.7.4","Cc":"Marek Vasut , Fabio Estevam ","Subject":"[U-Boot] [PATCH] imx6: drop duplicated bss memset and\n\tboard_init_r() call","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "},"content":"bss section is cleared in crt0.S. board_init_r() is also\nentered from crt0 code.\n\nSigned-off-by: Anatolij Gustschin \nCc: Christian Gmeiner \nCc: Nikita Kiryanov \nCc: Jagan Teki \nCc: Tim Harvey \nCc: Marek Vasut \nCc: Lukasz Majewski \nCc: Fabio Estevam \n---\n board/bachmann/ot1200/ot1200_spl.c | 6 ------\n board/compulab/cm_fx6/spl.c | 3 ---\n board/engicam/common/spl.c | 6 ------\n board/gateworks/gw_ventana/gw_ventana_spl.c | 3 ---\n board/kosagi/novena/novena_spl.c | 6 ------\n board/liebherr/mccmon6/spl.c | 6 ------\n board/udoo/udoo_spl.c | 6 ------\n board/wandboard/spl.c | 6 ------\n 8 files changed, 42 deletions(-)","diff":"diff --git a/board/bachmann/ot1200/ot1200_spl.c b/board/bachmann/ot1200/ot1200_spl.c\nindex 9d28da4..f3dff95 100644\n--- a/board/bachmann/ot1200/ot1200_spl.c\n+++ b/board/bachmann/ot1200/ot1200_spl.c\n@@ -151,10 +151,4 @@ void board_init_f(ulong dummy)\n \n \t/* configure MMDC for SDRAM width/size and per-model calibration */\n \tot1200_spl_dram_init();\n-\n-\t/* Clear the BSS. */\n-\tmemset(__bss_start, 0, __bss_end - __bss_start);\n-\n-\t/* load/boot image from boot device */\n-\tboard_init_r(NULL, 0);\n }\ndiff --git a/board/compulab/cm_fx6/spl.c b/board/compulab/cm_fx6/spl.c\nindex bba977f..56aac60 100644\n--- a/board/compulab/cm_fx6/spl.c\n+++ b/board/compulab/cm_fx6/spl.c\n@@ -336,9 +336,6 @@ void board_init_f(ulong dummy)\n \t\tputs(\"!!!ERROR!!! DRAM detection failed!!!\\n\");\n \t\thang();\n \t}\n-\n-\tmemset(__bss_start, 0, __bss_end - __bss_start);\n-\tboard_init_r(NULL, 0);\n }\n \n void board_boot_order(u32 *spl_boot_list)\ndiff --git a/board/engicam/common/spl.c b/board/engicam/common/spl.c\nindex a8a7cf3..1f2826a 100644\n--- a/board/engicam/common/spl.c\n+++ b/board/engicam/common/spl.c\n@@ -384,10 +384,4 @@ void board_init_f(ulong dummy)\n \n \t/* DDR initialization */\n \tspl_dram_init();\n-\n-\t/* Clear the BSS. */\n-\tmemset(__bss_start, 0, __bss_end - __bss_start);\n-\n-\t/* load/boot image from boot device */\n-\tboard_init_r(NULL, 0);\n }\ndiff --git a/board/gateworks/gw_ventana/gw_ventana_spl.c b/board/gateworks/gw_ventana/gw_ventana_spl.c\nindex 9524da7..e107f15 100644\n--- a/board/gateworks/gw_ventana/gw_ventana_spl.c\n+++ b/board/gateworks/gw_ventana/gw_ventana_spl.c\n@@ -637,9 +637,6 @@ void board_init_f(ulong dummy)\n \tspl_dram_init(8 << ventana_info.sdram_width,\n \t\t 16 << ventana_info.sdram_size,\n \t\t board_model);\n-\n-\t/* Clear the BSS. */\n-\tmemset(__bss_start, 0, __bss_end - __bss_start);\n }\n \n void board_boot_order(u32 *spl_boot_list)\ndiff --git a/board/kosagi/novena/novena_spl.c b/board/kosagi/novena/novena_spl.c\nindex 3645b75..ffc99b8 100644\n--- a/board/kosagi/novena/novena_spl.c\n+++ b/board/kosagi/novena/novena_spl.c\n@@ -607,10 +607,4 @@ void board_init_f(ulong dummy)\n \tudelay(100);\n \tmmdc_do_write_level_calibration(&novena_ddr_info);\n \tmmdc_do_dqs_calibration(&novena_ddr_info);\n-\n-\t/* Clear the BSS. */\n-\tmemset(__bss_start, 0, __bss_end - __bss_start);\n-\n-\t/* load/boot image from boot device */\n-\tboard_init_r(NULL, 0);\n }\ndiff --git a/board/liebherr/mccmon6/spl.c b/board/liebherr/mccmon6/spl.c\nindex 15844ef..56e7d3b 100644\n--- a/board/liebherr/mccmon6/spl.c\n+++ b/board/liebherr/mccmon6/spl.c\n@@ -307,11 +307,5 @@ void board_init_f(ulong dummy)\n \n \t/* DDR initialization */\n \tspl_dram_init();\n-\n-\t/* Clear the BSS. */\n-\tmemset(__bss_start, 0, __bss_end - __bss_start);\n-\n-\t/* load/boot image from boot device */\n-\tboard_init_r(NULL, 0);\n }\n #endif\ndiff --git a/board/udoo/udoo_spl.c b/board/udoo/udoo_spl.c\nindex e83e7c3..34ef413 100644\n--- a/board/udoo/udoo_spl.c\n+++ b/board/udoo/udoo_spl.c\n@@ -263,11 +263,5 @@ void board_init_f(ulong dummy)\n \n \t/* DDR initialization */\n \tspl_dram_init();\n-\n-\t/* Clear the BSS. */\n-\tmemset(__bss_start, 0, __bss_end - __bss_start);\n-\n-\t/* load/boot image from boot device */\n-\tboard_init_r(NULL, 0);\n }\n #endif\ndiff --git a/board/wandboard/spl.c b/board/wandboard/spl.c\nindex 47082a8..c3f5fff 100644\n--- a/board/wandboard/spl.c\n+++ b/board/wandboard/spl.c\n@@ -311,11 +311,5 @@ void board_init_f(ulong dummy)\n \n \t/* DDR initialization */\n \tspl_dram_init();\n-\n-\t/* Clear the BSS. */\n-\tmemset(__bss_start, 0, __bss_end - __bss_start);\n-\n-\t/* load/boot image from boot device */\n-\tboard_init_r(NULL, 0);\n }\n #endif\n","prefixes":["U-Boot"]}