{"id":806675,"url":"http://patchwork.ozlabs.org/api/1.0/patches/806675/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<1503941985-25657-1-git-send-email-thuth@redhat.com>","date":"2017-08-28T17:39:45","name":"[for-2.11] tests/bios-tables: Silence some messages with V=1, print them with V=2 only","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"093c99211e92e75b64592ff84afef36378d3f665","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/1.0/people/66152/?format=json","name":"Thomas Huth","email":"thuth@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/1503941985-25657-1-git-send-email-thuth@redhat.com/mbox/","series":[{"id":224,"url":"http://patchwork.ozlabs.org/api/1.0/series/224/?format=json","date":"2017-08-28T17:39:45","name":"[for-2.11] tests/bios-tables: Silence some messages with V=1, print them with V=2 only","version":1,"mbox":"http://patchwork.ozlabs.org/series/224/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/806675/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xgzZB3X8jz9sMN\n\tfor ;\n\tTue, 29 Aug 2017 03:40:29 +1000 (AEST)","from localhost ([::1]:40822 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dmO1N-0003OG-Vm\n\tfor incoming@patchwork.ozlabs.org; Mon, 28 Aug 2017 13:40:22 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:59246)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dmO0w-0003Ns-FC\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 13:39:55 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dmO0t-0005O7-Bh\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 13:39:54 -0400","from mx1.redhat.com ([209.132.183.28]:48346)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dmO0t-0005Nx-5d; Mon, 28 Aug 2017 13:39:51 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id DB8C94ACB5;\n\tMon, 28 Aug 2017 17:39:49 +0000 (UTC)","from thh440s.redhat.com (ovpn-116-110.ams2.redhat.com\n\t[10.36.116.110])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id C33E081890;\n\tMon, 28 Aug 2017 17:39:46 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com DB8C94ACB5","From":"Thomas Huth ","To":"qemu-devel@nongnu.org, Igor Mammedov ,\n\t\"Michael S. Tsirkin\" ","Date":"Mon, 28 Aug 2017 19:39:45 +0200","Message-Id":"<1503941985-25657-1-git-send-email-thuth@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tMon, 28 Aug 2017 17:39:50 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH for-2.11] tests/bios-tables: Silence some\n\tmessages with V=1, print them with V=2 only","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-trivial@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"When running \"make check-qtest-x86_64 V=1\", the output is currently flooded\nwith \"Looking for expected file ...\" and \"Using expected file ...\" messages.\nNone of the other tests is doing that with V=1, so this is a little bit\nannoying. Let's only print these debug messages when we're running the test\nwith V=2 or higher.\n\nSigned-off-by: Thomas Huth \n---\n tests/bios-tables-test.c | 10 ++++++++--\n 1 file changed, 8 insertions(+), 2 deletions(-)","diff":"diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c\nindex 564da45..289ee45 100644\n--- a/tests/bios-tables-test.c\n+++ b/tests/bios-tables-test.c\n@@ -40,6 +40,7 @@ typedef struct {\n int required_struct_types_len;\n } test_data;\n \n+static bool really_verbose;\n static char disk[] = \"tests/acpi-test-disk-XXXXXX\";\n static const char *data_dir = \"tests/acpi-test-data\";\n #ifdef CONFIG_IASL\n@@ -395,7 +396,7 @@ static GArray *load_expected_aml(test_data *data)\n try_again:\n aml_file = g_strdup_printf(\"%s/%s/%.4s%s\", data_dir, data->machine,\n (gchar *)&signature, ext);\n- if (getenv(\"V\")) {\n+ if (really_verbose) {\n fprintf(stderr, \"\\nLooking for expected file '%s'\\n\", aml_file);\n }\n if (g_file_test(aml_file, G_FILE_TEST_EXISTS)) {\n@@ -407,7 +408,7 @@ try_again:\n goto try_again;\n }\n g_assert(exp_sdt.aml_file);\n- if (getenv(\"V\")) {\n+ if (really_verbose) {\n fprintf(stderr, \"\\nUsing expected file '%s'\\n\", aml_file);\n }\n ret = g_file_get_contents(aml_file, &exp_sdt.aml,\n@@ -812,6 +813,11 @@ int main(int argc, char *argv[])\n {\n const char *arch = qtest_get_arch();\n int ret;\n+ const char *v_env = getenv(\"V\");\n+\n+ if (v_env && *v_env >= '2') {\n+ really_verbose = true;\n+ }\n \n ret = boot_sector_init(disk);\n if(ret)\n","prefixes":["for-2.11"]}