{"id":806623,"url":"http://patchwork.ozlabs.org/api/1.0/patches/806623/?format=json","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.0/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20170828145725.2539-9-antoine.tenart@free-electrons.com>","date":"2017-08-28T14:57:20","name":"[net-next,v3,08/13] net: mvpp2: dynamic reconfiguration of the comphy/GoP/MAC","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":true,"hash":"25adee1e6331cfe16cb18ce71c44486202a4fd61","submitter":{"id":61603,"url":"http://patchwork.ozlabs.org/api/1.0/people/61603/?format=json","name":"Antoine Tenart","email":"antoine.tenart@free-electrons.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/1.0/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20170828145725.2539-9-antoine.tenart@free-electrons.com/mbox/","series":[{"id":187,"url":"http://patchwork.ozlabs.org/api/1.0/series/187/?format=json","date":"2017-08-28T14:57:14","name":"net: mvpp2: comphy configuration","version":3,"mbox":"http://patchwork.ozlabs.org/series/187/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/806623/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xgw4b0Tw3z9s9Y\n\tfor ;\n\tTue, 29 Aug 2017 01:03:11 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751698AbdH1O5s (ORCPT );\n\tMon, 28 Aug 2017 10:57:48 -0400","from mail.free-electrons.com ([62.4.15.54]:55647 \"EHLO\n\tmail.free-electrons.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751564AbdH1O5q (ORCPT\n\t); Mon, 28 Aug 2017 10:57:46 -0400","by mail.free-electrons.com (Postfix, from userid 110)\n\tid CF9E920A19; Mon, 28 Aug 2017 16:57:43 +0200 (CEST)","from localhost (nat.foo.tf [163.172.35.26])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id 9D38820A1A;\n\tMon, 28 Aug 2017 16:57:33 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0","From":"Antoine Tenart ","To":"davem@davemloft.net, kishon@ti.com, andrew@lunn.ch,\n\tjason@lakedaemon.net, sebastian.hesselbarth@gmail.com,\n\tgregory.clement@free-electrons.com","Cc":"Antoine Tenart ,\n\tthomas.petazzoni@free-electrons.com, nadavh@marvell.com,\n\tlinux@armlinux.org.uk, linux-kernel@vger.kernel.org,\n\tmw@semihalf.com, stefanc@marvell.com,\n\tmiquel.raynal@free-electrons.com, netdev@vger.kernel.org","Subject":"[PATCH net-next v3 08/13] net: mvpp2: dynamic reconfiguration of\n\tthe comphy/GoP/MAC","Date":"Mon, 28 Aug 2017 16:57:20 +0200","Message-Id":"<20170828145725.2539-9-antoine.tenart@free-electrons.com>","X-Mailer":"git-send-email 2.13.5","In-Reply-To":"<20170828145725.2539-1-antoine.tenart@free-electrons.com>","References":"<20170828145725.2539-1-antoine.tenart@free-electrons.com>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"This patch adds logic to reconfigure the comphy/GoP/MAC when the link\nstate is updated at runtime. This is very useful on boards where many\nlink speed are supported: depending on what is negotiated the PPv2\ndriver will automatically reconfigures the link between the PHY and the\nMAC.\n\nSigned-off-by: Antoine Tenart \n---\n drivers/net/ethernet/marvell/mvpp2.c | 21 ++++++++++++++++++++-\n 1 file changed, 20 insertions(+), 1 deletion(-)","diff":"diff --git a/drivers/net/ethernet/marvell/mvpp2.c b/drivers/net/ethernet/marvell/mvpp2.c\nindex 2f05a0b0773c..9e64b1ba3d43 100644\n--- a/drivers/net/ethernet/marvell/mvpp2.c\n+++ b/drivers/net/ethernet/marvell/mvpp2.c\n@@ -5771,9 +5771,28 @@ static void mvpp2_link_event(struct net_device *dev)\n {\n \tstruct mvpp2_port *port = netdev_priv(dev);\n \tstruct phy_device *phydev = dev->phydev;\n+\tbool link_reconfigured = false;\n \tu32 val;\n \n \tif (phydev->link) {\n+\t\tif (port->phy_interface != phydev->interface && port->comphy) {\n+\t /* disable current port for reconfiguration */\n+\t mvpp2_interrupts_disable(port);\n+\t netif_carrier_off(port->dev);\n+\t mvpp2_port_disable(port);\n+\t\t\tphy_power_off(port->comphy);\n+\n+\t /* comphy reconfiguration */\n+\t port->phy_interface = phydev->interface;\n+\t mvpp22_comphy_init(port);\n+\n+\t /* gop/mac reconfiguration */\n+\t mvpp22_gop_init(port);\n+\t mvpp2_port_mii_set(port);\n+\n+\t link_reconfigured = true;\n+\t\t}\n+\n \t\tif ((port->speed != phydev->speed) ||\n \t\t (port->duplex != phydev->duplex)) {\n \t\t\tmvpp2_gmac_set_autoneg(port, phydev);\n@@ -5783,7 +5802,7 @@ static void mvpp2_link_event(struct net_device *dev)\n \t\t}\n \t}\n \n-\tif (phydev->link != port->link) {\n+\tif (phydev->link != port->link || link_reconfigured) {\n \t\tport->link = phydev->link;\n \n \t\tif (phydev->link) {\n","prefixes":["net-next","v3","08/13"]}