{"id":806584,"url":"http://patchwork.ozlabs.org/api/1.0/patches/806584/?format=json","project":{"id":17,"url":"http://patchwork.ozlabs.org/api/1.0/projects/17/?format=json","name":"GNU Compiler Collection","link_name":"gcc","list_id":"gcc-patches.gcc.gnu.org","list_email":"gcc-patches@gcc.gnu.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"","date":"2017-08-28T13:51:19","name":"small gcc.c cleanup","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"9a80cb21a25a7ad5acf693eeec4bff4321c1a6ec","submitter":{"id":9970,"url":"http://patchwork.ozlabs.org/api/1.0/people/9970/?format=json","name":"Nathan Sidwell","email":"nathan@acm.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/gcc/patch/fedd15b1-7313-3d84-b913-83679e5717be@acm.org/mbox/","series":[{"id":173,"url":"http://patchwork.ozlabs.org/api/1.0/series/173/?format=json","date":"2017-08-28T13:51:19","name":"small gcc.c cleanup","version":1,"mbox":"http://patchwork.ozlabs.org/series/173/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/806584/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list gcc-patches@gcc.gnu.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=gcc-patches-return-461019-incoming=patchwork.ozlabs.org@gcc.gnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org\n\theader.b=\"Us1nK2ja\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xgtV10MM2z9sNq\n\tfor ;\n\tMon, 28 Aug 2017 23:51:36 +1000 (AEST)","(qmail 129273 invoked by alias); 28 Aug 2017 13:51:28 -0000","(qmail 127837 invoked by uid 89); 28 Aug 2017 13:51:25 -0000","from mail-yw0-f182.google.com (HELO mail-yw0-f182.google.com)\n\t(209.85.161.182) by sourceware.org\n\t(qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP;\n\tMon, 28 Aug 2017 13:51:23 +0000","by mail-yw0-f182.google.com with SMTP id s143so2769981ywg.0 for\n\t; Mon, 28 Aug 2017 06:51:23 -0700 (PDT)","from ?IPv6:2620:10d:c0a3:20fb:7500:e7fb:4a6f:2254?\n\t([2620:10d:c091:200::1:d19a]) by smtp.googlemail.com with\n\tESMTPSA id q125sm165478ywg.34.2017.08.28.06.51.20\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256\n\tbits=128/128); Mon, 28 Aug 2017 06:51:21 -0700 (PDT)"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender:to\n\t:from:subject:message-id:date:mime-version:content-type; q=dns;\n\ts=default; b=AvF1IQn2n45nFjO0cJXWClKz25BZuPx8PZP25c/UL43Hg78dOY\n\tMhTaVleYMNsJm5s5j4KwQ1kJOUClZDuqh5ZRq3kw6LIVdFxgIQBHu7QOkH1OO7tr\n\ttRhNxX8ISKIDhMKG1gh8859ZtDqtKhlzxsvuq3tcxOGGJUn7p++ygOL2Y=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender:to\n\t:from:subject:message-id:date:mime-version:content-type; s=\n\tdefault; bh=jGekrWjducK2E7NZPYOuBHZdcVQ=; b=Us1nK2jaXKEsh6m3N9cm\n\tcNRYI8yOQ9/OXu3OAvcOPqtif5MUQMKMJRmL/HqXfnbqquPwVs9MAKUJKFE+l4PX\n\tXDXveXJXgby7431hUXZewNyhmCsG4nye+PfLjQ6vg0RaToQ58oOzO3AKsNeY14Ra\n\tixr3gcepAedPr3Tw6+rIXWU=","Mailing-List":"contact gcc-patches-help@gcc.gnu.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Archive":"","List-Post":"","List-Help":"","Sender":"gcc-patches-owner@gcc.gnu.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-11.9 required=5.0 tests=BAYES_00,\n\tFREEMAIL_FROM, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE,\n\tSPF_PASS autolearn=ham version=3.3.2 spammy=killer, sidwell,\n\tSidwell","X-HELO":"mail-yw0-f182.google.com","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net;\n\ts=20161025;\n\th=x-gm-message-state:sender:to:from:subject:message-id:date\n\t:user-agent:mime-version:content-language;\n\tbh=VtlNQYzVMVjdV/iLhapzpADtyi9lJOb61Ccza82vRtE=;\n\tb=ZsvwC66i99D5cmlKsQZylMDwXjin3ZXcnO1PuyiDAtIUA4nPJvmm0kXhgq2tzFMFk4\n\tx3ZNiT/c4XCw5Drrp+AGFuD2LUrJxtYTtMwX7eSGfHPKY42oWeILYRl0WWzozo/JYJkh\n\tNimn5M6cDNtWOxD+cgrnz0++s/3Fq/tzObFpFi/+mwk9coHU7gn6STA2PNXhfjhzWV3f\n\txrm4yhnLXaTL/wYSPQ45joPsTzs4oy08ZZDSQ/e/mzHdxl63AZ7j8xqHTf4K5+3rtiWU\n\tXqyIETOMzo452U3pltfakVljjyzQypsB194xwgW4Cuow11SYgdm/MNDbVVvkLmqQkNRy\n\tx7jA==","X-Gm-Message-State":"AHYfb5i88prhjqoupHrhQaUdzfP5iVxr3DbL9tAPvjAojjr1PFqq3mWE\tjjXwbIpuN/8YTw==","X-Received":"by 10.37.17.6 with SMTP id 6mr554663ybr.312.1503928281860;\n\tMon, 28 Aug 2017 06:51:21 -0700 (PDT)","To":"GCC Patches ","From":"Nathan Sidwell ","Subject":"[PATCH] small gcc.c cleanup","Message-ID":"","Date":"Mon, 28 Aug 2017 09:51:19 -0400","User-Agent":"Mozilla/5.0 (X11; Linux x86_64;\n\trv:52.0) Gecko/20100101 Thunderbird/52.2.1","MIME-Version":"1.0","Content-Type":"multipart/mixed;\n\tboundary=\"------------DE7EA8D2C38C0A571F8E2325\""},"content":"I committed this update to my post of \nhttps://gcc.gnu.org/ml/gcc-patches/2017-08/msg01011.html, deciding it \nnow sufficiently obvious :)\n\nnathan","diff":"2017-08-28 Nathan Sidwell \n\n\t* gcc.c (execute): Fold SIGPIPE handling into switch\n\tstatement. Adjust internal error message.\n\nIndex: gcc.c\n===================================================================\n--- gcc.c\t(revision 251380)\n+++ gcc.c\t(working copy)\n@@ -3135,49 +3135,50 @@ execute (void)\n \tint status = statuses[i];\n \n \tif (WIFSIGNALED (status))\n-\t {\n-#ifdef SIGPIPE\n-\t /* SIGPIPE is a special case. It happens in -pipe mode\n-\t when the compiler dies before the preprocessor is done,\n-\t or the assembler dies before the compiler is done.\n-\t There's generally been an error already, and this is\n-\t just fallout. So don't generate another error unless\n-\t we would otherwise have succeeded. */\n-\t if (WTERMSIG (status) == SIGPIPE\n-\t\t&& (signal_count || greatest_status >= MIN_FATAL_STATUS))\n-\t {\n-\t\tsignal_count++;\n-\t\tret_code = -1;\n-\t }\n-\t else\n-#endif\n-\t switch (WTERMSIG (status))\n-\t\t{\n-\t\tcase SIGINT:\n-\t\t/* SIGQUIT and SIGKILL are not available on MinGW. */\n+\t switch (WTERMSIG (status))\n+\t {\n+\t case SIGINT:\n+\t case SIGTERM:\n+\t /* SIGQUIT and SIGKILL are not available on MinGW. */\n #ifdef SIGQUIT\n-\t\tcase SIGQUIT:\n+\t case SIGQUIT:\n #endif\n #ifdef SIGKILL\n-\t\tcase SIGKILL:\n+\t case SIGKILL:\n #endif\n-\t\tcase SIGTERM:\n-\t\t /* The user (or environment) did something to the\n-\t\t inferior. Making this an ICE confuses the user\n-\t\t into thinking there's a compiler bug. Much more\n-\t\t likely is the user or OOM killer nuked it. */\n-\t\t fatal_error (input_location,\n-\t\t\t \"%s signal terminated program %s\",\n-\t\t\t strsignal (WTERMSIG (status)),\n-\t\t\t commands[i].prog);\n+\t /* The user (or environment) did something to the\n+\t\t inferior. Making this an ICE confuses the user into\n+\t\t thinking there's a compiler bug. Much more likely is\n+\t\t the user or OOM killer nuked it. */\n+\t fatal_error (input_location,\n+\t\t\t \"%s signal terminated program %s\",\n+\t\t\t strsignal (WTERMSIG (status)),\n+\t\t\t commands[i].prog);\n+\t break;\n+\n+#ifdef SIGPIPE\n+\t case SIGPIPE:\n+\t /* SIGPIPE is a special case. It happens in -pipe mode\n+\t\t when the compiler dies before the preprocessor is\n+\t\t done, or the assembler dies before the compiler is\n+\t\t done. There's generally been an error already, and\n+\t\t this is just fallout. So don't generate another\n+\t\t error unless we would otherwise have succeeded. */\n+\t if (signal_count || greatest_status >= MIN_FATAL_STATUS)\n+\t\t{\n+\t\t signal_count++;\n+\t\t ret_code = -1;\n \t\t break;\n-\t\tdefault:\n-\t\t /* The inferior failed to catch the signal. */\n-\t\t internal_error_no_backtrace (\"%s (program %s)\",\n-\t\t\t\t\t strsignal (WTERMSIG (status)),\n-\t\t\t\t\t commands[i].prog);\n \t\t}\n-\t }\n+#endif\n+\t /* FALLTHROUGH */\n+\n+\t default:\n+\t /* The inferior failed to catch the signal. */\n+\t internal_error_no_backtrace (\"%s signal terminated program %s\",\n+\t\t\t\t\t strsignal (WTERMSIG (status)),\n+\t\t\t\t\t commands[i].prog);\n+\t }\n \telse if (WIFEXITED (status)\n \t\t && WEXITSTATUS (status) >= MIN_FATAL_STATUS)\n \t {\n","prefixes":[]}