{"id":806579,"url":"http://patchwork.ozlabs.org/api/1.0/patches/806579/?format=json","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.0/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<1503927503-29065-4-git-send-email-tariqt@mellanox.com>","date":"2017-08-28T13:38:22","name":"[net-next,3/4] net/mlx4_core: Fix misplaced brackets of sizeof","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"660e7b8e01e87580bc03f003bd63b10343b827ca","submitter":{"id":68926,"url":"http://patchwork.ozlabs.org/api/1.0/people/68926/?format=json","name":"Tariq Toukan","email":"tariqt@mellanox.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/1.0/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/1503927503-29065-4-git-send-email-tariqt@mellanox.com/mbox/","series":[{"id":170,"url":"http://patchwork.ozlabs.org/api/1.0/series/170/?format=json","date":"2017-08-28T13:38:21","name":"mlx4 misc patches","version":1,"mbox":"http://patchwork.ozlabs.org/series/170/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/806579/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xgtD22sN4z9sNq\n\tfor ;\n\tMon, 28 Aug 2017 23:39:30 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751324AbdH1NjW (ORCPT );\n\tMon, 28 Aug 2017 09:39:22 -0400","from mail-il-dmz.mellanox.com ([193.47.165.129]:38610 \"EHLO\n\tmellanox.co.il\" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org\n\twith ESMTP id S1751208AbdH1NjM (ORCPT\n\t); Mon, 28 Aug 2017 09:39:12 -0400","from Internal Mail-Server by MTLPINE1 (envelope-from\n\ttariqt@mellanox.com)\n\twith ESMTPS (AES256-SHA encrypted); 28 Aug 2017 16:39:08 +0300","from dev-l-vrt-206-006.mtl.labs.mlnx\n\t(dev-l-vrt-206-006.mtl.labs.mlnx [10.134.206.6])\n\tby labmailer.mlnx (8.13.8/8.13.8) with ESMTP id v7SDd79I014764;\n\tMon, 28 Aug 2017 16:39:07 +0300"],"From":"Tariq Toukan ","To":"\"David S. Miller\" ","Cc":"netdev@vger.kernel.org, Eran Ben Elisha ,\n\tTariq Toukan ,\n\tStephen Hemminger ","Subject":"[PATCH net-next 3/4] net/mlx4_core: Fix misplaced brackets of sizeof","Date":"Mon, 28 Aug 2017 16:38:22 +0300","Message-Id":"<1503927503-29065-4-git-send-email-tariqt@mellanox.com>","X-Mailer":"git-send-email 1.8.3.1","In-Reply-To":"<1503927503-29065-1-git-send-email-tariqt@mellanox.com>","References":"<1503927503-29065-1-git-send-email-tariqt@mellanox.com>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"When changing the sizeof style usage in the patch cited below,\none brackets misplacement was introduced. Here we fix it.\n\nFixes: 31975e27a4b5 (\"mlx4: sizeof style usage\")\nSigned-off-by: Tariq Toukan \nCc: Stephen Hemminger \n---\n drivers/net/ethernet/mellanox/mlx4/eq.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/drivers/net/ethernet/mellanox/mlx4/eq.c b/drivers/net/ethernet/mellanox/mlx4/eq.c\nindex b98698bf75dd..6f57c052053e 100644\n--- a/drivers/net/ethernet/mellanox/mlx4/eq.c\n+++ b/drivers/net/ethernet/mellanox/mlx4/eq.c\n@@ -726,7 +726,7 @@ static int mlx4_eq_int(struct mlx4_dev *dev, struct mlx4_eq *eq)\n \t\t\t}\n \t\t\tmemcpy(&priv->mfunc.master.comm_arm_bit_vector,\n \t\t\t eqe->event.comm_channel_arm.bit_vec,\n-\t\t\t sizeof(eqe)->event.comm_channel_arm.bit_vec);\n+\t\t\t sizeof(eqe->event.comm_channel_arm.bit_vec));\n \t\t\tqueue_work(priv->mfunc.master.comm_wq,\n \t\t\t\t &priv->mfunc.master.comm_work);\n \t\t\tbreak;\n","prefixes":["net-next","3/4"]}