{"id":806533,"url":"http://patchwork.ozlabs.org/api/1.0/patches/806533/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20170828112952.22965-1-kchamart@redhat.com>","date":"2017-08-28T11:29:52","name":"qemu-iotests: Extend non-shared storage migration test (194)","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"bf2f61ddb4382dbb9367659c2906b4d66730c737","submitter":{"id":65934,"url":"http://patchwork.ozlabs.org/api/1.0/people/65934/?format=json","name":"Kashyap Chamarthy","email":"kchamart@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170828112952.22965-1-kchamart@redhat.com/mbox/","series":[{"id":139,"url":"http://patchwork.ozlabs.org/api/1.0/series/139/?format=json","date":"2017-08-28T11:29:52","name":"qemu-iotests: Extend non-shared storage migration test (194)","version":1,"mbox":"http://patchwork.ozlabs.org/series/139/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/806533/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=kchamart@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xgqMT6sZqz9sD9\n\tfor ;\n\tMon, 28 Aug 2017 21:30:45 +1000 (AEST)","from localhost ([::1]:39175 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dmIFf-0008Vx-SW\n\tfor incoming@patchwork.ozlabs.org; Mon, 28 Aug 2017 07:30:43 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:58732)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dmIF9-0008Pf-JH\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 07:30:17 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dmIF5-0005mv-Br\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 07:30:11 -0400","from mx1.redhat.com ([209.132.183.28]:46390)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dmIF0-0005ju-Ho; Mon, 28 Aug 2017 07:30:02 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id C8D91267C4;\n\tMon, 28 Aug 2017 11:30:00 +0000 (UTC)","from eukaryote.redhat.com (ovpn-117-78.ams2.redhat.com\n\t[10.36.117.78])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 25DDD7ED8A;\n\tMon, 28 Aug 2017 11:29:54 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com C8D91267C4","From":"Kashyap Chamarthy ","To":"qemu-devel@nongnu.org","Date":"Mon, 28 Aug 2017 13:29:52 +0200","Message-Id":"<20170828112952.22965-1-kchamart@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tMon, 28 Aug 2017 11:30:00 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH] qemu-iotests: Extend non-shared storage\n\tmigration test (194)","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"kwolf@redhat.com, famz@redhat.com, qemu-block@nongnu.org,\n\tKashyap Chamarthy , dgilbert@redhat.com,\n\tstefanha@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"This is the follow-up patch that was discussed[*] as part of feedback to\nqemu-iotest 194.\n\nChanges in this patch:\n\n - Supply 'job-id' parameter to `drive-mirror` invocation.\n\n - Issue `block-job-cancel` command on the source QEMU to gracefully\n complete the mirroring operation.\n\n - Stop the NBD server on the destination QEMU.\n\n - Finally, exit once the event BLOCK_JOB_COMPLETED is emitted.\n\nWith the above, the test will also be (almost) in sync with the\nprocedure outlined in the document live-block-operations.rst[+]\n(section: \"QMP invocation for live storage migration with\n``drive-mirror`` + NBD\").\n\n[*] https://lists.nongnu.org/archive/html/qemu-devel/2017-08/msg04820.html\n -- qemu-iotests: add 194 non-shared storage migration test\n[+] https://git.qemu.org/gitweb.cgi?p=qemu.git;a=blob;f=docs/interop/live-block-operations.rst\n\nSigned-off-by: Kashyap Chamarthy \n---\nI wonder:\n - Is it worth printing the MIGRATION event state change?\n - Since we're not checking on the MIGRATION event anymore, can\n the migration state change events related code (that is triggerred\n by setting 'migrate-set-capabilities') be simply removed?\n---\n tests/qemu-iotests/194 | 17 ++++++++++++-----\n tests/qemu-iotests/194.out | 14 ++++++++------\n 2 files changed, 20 insertions(+), 11 deletions(-)","diff":"diff --git a/tests/qemu-iotests/194 b/tests/qemu-iotests/194\nindex 8028111e21bed5cf4a2e8e32dc04aa5a9ea9caca..8d746be9d0033f478f11886ee93f95b0fa55bab0 100755\n--- a/tests/qemu-iotests/194\n+++ b/tests/qemu-iotests/194\n@@ -46,16 +46,17 @@ iotests.log('Launching NBD server on destination...')\n iotests.log(dest_vm.qmp('nbd-server-start', addr={'type': 'unix', 'data': {'path': nbd_sock_path}}))\n iotests.log(dest_vm.qmp('nbd-server-add', device='drive0', writable=True))\n \n-iotests.log('Starting drive-mirror on source...')\n+iotests.log('Starting `drive-mirror` on source...')\n iotests.log(source_vm.qmp(\n 'drive-mirror',\n device='drive0',\n target='nbd+unix:///drive0?socket={0}'.format(nbd_sock_path),\n sync='full',\n format='raw', # always raw, the server handles the format\n- mode='existing'))\n+ mode='existing',\n+ job_id='mirror-job0'))\n \n-iotests.log('Waiting for drive-mirror to complete...')\n+iotests.log('Waiting for `drive-mirror` to complete...')\n iotests.log(source_vm.event_wait('BLOCK_JOB_READY'),\n filters=[iotests.filter_qmp_event])\n \n@@ -66,8 +67,14 @@ dest_vm.qmp('migrate-set-capabilities',\n capabilities=[{'capability': 'events', 'state': True}])\n iotests.log(source_vm.qmp('migrate', uri='unix:{0}'.format(migration_sock_path)))\n \n+iotests.log('Gracefully ending the `drive-mirror` job on source...')\n+iotests.log(source_vm.qmp('block-job-cancel', device='mirror-job0'))\n+\n+iotests.log('Stopping the NBD server on destination...')\n+iotests.log(dest_vm.qmp('nbd-server-stop'))\n+\n while True:\n- event = source_vm.event_wait('MIGRATION')\n+ event = source_vm.event_wait('BLOCK_JOB_COMPLETED')\n iotests.log(event, filters=[iotests.filter_qmp_event])\n- if event['data']['status'] in ('completed', 'failed'):\n+ if event['event'] == 'BLOCK_JOB_COMPLETED':\n break\ndiff --git a/tests/qemu-iotests/194.out b/tests/qemu-iotests/194.out\nindex ae501fecacb706b1851cb9063ce9c9d5a28bb7ea..3a0e3a26e5342b0e3f0373623efd9d2b3ee8d2be 100644\n--- a/tests/qemu-iotests/194.out\n+++ b/tests/qemu-iotests/194.out\n@@ -2,12 +2,14 @@ Launching VMs...\n Launching NBD server on destination...\n {u'return': {}}\n {u'return': {}}\n-Starting drive-mirror on source...\n+Starting `drive-mirror` on source...\n {u'return': {}}\n-Waiting for drive-mirror to complete...\n-{u'timestamp': {u'seconds': 'SECS', u'microseconds': 'USECS'}, u'data': {u'device': u'drive0', u'type': u'mirror', u'speed': 0, u'len': 1073741824, u'offset': 1073741824}, u'event': u'BLOCK_JOB_READY'}\n+Waiting for `drive-mirror` to complete...\n+{u'timestamp': {u'seconds': 'SECS', u'microseconds': 'USECS'}, u'data': {u'device': u'mirror-job0', u'type': u'mirror', u'speed': 0, u'len': 1073741824, u'offset': 1073741824}, u'event': u'BLOCK_JOB_READY'}\n Starting migration...\n {u'return': {}}\n-{u'timestamp': {u'seconds': 'SECS', u'microseconds': 'USECS'}, u'data': {u'status': u'setup'}, u'event': u'MIGRATION'}\n-{u'timestamp': {u'seconds': 'SECS', u'microseconds': 'USECS'}, u'data': {u'status': u'active'}, u'event': u'MIGRATION'}\n-{u'timestamp': {u'seconds': 'SECS', u'microseconds': 'USECS'}, u'data': {u'status': u'completed'}, u'event': u'MIGRATION'}\n+Gracefully ending the `drive-mirror` job on source...\n+{u'return': {}}\n+Stopping the NBD server on destination...\n+{u'return': {}}\n+{u'timestamp': {u'seconds': 'SECS', u'microseconds': 'USECS'}, u'data': {u'device': u'mirror-job0', u'type': u'mirror', u'speed': 0, u'len': 1073741824, u'offset': 1073741824}, u'event': u'BLOCK_JOB_COMPLETED'}\n","prefixes":[]}