{"id":806454,"url":"http://patchwork.ozlabs.org/api/1.0/patches/806454/?format=json","project":{"id":27,"url":"http://patchwork.ozlabs.org/api/1.0/projects/27/?format=json","name":"Buildroot development","link_name":"buildroot","list_id":"buildroot.buildroot.org","list_email":"buildroot@buildroot.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<1503912643-27210-1-git-send-email-marcin.nowakowski@imgtec.com>","date":"2017-08-28T09:30:43","name":"pkg-download: remove explicit PKG_VERSION from github helper","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"e157c20e3bdf568f62238ec09a5d97871cf40103","submitter":{"id":69044,"url":"http://patchwork.ozlabs.org/api/1.0/people/69044/?format=json","name":"Marcin Nowakowski","email":"marcin.nowakowski@imgtec.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/buildroot/patch/1503912643-27210-1-git-send-email-marcin.nowakowski@imgtec.com/mbox/","series":[{"id":116,"url":"http://patchwork.ozlabs.org/api/1.0/series/116/?format=json","date":"2017-08-28T09:30:43","name":"pkg-download: remove explicit PKG_VERSION from github helper","version":1,"mbox":"http://patchwork.ozlabs.org/series/116/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/806454/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=)","Received":["from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xgmj86KYtz9sNq\n\tfor ;\n\tMon, 28 Aug 2017 19:30:52 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id F138988A5F;\n\tMon, 28 Aug 2017 09:30:50 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id rFfyKVNCTZs1; Mon, 28 Aug 2017 09:30:50 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 4BE3888A64;\n\tMon, 28 Aug 2017 09:30:50 +0000 (UTC)","from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id A292E1BFC8C\n\tfor ;\n\tMon, 28 Aug 2017 09:30:49 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 9DD7688A64\n\tfor ;\n\tMon, 28 Aug 2017 09:30:49 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Tk5xoacY8R9G for ;\n\tMon, 28 Aug 2017 09:30:49 +0000 (UTC)","from mailapp01.imgtec.com (mailapp01.imgtec.com [195.59.15.196])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id D2BF088A5F\n\tfor ; Mon, 28 Aug 2017 09:30:48 +0000 (UTC)","from hhmail02.hh.imgtec.org (unknown [10.100.10.20])\n\tby Forcepoint Email with ESMTP id 95D4766920DD0\n\tfor ; Mon, 28 Aug 2017 10:30:44 +0100 (IST)","from WR-NOWAKOWSKI.kl.imgtec.org (10.80.2.5) by\n\thhmail02.hh.imgtec.org (10.100.10.21) with Microsoft SMTP Server\n\t(TLS) id 14.3.294.0; Mon, 28 Aug 2017 10:30:46 +0100"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","From":"Marcin Nowakowski ","To":"","Date":"Mon, 28 Aug 2017 11:30:43 +0200","Message-ID":"<1503912643-27210-1-git-send-email-marcin.nowakowski@imgtec.com>","X-Mailer":"git-send-email 2.7.4","MIME-Version":"1.0","X-Originating-IP":"[10.80.2.5]","Cc":"Marcin Nowakowski ","Subject":"[Buildroot] [PATCH] pkg-download: remove explicit PKG_VERSION from\n\tgithub helper","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "},"content":"Currently it is always required to add package version as an argument to\nthe github helper. Since the version is always defined as PKG_VERSION,\ndrop this argument and generate it atuomatically inside the helper\nroutine.\n\nTo make the transition easier the github helper function is extended to\nsupport both 2 and 3 argument variants (ie. either use the provided\npackage version argument or automatically substitute with PKG_VERSION if\nnot available).\n\nSigned-off-by: Marcin Nowakowski \n---\n docs/manual/adding-packages-tips.txt | 2 +-\n package/pkg-download.mk | 4 ++--\n 2 files changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/docs/manual/adding-packages-tips.txt b/docs/manual/adding-packages-tips.txt\nindex 19577fa..30ec768 100644\n--- a/docs/manual/adding-packages-tips.txt\n+++ b/docs/manual/adding-packages-tips.txt\n@@ -138,7 +138,7 @@ past, the 'github' helper function should be used as shown below.\n ------------------------\n # Use a tag or a full commit ID\n FOO_VERSION = v1.0\n-FOO_SITE = $(call github,,,$(FOO_VERSION))\n+FOO_SITE = $(call github,,)\n ------------------------\n \n .Notes\ndiff --git a/package/pkg-download.mk b/package/pkg-download.mk\nindex fbbc2d7..38c8f35 100644\n--- a/package/pkg-download.mk\n+++ b/package/pkg-download.mk\n@@ -52,8 +52,8 @@ notdomain = $(patsubst $(call domain,$(1),$(2))$(call domainseparator,$(2))%,%,$\n # default domainseparator is /, specify alternative value as first argument\n domainseparator = $(if $(1),$(1),/)\n \n-# github(user,package,version): returns site of GitHub repository\n-github = https://github.com/$(1)/$(2)/archive/$(3)\n+# github(user,package[,version]): returns site of GitHub repository\n+github = https://github.com/$(1)/$(2)/archive/$(if $(3),$(3),$($(call UPPERCASE,$(pkgname))_VERSION))\n \n # Expressly do not check hashes for those files\n # Exported variables default to immediately expanded in some versions of\n","prefixes":[]}