{"id":806429,"url":"http://patchwork.ozlabs.org/api/1.0/patches/806429/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<1503907487-2764-2-git-send-email-zyimin@linux.vnet.ibm.com>","date":"2017-08-28T08:04:44","name":"[1/4] s390x/pci: fixup trap_msix()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"5910ecaac8b9d5ecf3bf4d263ba0ca2872d04e63","submitter":{"id":66807,"url":"http://patchwork.ozlabs.org/api/1.0/people/66807/?format=json","name":"Yi Min Zhao","email":"zyimin@linux.vnet.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/1503907487-2764-2-git-send-email-zyimin@linux.vnet.ibm.com/mbox/","series":[{"id":98,"url":"http://patchwork.ozlabs.org/api/1.0/series/98/?format=json","date":"2017-08-28T08:04:43","name":"four zpci patches","version":1,"mbox":"http://patchwork.ozlabs.org/series/98/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/806429/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xgkqK048mz9sN5\n\tfor ;\n\tMon, 28 Aug 2017 18:06:05 +1000 (AEST)","from localhost ([::1]:37400 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dmF3a-00085M-LC\n\tfor incoming@patchwork.ozlabs.org; Mon, 28 Aug 2017 04:06:02 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:55388)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dmF2l-000813-DB\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 04:05:14 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dmF2f-00062J-1d\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 04:05:11 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5]:36184\n\thelo=mx0a-001b2d01.pphosted.com)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dmF2e-000620-Sv\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 04:05:04 -0400","from pps.filterd (m0098419.ppops.net [127.0.0.1])\n\tby mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv7S844RG094354\n\tfor ; Mon, 28 Aug 2017 04:05:04 -0400","from e23smtp06.au.ibm.com (e23smtp06.au.ibm.com [202.81.31.148])\n\tby mx0b-001b2d01.pphosted.com with ESMTP id 2cmb2r25yw-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Mon, 28 Aug 2017 04:05:03 -0400","from localhost\n\tby e23smtp06.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tMon, 28 Aug 2017 18:05:00 +1000","from d23relay06.au.ibm.com (202.81.31.225)\n\tby e23smtp06.au.ibm.com (202.81.31.212) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tMon, 28 Aug 2017 18:04:59 +1000","from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138])\n\tby d23relay06.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n\tv7S84xEV41418986\n\tfor ; Mon, 28 Aug 2017 18:04:59 +1000","from d23av02.au.ibm.com (localhost [127.0.0.1])\n\tby d23av02.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id\n\tv7S84n3p025809\n\tfor ; Mon, 28 Aug 2017 18:04:50 +1000","from r35lp25.boeblingen.de.ibm.com (r35lp25.boeblingen.de.ibm.com\n\t[9.152.111.25])\n\tby d23av02.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id\n\tv7S84gjG025538; Mon, 28 Aug 2017 18:04:46 +1000"],"From":"Yi Min Zhao ","To":"qemu-devel@nongnu.org","Date":"Mon, 28 Aug 2017 10:04:44 +0200","X-Mailer":"git-send-email 2.3.0","In-Reply-To":"<1503907487-2764-1-git-send-email-zyimin@linux.vnet.ibm.com>","References":"<1503907487-2764-1-git-send-email-zyimin@linux.vnet.ibm.com>","X-TM-AS-MML":"disable","x-cbid":"17082808-0040-0000-0000-00000351BD88","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17082808-0041-0000-0000-00000CCFB3EF","Message-Id":"<1503907487-2764-2-git-send-email-zyimin@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-08-28_04:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=1\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1708280128","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.158.5","Subject":"[Qemu-devel] [PATCH 1/4] s390x/pci: fixup trap_msix()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"pasic@linux.vnet.ibm.com, zyimin@linux.vnet.ibm.com,\n\trichard.henderson@linaro.org, cohuck@redhat.com,\n\tpmorel@linux.vnet.ibm.com, agraf@suse.de, borntraeger@de.ibm.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"The function trap_msix() is to check if pcistg instruction would access\nmsix table entries. The correct boundary condition should be\n[table_offset, table_offset+entries*entry_size). But the current\ncondition calculated misses the last entry. So let's fixup it.\n\nAcked-by: Dong Jia Shi \nReviewed-by: Pierre Morel \nSigned-off-by: Yi Min Zhao \n---\n hw/s390x/s390-pci-inst.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/hw/s390x/s390-pci-inst.c b/hw/s390x/s390-pci-inst.c\nindex b7beb8c36a..eba9ffb5f2 100644\n--- a/hw/s390x/s390-pci-inst.c\n+++ b/hw/s390x/s390-pci-inst.c\n@@ -440,8 +440,8 @@ static int trap_msix(S390PCIBusDevice *pbdev, uint64_t offset, uint8_t pcias)\n {\n if (pbdev->msix.available && pbdev->msix.table_bar == pcias &&\n offset >= pbdev->msix.table_offset &&\n- offset <= pbdev->msix.table_offset +\n- (pbdev->msix.entries - 1) * PCI_MSIX_ENTRY_SIZE) {\n+ offset < (pbdev->msix.table_offset +\n+ pbdev->msix.entries * PCI_MSIX_ENTRY_SIZE)) {\n return 1;\n } else {\n return 0;\n","prefixes":["1/4"]}