{"id":806410,"url":"http://patchwork.ozlabs.org/api/1.0/patches/806410/?format=json","project":{"id":44,"url":"http://patchwork.ozlabs.org/api/1.0/projects/44/?format=json","name":"skiboot firmware development","link_name":"skiboot","list_id":"skiboot.lists.ozlabs.org","list_email":"skiboot@lists.ozlabs.org","web_url":"http://github.com/open-power/skiboot","scm_url":"http://github.com/open-power/skiboot","webscm_url":""},"msgid":"<20170828071803.9406-5-hegdevasant@linux.vnet.ibm.com>","date":"2017-08-28T07:18:03","name":"[v2,5/5] hdata: Parse SPD data","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"c1998f0e7b711a2173d29d8f6c0d59651006b519","submitter":{"id":22361,"url":"http://patchwork.ozlabs.org/api/1.0/people/22361/?format=json","name":"Vasant Hegde","email":"hegdevasant@linux.vnet.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/skiboot/patch/20170828071803.9406-5-hegdevasant@linux.vnet.ibm.com/mbox/","series":[{"id":91,"url":"http://patchwork.ozlabs.org/api/1.0/series/91/?format=json","date":"2017-08-28T07:17:59","name":"[v2,1/5] hdata: Fix vpd parse","version":2,"mbox":"http://patchwork.ozlabs.org/series/91/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/806410/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","skiboot@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","skiboot@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xgjnT4qWRz9ryv\n\tfor ;\n\tMon, 28 Aug 2017 17:19:25 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xgjnT3XSCzDqD0\n\tfor ;\n\tMon, 28 Aug 2017 17:19:25 +1000 (AEST)","from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n\t[148.163.156.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xgjmP2xd1zDq7q\n\tfor ; Mon, 28 Aug 2017 17:18:29 +1000 (AEST)","from pps.filterd (m0098393.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv7S7Et1A091083\n\tfor ; Mon, 28 Aug 2017 03:18:27 -0400","from e23smtp07.au.ibm.com (e23smtp07.au.ibm.com [202.81.31.140])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2cm3uf60xa-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Mon, 28 Aug 2017 03:18:26 -0400","from localhost\n\tby e23smtp07.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ; \n\tMon, 28 Aug 2017 17:18:23 +1000","from d23relay10.au.ibm.com (202.81.31.229)\n\tby e23smtp07.au.ibm.com (202.81.31.204) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tMon, 28 Aug 2017 17:18:23 +1000","from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97])\n\tby d23relay10.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n\tv7S7IM7Z36176030\n\tfor ; Mon, 28 Aug 2017 17:18:22 +1000","from d23av03.au.ibm.com (localhost [127.0.0.1])\n\tby d23av03.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id\n\tv7S7IEP2000827\n\tfor ; Mon, 28 Aug 2017 17:18:14 +1000","from hegdevasant.in.ibm.com ([9.109.222.253])\n\tby d23av03.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id\n\tv7S7I6NR000565; Mon, 28 Aug 2017 17:18:13 +1000"],"From":"Vasant Hegde ","To":"skiboot@lists.ozlabs.org","Date":"Mon, 28 Aug 2017 12:48:03 +0530","X-Mailer":"git-send-email 2.9.3","In-Reply-To":"<20170828071803.9406-1-hegdevasant@linux.vnet.ibm.com>","References":"<20170828071803.9406-1-hegdevasant@linux.vnet.ibm.com>","X-TM-AS-MML":"disable","x-cbid":"17082807-0044-0000-0000-000002842022","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17082807-0045-0000-0000-000007179737","Message-Id":"<20170828071803.9406-5-hegdevasant@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-08-28_04:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=1\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1708280117","Subject":"[Skiboot] [PATCH v2 5/5] hdata: Parse SPD data","X-BeenThere":"skiboot@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Mailing list for skiboot development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"Skiboot\"\n\t"},"content":"Parse SPD data and populate device tree.\n\nlist of properites parsing from SPD:\n-----------------------------------\n[root@ltc-wspoon dimm@d00f]# lsprop .\nmemory-id 0000000c (12) <-- DIMM type\ndevice_type \"memory-dimm-ddr4\"\nserial 15d9ad22 (366587170)\npart-number \"36ASF2G72PZ-2G6B2 \"\nmanufacturer-id 0000802c (32812) <-- Vendor ID, we can get vendor name from this ID\n\nSigned-off-by: Vasant Hegde \n---\n hdata/memory.c | 43 ++++++++++++++++++++++++++++++++++++++++++-\n 1 file changed, 42 insertions(+), 1 deletion(-)","diff":"diff --git a/hdata/memory.c b/hdata/memory.c\nindex d1570eb..956e0d7 100644\n--- a/hdata/memory.c\n+++ b/hdata/memory.c\n@@ -319,16 +319,49 @@ static void vpd_add_ram_area(const struct HDIF_common_hdr *msarea)\n \t}\n }\n \n+static void vpd_parse_spd(struct dt_node *dimm, const char *spd, u32 size)\n+{\n+\tu16 *vendor;\n+\tu32 *sn;\n+\n+\t/* SPD is too small */\n+\tif (size < 512) {\n+\t\tprlog(PR_WARNING, \"MSVPD: Invalid SPD size. \"\n+\t\t \"Expected 512 byts, got %d\\n\", size);\n+\t\treturn;\n+\t}\n+\n+\t/* Supports DDR4 format pasing only */\n+\tif (spd[0x2] < 0xc) {\n+\t\tprlog(PR_WARNING,\n+\t\t \"MSVPD: SPD format (%x) not supported\\n\", spd[0x2]);\n+\t\treturn;\n+\t}\n+\n+\tdt_add_property_string(dimm, \"device_type\", \"memory-dimm-ddr4\");\n+\n+\tdt_add_property_cells(dimm, \"memory-id\", be16_to_cpu(spd[0x2]));\n+\n+\tsn = (u32 *)&spd[0x145];\n+\tdt_add_property_cells(dimm, \"serial\", be32_to_cpu(*sn));\n+\n+\tdt_add_property_nstr(dimm, \"part-number\", &spd[0x149], 20);\n+\n+\tvendor = (u16 *)&spd[0x140];\n+\tdt_add_property_cells(dimm, \"manufacturer-id\", be16_to_cpu(*vendor));\n+}\n+\n static void add_mca_dimm_info(struct dt_node *mca,\n \t\t\t const struct HDIF_common_hdr *msarea)\n {\n-\tunsigned int i;\n+\tunsigned int i, size;\n \tconst struct HDIF_child_ptr *ramptr;\n \tconst struct HDIF_common_hdr *ramarea;\n \tconst struct spira_fru_id *fru_id;\n \tconst struct HDIF_ram_area_id *ram_id;\n \tconst struct HDIF_ram_area_size *ram_area_sz;\n \tstruct dt_node *dimm;\n+\tconst void *vpd_blob;\n \n \tramptr = HDIF_child_arr(msarea, 0);\n \tif (!CHECK_SPPTR(ramptr)) {\n@@ -371,6 +404,14 @@ static void add_mca_dimm_info(struct dt_node *mca,\n \t\t\tdt_add_property_string(dimm, \"status\", \"okay\");\n \t\telse\n \t\t\tdt_add_property_string(dimm, \"status\", \"disabled\");\n+\n+\t\tvpd_blob = HDIF_get_idata(ramarea, 1, &size);\n+\t\tif (!CHECK_SPPTR(vpd_blob))\n+\t\t\tcontinue;\n+\t\tif (vpd_valid(vpd_blob, size))\n+\t\t\tvpd_data_parse(dimm, vpd_blob, size);\n+\t\telse\n+\t\t\tvpd_parse_spd(dimm, vpd_blob, size);\n \t}\n }\n \n","prefixes":["v2","5/5"]}