{"id":806408,"url":"http://patchwork.ozlabs.org/api/1.0/patches/806408/?format=json","project":{"id":44,"url":"http://patchwork.ozlabs.org/api/1.0/projects/44/?format=json","name":"skiboot firmware development","link_name":"skiboot","list_id":"skiboot.lists.ozlabs.org","list_email":"skiboot@lists.ozlabs.org","web_url":"http://github.com/open-power/skiboot","scm_url":"http://github.com/open-power/skiboot","webscm_url":""},"msgid":"<20170828071803.9406-2-hegdevasant@linux.vnet.ibm.com>","date":"2017-08-28T07:18:00","name":"[v2,2/5] hdata: Make vpd data parsing function global","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"714fda3cb705c2b65a218037ba3c617fe6f829ab","submitter":{"id":22361,"url":"http://patchwork.ozlabs.org/api/1.0/people/22361/?format=json","name":"Vasant Hegde","email":"hegdevasant@linux.vnet.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/skiboot/patch/20170828071803.9406-2-hegdevasant@linux.vnet.ibm.com/mbox/","series":[{"id":91,"url":"http://patchwork.ozlabs.org/api/1.0/series/91/?format=json","date":"2017-08-28T07:17:59","name":"[v2,1/5] hdata: Fix vpd parse","version":2,"mbox":"http://patchwork.ozlabs.org/series/91/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/806408/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","skiboot@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","skiboot@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xgjmn1wmdz9sNq\n\tfor ;\n\tMon, 28 Aug 2017 17:18:49 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xgjmn0FyMzDqCY\n\tfor ;\n\tMon, 28 Aug 2017 17:18:49 +1000 (AEST)","from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com\n\t[148.163.158.5])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xgjmL2pjjzDq7q\n\tfor ; Mon, 28 Aug 2017 17:18:26 +1000 (AEST)","from pps.filterd (m0098419.ppops.net [127.0.0.1])\n\tby mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv7S7EKkW100587\n\tfor ; Mon, 28 Aug 2017 03:18:23 -0400","from e23smtp01.au.ibm.com (e23smtp01.au.ibm.com [202.81.31.143])\n\tby mx0b-001b2d01.pphosted.com with ESMTP id 2cmb2r031v-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Mon, 28 Aug 2017 03:18:23 -0400","from localhost\n\tby e23smtp01.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ; \n\tMon, 28 Aug 2017 17:18:20 +1000","from d23relay06.au.ibm.com (202.81.31.225)\n\tby e23smtp01.au.ibm.com (202.81.31.207) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tMon, 28 Aug 2017 17:18:18 +1000","from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97])\n\tby d23relay06.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n\tv7S7II3g37814378\n\tfor ; Mon, 28 Aug 2017 17:18:18 +1000","from d23av03.au.ibm.com (localhost [127.0.0.1])\n\tby d23av03.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id\n\tv7S7I9q9000669\n\tfor ; Mon, 28 Aug 2017 17:18:09 +1000","from hegdevasant.in.ibm.com ([9.109.222.253])\n\tby d23av03.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id\n\tv7S7I6NO000565; Mon, 28 Aug 2017 17:18:08 +1000"],"From":"Vasant Hegde ","To":"skiboot@lists.ozlabs.org","Date":"Mon, 28 Aug 2017 12:48:00 +0530","X-Mailer":"git-send-email 2.9.3","In-Reply-To":"<20170828071803.9406-1-hegdevasant@linux.vnet.ibm.com>","References":"<20170828071803.9406-1-hegdevasant@linux.vnet.ibm.com>","X-TM-AS-MML":"disable","x-cbid":"17082807-1617-0000-0000-000001FCE41E","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17082807-1618-0000-0000-000048493058","Message-Id":"<20170828071803.9406-2-hegdevasant@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-08-28_04:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=1\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1708280117","Subject":"[Skiboot] [PATCH v2 2/5] hdata: Make vpd data parsing function\n\tglobal","X-BeenThere":"skiboot@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Mailing list for skiboot development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"Skiboot\"\n\t"},"content":"Move VPD parsing code to separate function (vpd_data_parse())\nand make it as global. So that we can call this function from\nother files.\n\nSigned-off-by: Vasant Hegde \n---\n hdata/hdata.h | 2 ++\n hdata/vpd.c | 14 +++++++++-----\n 2 files changed, 11 insertions(+), 5 deletions(-)","diff":"diff --git a/hdata/hdata.h b/hdata/hdata.h\nindex 6da9b55..cab0626 100644\n--- a/hdata/hdata.h\n+++ b/hdata/hdata.h\n@@ -30,6 +30,8 @@ extern void io_parse(void);\n extern struct dt_node *dt_add_vpd_node(const struct HDIF_common_hdr *hdr,\n \t\t\t\t int indx_fru, int indx_vpd);\n extern void vpd_parse(void);\n+extern void vpd_data_parse(struct dt_node *node,\n+\t\t\t const void *fruvpd, u32 fruvpd_sz);\n \n extern struct dt_node *find_xscom_for_chip(uint32_t chip_id);\n extern uint32_t pcid_to_chip_id(uint32_t proc_chip_id);\ndiff --git a/hdata/vpd.c b/hdata/vpd.c\nindex 0e23e29..836869a 100644\n--- a/hdata/vpd.c\n+++ b/hdata/vpd.c\n@@ -413,6 +413,14 @@ static struct dt_node *dt_create_vpd_node(struct dt_node *parent,\n \treturn node;\n }\n \n+void vpd_data_parse(struct dt_node *node, const void *fruvpd, u32 fruvpd_sz)\n+{\n+\tif (vpd_find_record(fruvpd, fruvpd_sz, \"OPFR\", NULL))\n+\t\tvpd_opfr_parse(node, fruvpd, fruvpd_sz);\n+\telse\n+\t\tvpd_vini_parse(node, fruvpd, fruvpd_sz);\n+}\n+\n struct dt_node *dt_add_vpd_node(const struct HDIF_common_hdr *hdr,\n \t\t\t\tint indx_fru, int indx_vpd)\n {\n@@ -489,11 +497,7 @@ struct dt_node *dt_add_vpd_node(const struct HDIF_common_hdr *hdr,\n \tif (vpd_valid(fruvpd, fruvpd_sz)\n \t && !dt_find_property(node, \"ibm,vpd\")) {\n \t\tdt_add_property(node, \"ibm,vpd\", fruvpd, fruvpd_sz);\n-\n-\t\tif (vpd_find_record(fruvpd, fruvpd_sz, \"OPFR\", NULL))\n-\t\t\tvpd_opfr_parse(node, fruvpd, fruvpd_sz);\n-\t\telse\n-\t\t\tvpd_vini_parse(node, fruvpd, fruvpd_sz);\n+\t\tvpd_data_parse(node, fruvpd, fruvpd_sz);\n \t}\n \n \treturn node;\n","prefixes":["v2","2/5"]}