{"id":806325,"url":"http://patchwork.ozlabs.org/api/1.0/patches/806325/?format=json","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.0/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20170828001603.75876-5-jeffrey.t.kirsher@intel.com>","date":"2017-08-28T00:15:52","name":"[net-next,04/15] i40e: Use correct flag to enable egress traffic for unicast promisc","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"f4e4d8f667943177f2c02cb2cd4c54f4e697c7a0","submitter":{"id":473,"url":"http://patchwork.ozlabs.org/api/1.0/people/473/?format=json","name":"Kirsher, Jeffrey T","email":"jeffrey.t.kirsher@intel.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/1.0/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20170828001603.75876-5-jeffrey.t.kirsher@intel.com/mbox/","series":[{"id":52,"url":"http://patchwork.ozlabs.org/api/1.0/series/52/?format=json","date":"2017-08-28T00:15:49","name":"40GbE Intel Wired LAN Driver Updates 2017-08-27","version":1,"mbox":"http://patchwork.ozlabs.org/series/52/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/806325/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xgXQT5yNbz9s7v\n\tfor ;\n\tMon, 28 Aug 2017 10:17:21 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751834AbdH1ARP (ORCPT );\n\tSun, 27 Aug 2017 20:17:15 -0400","from mga14.intel.com ([192.55.52.115]:55214 \"EHLO mga14.intel.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751662AbdH1AQS (ORCPT );\n\tSun, 27 Aug 2017 20:16:18 -0400","from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t27 Aug 2017 17:16:18 -0700","from davidpwo-mobl1.amr.corp.intel.com (HELO\n\tjtkirshe-DESK.amr.corp.intel.com.com) ([10.254.22.134])\n\tby fmsmga004.fm.intel.com with ESMTP; 27 Aug 2017 17:16:18 -0700"],"X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.41,439,1498546800\"; d=\"scan'208\";a=\"304981061\"","From":"Jeff Kirsher ","To":"davem@davemloft.net","Cc":"Akeem G Abodunrin ,\n\tnetdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com,\n\tjogreene@redhat.com, Jeff Kirsher ","Subject":"[net-next 04/15] i40e: Use correct flag to enable egress traffic\n\tfor unicast promisc","Date":"Sun, 27 Aug 2017 17:15:52 -0700","Message-Id":"<20170828001603.75876-5-jeffrey.t.kirsher@intel.com>","X-Mailer":"git-send-email 2.14.1","In-Reply-To":"<20170828001603.75876-1-jeffrey.t.kirsher@intel.com>","References":"<20170828001603.75876-1-jeffrey.t.kirsher@intel.com>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"From: Akeem G Abodunrin \n\nAlbeit, we usually set true promiscuous mode for both multicast and\nunicast at the same time - however, it is possible to set it\nindividually, so using allmulti flag which is only for allmulticast might\ncaused unwanted behavior in mirroring egress traffic promiscuous for\nunicast in VF.\n\nSigned-off-by: Akeem G Abodunrin \nTested-by: Andrew Bowers \nSigned-off-by: Jeff Kirsher \n---\n drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\nindex 057c77be96e4..27d87bef4ba3 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n@@ -1758,7 +1758,7 @@ static int i40e_vc_config_promiscuous_mode_msg(struct i40e_vf *vf,\n \t\t}\n \t} else {\n \t\taq_ret = i40e_aq_set_vsi_unicast_promiscuous(hw, vsi->seid,\n-\t\t\t\t\t\t\t allmulti, NULL,\n+\t\t\t\t\t\t\t alluni, NULL,\n \t\t\t\t\t\t\t true);\n \t\taq_err = pf->hw.aq.asq_last_status;\n \t\tif (aq_ret) {\n","prefixes":["net-next","04/15"]}