{"id":806297,"url":"http://patchwork.ozlabs.org/api/1.0/patches/806297/?format=json","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.0/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<7b206228-b3e9-5cb9-873c-75b5d8aae23b@users.sourceforge.net>","date":"2017-08-27T19:25:35","name":"connector: Delete an error message for a failed memory allocation in cn_queue_alloc_callback_entry()","commit_ref":null,"pull_url":null,"state":"rejected","archived":true,"hash":"65415fbcdf1fa21c7fbef9c0ff5fc1377e0bcba1","submitter":{"id":65077,"url":"http://patchwork.ozlabs.org/api/1.0/people/65077/?format=json","name":"SF Markus Elfring","email":"elfring@users.sourceforge.net"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/1.0/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/7b206228-b3e9-5cb9-873c-75b5d8aae23b@users.sourceforge.net/mbox/","series":[{"id":39,"url":"http://patchwork.ozlabs.org/api/1.0/series/39/?format=json","date":"2017-08-27T19:25:35","name":"connector: Delete an error message for a failed memory allocation in cn_queue_alloc_callback_entry()","version":1,"mbox":"http://patchwork.ozlabs.org/series/39/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/806297/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xgPyH5M8Wz9s8V\n\tfor ;\n\tMon, 28 Aug 2017 05:25:59 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751321AbdH0TZj (ORCPT );\n\tSun, 27 Aug 2017 15:25:39 -0400","from mout.web.de ([212.227.17.12]:52966 \"EHLO mout.web.de\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751255AbdH0TZi (ORCPT );\n\tSun, 27 Aug 2017 15:25:38 -0400","from [192.168.1.2] ([78.49.107.235]) by smtp.web.de (mrweb103\n\t[213.165.67.124]) with ESMTPSA (Nemesis) id 0MDgDS-1dkPHl2SWU-00H9Du;\n\tSun, 27 Aug 2017 21:25:35 +0200"],"To":"netdev@vger.kernel.org, Evgeniy Polyakov ","Cc":"LKML , kernel-janitors@vger.kernel.org","From":"SF Markus Elfring ","Subject":"[PATCH] connector: Delete an error message for a failed memory\n\tallocation in cn_queue_alloc_callback_entry()","Message-ID":"<7b206228-b3e9-5cb9-873c-75b5d8aae23b@users.sourceforge.net>","Date":"Sun, 27 Aug 2017 21:25:35 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","X-Provags-ID":"V03:K0:V7NO/4BlUYM28sWIciI/9hJX/Xn71Rr2GgrQVSGXRznZsetHx+G\n\tJQgWl+CpEJcXqpRDa2sR6NzptKyPBeN41QNmhUEdl4U32NPqB6ztPfjWwXsee5GkrJjutP4\n\tb/Wf3yAnayw6taPe/pYSxWm+1MvZ+arJ+jQiU3FRzPyvPr4Qaw3WojxmfmXDTC6l514edvI\n\t8adMcxKsqfRc90mSruMLw==","X-UI-Out-Filterresults":"notjunk:1; V01:K0:/dB0Bn+z90o=:f46hdv7yAhNytj1wKe+YN2\n\t3n1vD00xwfBFvZ3B0f9hrKHO1AQm8TXxtgKRy0lRdaudLl7t6qNjHGEGCVsKYvYERlcSIilCs\n\tshgHDExJkEhhznEeJ7ZBgUXXIdJZys6IW1hFiMSin9UjsoycHnppzIjU4akJhZebZGpWiFvUA\n\tnySdbq5mgmBE53RAfV+nNZrGaJKDvRlcx+cmkMFrRCtg1TBo7mpj2jQBXT16ByqxJ2ffXi08p\n\tkdieKPAm0gazxQAXSdqvYleYe0YFDx4C6v4g3O2P1s0GZmu4ReBJLubH8ypYnbkQDcZQdw/yh\n\tVqY0WyljuzhY2AqWAMDt3m/dQTG17WTxft/cPrRTIs38Cbx94rYzY1TKnUJ3kvK9+9RZci1Tz\n\tmn/qfgWZ6K7bzAX2pBExewk2Vqbe6RuB4z3vT+fc0dajfx/V/8K03fxDQmbbX4vS/AUt7VRFx\n\t1lDvdQWqzA3G4xUfRIqVqChrN9MgbwVkgoq2qJhDKymPSbK13CWwUzTsijXPOrwNqQPLqzRrb\n\tOly8Ksx9qR5KXSXemxxMthok37g7k6b0nKgwPH8W+dFOFCTP2iFfJ/f0JbKqIaz+tKJj4zsTk\n\tMVPwzZFsADBOMG0EUY6X6kQ2dG+sK1KRZyAa1UDQkbwbMYn5L1q+C2Fvxk7BE6RVrnfcLRkWI\n\tvfC0C4Kv8kx0arT3tLB9I0RsO0WB+HCWnW4rKoor0wH3bsSfR+sU6B0MWIr3hSDYlYe/zgCgB\n\tkgHnEZkNTsxDXtzwWUFmYMeOX1kbfRvTIrSAjd2j3dftZb1DWC8RY53z0gVVmLHBa3VBiaeuh\n\tV2Zr/h2/v/ApFXx3gCoZ/jQ+3tcfrt/OdPsL1LM7e/5yuM8lV0=","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"From: Markus Elfring \nDate: Sun, 27 Aug 2017 21:18:37 +0200\n\nOmit an extra message for a memory allocation failure in this function.\n\nThis issue was detected by using the Coccinelle software.\n\nSigned-off-by: Markus Elfring \n---\n drivers/connector/cn_queue.c | 4 +---\n 1 file changed, 1 insertion(+), 3 deletions(-)","diff":"diff --git a/drivers/connector/cn_queue.c b/drivers/connector/cn_queue.c\nindex 1f8bf054d11c..e4f31d679f02 100644\n--- a/drivers/connector/cn_queue.c\n+++ b/drivers/connector/cn_queue.c\n@@ -40,10 +40,8 @@ cn_queue_alloc_callback_entry(struct cn_queue_dev *dev, const char *name,\n \tstruct cn_callback_entry *cbq;\n \n \tcbq = kzalloc(sizeof(*cbq), GFP_KERNEL);\n-\tif (!cbq) {\n-\t\tpr_err(\"Failed to create new callback queue.\\n\");\n+\tif (!cbq)\n \t\treturn NULL;\n-\t}\n \n \tatomic_set(&cbq->refcnt, 1);\n \n","prefixes":[]}