{"id":806290,"url":"http://patchwork.ozlabs.org/api/1.0/patches/806290/?format=json","project":{"id":28,"url":"http://patchwork.ozlabs.org/api/1.0/projects/28/?format=json","name":"Linux PCI development","link_name":"linux-pci","list_id":"linux-pci.vger.kernel.org","list_email":"linux-pci@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<1503855651-17409-4-git-send-email-okaya@codeaurora.org>","date":"2017-08-27T17:40:51","name":"[V13,4/4] PCI: Warn periodically while waiting for device to become ready","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"df22d47dcfd69e58263fd28ad49688f81d8430b0","submitter":{"id":67496,"url":"http://patchwork.ozlabs.org/api/1.0/people/67496/?format=json","name":"Sinan Kaya","email":"okaya@codeaurora.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-pci/patch/1503855651-17409-4-git-send-email-okaya@codeaurora.org/mbox/","series":[{"id":36,"url":"http://patchwork.ozlabs.org/api/1.0/series/36/?format=json","date":"2017-08-27T17:40:51","name":"[V13,1/4] PCI: Don't ignore valid response before CRS timeout","version":13,"mbox":"http://patchwork.ozlabs.org/series/36/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/806290/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=codeaurora.org header.i=@codeaurora.org\n\theader.b=\"mRekhcTa\"; \n\tdkim=pass (1024-bit key) header.d=codeaurora.org\n\theader.i=@codeaurora.org header.b=\"SwtBIkrT\"; \n\tdkim-atps=neutral","pdx-caf-mail.web.codeaurora.org;\n\tdmarc=none (p=none dis=none)\n\theader.from=codeaurora.org","pdx-caf-mail.web.codeaurora.org;\n\tspf=none smtp.mailfrom=okaya@codeaurora.org"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xgMdN551lz9s8w\n\tfor ;\n\tMon, 28 Aug 2017 03:41:12 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751146AbdH0RlI (ORCPT );\n\tSun, 27 Aug 2017 13:41:08 -0400","from smtp.codeaurora.org ([198.145.29.96]:42762 \"EHLO\n\tsmtp.codeaurora.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751302AbdH0RlF (ORCPT\n\t); Sun, 27 Aug 2017 13:41:05 -0400","by smtp.codeaurora.org (Postfix, from userid 1000)\n\tid 256CA6073A; Sun, 27 Aug 2017 17:41:05 +0000 (UTC)","from drakthul.qualcomm.com (global_nat1_iad_fw.qualcomm.com\n\t[129.46.232.65])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\t(Authenticated sender: okaya@smtp.codeaurora.org)\n\tby smtp.codeaurora.org (Postfix) with ESMTPSA id B1F1560732;\n\tSun, 27 Aug 2017 17:41:03 +0000 (UTC)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org;\n\ts=default; t=1503855665;\n\tbh=7Ls4blrPadPDB4bWVv2cWZXjwk72dzF3q4qikjgLOG8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=mRekhcTabj36fzVkq3NupEvGwr6oO0UpsxAAR/58IS60V/KINS5/+lE7ME494vL+3\n\tWbEV+IB/iadC5qaNdjhiZlTIGrNSSArVs0QJ2xTh8ErZ2HzTERnxSi3o9xI66CbDXi\n\tPm2tmvez4WYQ3ItTHrkhgZT7i4YJn8WJCSEPZKtc=","v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org;\n\ts=default; t=1503855664;\n\tbh=7Ls4blrPadPDB4bWVv2cWZXjwk72dzF3q4qikjgLOG8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=SwtBIkrTP0QZzMg6yyCvdKD6A1KiU+/wkBWJRKRnStqvh43MkSyLt9qa1NGSqYUcD\n\tZQIOSqPNChZKSJ/gxaFEsgw8U3pXMcugQA5nVypPfloos0/DrRhHaGW7k8AI8Wv7Nl\n\t5I1D6kMw4DQNHtsZ0nRi5EkR78CaCBl6mpWlZeZE="],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tpdx-caf-mail.web.codeaurora.org","X-Spam-Level":"","X-Spam-Status":"No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00,\n\tDKIM_SIGNED,\n\tT_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0","DMARC-Filter":"OpenDMARC Filter v1.3.2 smtp.codeaurora.org B1F1560732","From":"Sinan Kaya ","To":"linux-pci@vger.kernel.org, timur@codeaurora.org,\n\talex.williamson@redhat.com","Cc":"linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n\tSinan Kaya , Bjorn Helgaas ,\n\tlinux-kernel@vger.kernel.org","Subject":"[PATCH V13 4/4] PCI: Warn periodically while waiting for device to\n\tbecome ready","Date":"Sun, 27 Aug 2017 13:40:51 -0400","Message-Id":"<1503855651-17409-4-git-send-email-okaya@codeaurora.org>","X-Mailer":"git-send-email 1.9.1","In-Reply-To":"<1503855651-17409-1-git-send-email-okaya@codeaurora.org>","References":"<1503855651-17409-1-git-send-email-okaya@codeaurora.org>","Sender":"linux-pci-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-pci@vger.kernel.org"},"content":"Add a print statement in pci_bus_wait_crs() so that user observes the\nprogress of device polling instead of silently waiting for timeout to be\nreached.\n\nSigned-off-by: Sinan Kaya \n[bhelgaas: check for timeout first so we don't print \"waiting, giving up\",\nalways print time we've slept (not the actual timeout, print a \"ready\"\nmessage if we've printed a \"waiting\" message]\nSigned-off-by: Bjorn Helgaas \n---\n drivers/pci/probe.c | 16 +++++++++++++---\n 1 file changed, 13 insertions(+), 3 deletions(-)","diff":"diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c\nindex d834a20..8f7ba16 100644\n--- a/drivers/pci/probe.c\n+++ b/drivers/pci/probe.c\n@@ -1847,11 +1847,16 @@ static bool pci_bus_wait_crs(struct pci_bus *bus, int devfn, u32 l,\n \t */\n \twhile ((l & 0xffff) == 0x0001) {\n \t\tif (delay > timeout) {\n-\t\t\tprintk(KERN_WARNING \"pci %04x:%02x:%02x.%d: not responding\\n\",\n-\t\t\t pci_domain_nr(bus), bus->number, PCI_SLOT(devfn),\n-\t\t\t PCI_FUNC(devfn));\n+\t\t\tpr_warn(\"pci %04x:%02x:%02x.%d: not ready after %dms; giving up\\n\",\n+\t\t\t\tpci_domain_nr(bus), bus->number,\n+\t\t\t\tPCI_SLOT(devfn), PCI_FUNC(devfn), delay - 1);\n+\n \t\t\treturn false;\n \t\t}\n+\t\tif (delay >= 1000)\n+\t\t\tpr_info(\"pci %04x:%02x:%02x.%d: not ready after %dms; waiting\\n\",\n+\t\t\t\tpci_domain_nr(bus), bus->number,\n+\t\t\t\tPCI_SLOT(devfn), PCI_FUNC(devfn), delay - 1);\n \n \t\tmsleep(delay);\n \t\tdelay *= 2;\n@@ -1860,6 +1865,11 @@ static bool pci_bus_wait_crs(struct pci_bus *bus, int devfn, u32 l,\n \t\t\treturn false;\n \t}\n \n+\tif (delay >= 1000)\n+\t\tpr_info(\"pci %04x:%02x:%02x.%d: ready after %dms\\n\",\n+\t\t\tpci_domain_nr(bus), bus->number,\n+\t\t\tPCI_SLOT(devfn), PCI_FUNC(devfn), delay - 1);\n+\n \treturn true;\n }\n \n","prefixes":["V13","4/4"]}