{"id":806208,"url":"http://patchwork.ozlabs.org/api/1.0/patches/806208/?format=json","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.0/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20170827104514.77150-1-jsg@jsg.id.au>","date":"2017-08-27T10:45:14","name":"[U-Boot] bch: don't use __BSD_VISIBLE to test for fls","commit_ref":"8f1603bd78a31f52927d398f600e47e2452997a6","pull_url":null,"state":"accepted","archived":false,"hash":"cb69056417e56550400d8abae91dd1d2724a14a8","submitter":{"id":69816,"url":"http://patchwork.ozlabs.org/api/1.0/people/69816/?format=json","name":"Jonathan Gray","email":"jsg@jsg.id.au"},"delegate":{"id":3651,"url":"http://patchwork.ozlabs.org/api/1.0/users/3651/?format=json","username":"trini","first_name":"Tom","last_name":"Rini","email":"trini@ti.com"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20170827104514.77150-1-jsg@jsg.id.au/mbox/","series":[{"id":8,"url":"http://patchwork.ozlabs.org/api/1.0/series/8/?format=json","date":"2017-08-27T10:45:14","name":"[U-Boot] bch: don't use __BSD_VISIBLE to test for fls","version":1,"mbox":"http://patchwork.ozlabs.org/series/8/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/806208/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xgBPs3YfLz9sMN\n\tfor ;\n\tSun, 27 Aug 2017 20:45:36 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 8F6E4C21DBC; Sun, 27 Aug 2017 10:45:26 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 3EA1CC21D58;\n\tSun, 27 Aug 2017 10:45:24 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 61369C21D58; Sun, 27 Aug 2017 10:45:22 +0000 (UTC)","from lechuck.jsg.id.au (jsg.id.au [210.15.216.215])\n\tby lists.denx.de (Postfix) with ESMTPS id EFE01C21C35\n\tfor ; Sun, 27 Aug 2017 10:45:20 +0000 (UTC)","from largo.jsg.id.au (largo.jsg.id.au [192.168.1.43])\n\tby lechuck.jsg.id.au (OpenSMTPD) with ESMTP id 22166445;\n\tSun, 27 Aug 2017 20:45:14 +1000 (AEST)","from largo.jsg.id.au (localhost [127.0.0.1])\n\tby largo.jsg.id.au (OpenSMTPD) with ESMTP id 3798ecb8;\n\tSun, 27 Aug 2017 20:45:14 +1000 (AEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=none autolearn=unavailable\n\tautolearn_force=no version=3.4.0","From":"Jonathan Gray ","To":"u-boot@lists.denx.de","Date":"Sun, 27 Aug 2017 20:45:14 +1000","Message-Id":"<20170827104514.77150-1-jsg@jsg.id.au>","X-Mailer":"git-send-email 2.12.2","Subject":"[U-Boot] [PATCH] bch: don't use __BSD_VISIBLE to test for fls","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "},"content":"Commit 4ecc988301bc8e981e6d7538c57cdb3aa82f7c1d assumes fls is in libc\nif __BSD_VISIBLE is defined. This appears to only be true on FreeBSD\nand DragonFlyBSD. OpenBSD defines __BSD_VISIBLE and does not have fls\nin strings.h/libc.\n\nSwitch the test for __BSD_VISIBLE to one for __DragonFly__ and\n__FreeBSD__ to unbreak the build on OpenBSD.\n\nSigned-off-by: Jonathan Gray \n---\n lib/bch.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/lib/bch.c b/lib/bch.c\nindex 7a2d9d3b86..d0d7e25c4e 100644\n--- a/lib/bch.c\n+++ b/lib/bch.c\n@@ -117,7 +117,7 @@ struct gf_poly_deg1 {\n };\n \n #ifdef USE_HOSTCC\n-#ifndef __BSD_VISIBLE\n+#if !defined(__DragonFly__) && !defined(__FreeBSD__)\n static int fls(int x)\n {\n \tint r = 32;\n","prefixes":["U-Boot"]}