{"id":806200,"url":"http://patchwork.ozlabs.org/api/1.0/patches/806200/?format=json","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.0/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20170827063951.5975-1-christophe.jaillet@wanadoo.fr>","date":"2017-08-27T06:39:51","name":"igb: check memory allocation failure","commit_ref":null,"pull_url":null,"state":"awaiting-upstream","archived":true,"hash":"5332a54c621d96417f7982b54966cd6f40707f27","submitter":{"id":66309,"url":"http://patchwork.ozlabs.org/api/1.0/people/66309/?format=json","name":"Christophe JAILLET","email":"christophe.jaillet@wanadoo.fr"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/1.0/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20170827063951.5975-1-christophe.jaillet@wanadoo.fr/mbox/","series":[{"id":1,"url":"http://patchwork.ozlabs.org/api/1.0/series/1/?format=json","date":"2017-08-27T06:39:51","name":"igb: check memory allocation failure","version":1,"mbox":"http://patchwork.ozlabs.org/series/1/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/806200/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xg50s04KZz9t33\n\tfor ;\n\tSun, 27 Aug 2017 16:42:04 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751301AbdH0Gly (ORCPT );\n\tSun, 27 Aug 2017 02:41:54 -0400","from smtp03.smtpout.orange.fr ([80.12.242.125]:37291 \"EHLO\n\tsmtp.smtpout.orange.fr\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751203AbdH0Glx (ORCPT\n\t); Sun, 27 Aug 2017 02:41:53 -0400","from localhost.localdomain ([86.196.182.67]) by mwinf5d58 with ME\n\tid 26hr1w00D1TfVo6036hrGS; Sun, 27 Aug 2017 08:41:52 +0200"],"X-ME-Helo":"localhost.localdomain","X-ME-Auth":"Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI=","X-ME-Date":"Sun, 27 Aug 2017 08:41:52 +0200","X-ME-IP":"86.196.182.67","From":"Christophe JAILLET ","To":"jeffrey.t.kirsher@intel.com","Cc":"intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,\n\tChristophe JAILLET ","Subject":"[PATCH] igb: check memory allocation failure","Date":"Sun, 27 Aug 2017 08:39:51 +0200","Message-Id":"<20170827063951.5975-1-christophe.jaillet@wanadoo.fr>","X-Mailer":"git-send-email 2.11.0","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"Check memory allocation failures and return -ENOMEM in such cases, as\nalready done for other memory allocations in this function.\n\nThis avoids NULL pointers dereference.\n\nSigned-off-by: Christophe JAILLET \n---\n drivers/net/ethernet/intel/igb/igb_main.c | 2 ++\n 1 file changed, 2 insertions(+)","diff":"diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c\nindex fd4a46b03cc8..837d9b46a390 100644\n--- a/drivers/net/ethernet/intel/igb/igb_main.c\n+++ b/drivers/net/ethernet/intel/igb/igb_main.c\n@@ -3162,6 +3162,8 @@ static int igb_sw_init(struct igb_adapter *adapter)\n \t/* Setup and initialize a copy of the hw vlan table array */\n \tadapter->shadow_vfta = kcalloc(E1000_VLAN_FILTER_TBL_SIZE, sizeof(u32),\n \t\t\t\t GFP_ATOMIC);\n+\tif (!adapter->shadow_vfta)\n+\t\treturn -ENOMEM;\n \n \t/* This call may decrease the number of queues */\n \tif (igb_init_interrupt_scheme(adapter, true)) {\n","prefixes":[]}