{"id":805,"url":"http://patchwork.ozlabs.org/api/1.0/patches/805/?format=json","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.0/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20080921210649.GB2135@2ka.mipt.ru>","date":"2008-09-21T21:06:49","name":"Mark IPW2100 as BROKEN: Fatal interrupt. Scheduling firmware restart.","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":true,"hash":"5478ef89922b6661bacee7e8972c294ba14dba2b","submitter":{"id":225,"url":"http://patchwork.ozlabs.org/api/1.0/people/225/?format=json","name":"Evgeniy Polyakov","email":"johnpol@2ka.mipt.ru"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20080921210649.GB2135@2ka.mipt.ru/mbox/","series":[],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/805/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Received":["from vger.kernel.org (vger.kernel.org [209.132.176.167])\n\tby ozlabs.org (Postfix) with ESMTP id AE326DDEE3\n\tfor ;\n\tMon, 22 Sep 2008 07:08:30 +1000 (EST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752750AbYIUVIN (ORCPT );\n\tSun, 21 Sep 2008 17:08:13 -0400","(majordomo@vger.kernel.org) by vger.kernel.org id S1752593AbYIUVIN\n\t(ORCPT ); Sun, 21 Sep 2008 17:08:13 -0400","from relay.2ka.mipt.ru ([194.85.80.65]:44914 \"EHLO 2ka.mipt.ru\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1752460AbYIUVIL (ORCPT );\n\tSun, 21 Sep 2008 17:08:11 -0400","from 2ka.mipt.ru (localhost [127.0.0.1])\n\tby 2ka.mipt.ru (8.14.1/8.14.1) with ESMTP id m8LL6nwU003839;\n\tMon, 22 Sep 2008 01:06:49 +0400","(from johnpol@localhost)\n\tby 2ka.mipt.ru (8.14.1/8.12.1/Submit) id m8LL6n3O003838;\n\tMon, 22 Sep 2008 01:06:49 +0400"],"Date":"Mon, 22 Sep 2008 01:06:49 +0400","From":"Evgeniy Polyakov ","To":"Cyrill Gorcunov ","Cc":"Johannes Berg ,\n\tArjan van de Ven ,\n\tnetdev@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tipw2100-devel@lists.sourceforge.net,\n\tlinux-wireless@vger.kernel.org, yi.zhu@intel.com,\n\treinette.chatre@intel.com, jgarzik@pobox.com,\n\tlinville@tuxdriver.com, davem@davemloft.net","Subject":"Re: Mark IPW2100 as BROKEN: Fatal interrupt. Scheduling firmware\n\trestart.","Message-ID":"<20080921210649.GB2135@2ka.mipt.ru>","References":"<20080921172316.GA6306@2ka.mipt.ru>\n\t<20080921110422.1d010b96@infradead.org>\n\t<20080921182835.GA11473@2ka.mipt.ru>\n\t<20080921113513.16677c4e@infradead.org>\n\t<20080921190050.GA20484@2ka.mipt.ru>\n\t<1222024444.3023.53.camel@johannes.berg>\n\t<20080921193809.GA8735@2ka.mipt.ru>\n\t<20080921200518.GK7736@localhost>\n\t<20080921202656.GC25052@2ka.mipt.ru>\n\t<20080921203503.GL7736@localhost>","Mime-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20080921203503.GL7736@localhost>","User-Agent":"Mutt/1.5.9i","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"On Mon, Sep 22, 2008 at 12:35:03AM +0400, Cyrill Gorcunov (gorcunov@gmail.com) wrote:\n> yes Evgeniy - all could know that but this register info could help\n> firmware engineers to distinguish problems (without additional efforts\n> like ask users to pass debug argument - kerneloops will have it\n> by default) if there not only one exist. I mean I don't think anyone\n> would reject additional info about problem ever :)\n\nAgreed.","diff":"diff --git a/drivers/net/wireless/ipw2100.c b/drivers/net/wireless/ipw2100.c\nindex 19a401c..36cdd57 100644\n--- a/drivers/net/wireless/ipw2100.c\n+++ b/drivers/net/wireless/ipw2100.c\n@@ -206,6 +206,9 @@ MODULE_PARM_DESC(disable, \"manually disable the radio (default 0 [radio on])\");\n \n static u32 ipw2100_debug_level = IPW_DL_NONE;\n \n+static int ipw2100_max_fatal_ints = 10;\n+module_param(ipw2100_max_fatal_ints, int, 0644);\n+\n #ifdef CONFIG_IPW2100_DEBUG\n #define IPW_DEBUG(level, message...) \\\n do { \\\n@@ -3174,16 +3177,21 @@ static void ipw2100_irq_tasklet(struct ipw2100_priv *priv)\n \tif (inta & IPW2100_INTA_FATAL_ERROR) {\n \t\tprintk(KERN_WARNING DRV_NAME\n \t\t \": Fatal interrupt. Scheduling firmware restart.\\n\");\n+\n+\t\tprintk(KERN_WARNING DRV_NAME \": INTA: 0x%08lX\\n\",\n+\t\t\t(unsigned long)inta & IPW_INTERRUPT_MASK);\n+\n \t\tpriv->inta_other++;\n \t\twrite_register(dev, IPW_REG_INTA, IPW2100_INTA_FATAL_ERROR);\n \n \t\tread_nic_dword(dev, IPW_NIC_FATAL_ERROR, &priv->fatal_error);\n-\t\tIPW_DEBUG_INFO(\"%s: Fatal error value: 0x%08X\\n\",\n+\t\tprintk(KERN_WARNING \"%s: Fatal error value: 0x%08X\\n\",\n \t\t\t priv->net_dev->name, priv->fatal_error);\n \n \t\tread_nic_dword(dev, IPW_ERROR_ADDR(priv->fatal_error), &tmp);\n-\t\tIPW_DEBUG_INFO(\"%s: Fatal error address value: 0x%08X\\n\",\n+\t\tprintk(KERN_WARNING \"%s: Fatal error address value: 0x%08X\\n\",\n \t\t\t priv->net_dev->name, tmp);\n+\t\tWARN_ON(ipw2100_max_fatal_ints-- >= 0);\n \n \t\t/* Wake up any sleeping jobs */\n \t\tschedule_reset(priv);\n","prefixes":[]}