{"id":797,"url":"http://patchwork.ozlabs.org/api/1.0/patches/797/?format=json","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.0/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20080921193809.GA8735@2ka.mipt.ru>","date":"2008-09-21T19:38:09","name":"Mark IPW2100 as BROKEN: Fatal interrupt. Scheduling firmware restart.","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":true,"hash":"f80d56269259a3049276f6ad37e907b0d6a10dc5","submitter":{"id":225,"url":"http://patchwork.ozlabs.org/api/1.0/people/225/?format=json","name":"Evgeniy Polyakov","email":"johnpol@2ka.mipt.ru"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20080921193809.GA8735@2ka.mipt.ru/mbox/","series":[],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/797/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Received":["from vger.kernel.org (vger.kernel.org [209.132.176.167])\n\tby ozlabs.org (Postfix) with ESMTP id D8689DDEF1\n\tfor ;\n\tMon, 22 Sep 2008 05:44:34 +1000 (EST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752342AbYIUTo0 (ORCPT );\n\tSun, 21 Sep 2008 15:44:26 -0400","(majordomo@vger.kernel.org) by vger.kernel.org id S1752281AbYIUTo0\n\t(ORCPT ); Sun, 21 Sep 2008 15:44:26 -0400","from relay.2ka.mipt.ru ([194.85.80.65]:45168 \"EHLO 2ka.mipt.ru\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751462AbYIUToZ (ORCPT );\n\tSun, 21 Sep 2008 15:44:25 -0400","from 2ka.mipt.ru (localhost [127.0.0.1])\n\tby 2ka.mipt.ru (8.14.1/8.14.1) with ESMTP id m8LJcAmK014558;\n\tSun, 21 Sep 2008 23:38:10 +0400","(from johnpol@localhost)\n\tby 2ka.mipt.ru (8.14.1/8.12.1/Submit) id m8LJc90V014557;\n\tSun, 21 Sep 2008 23:38:09 +0400"],"Date":"Sun, 21 Sep 2008 23:38:09 +0400","From":"Evgeniy Polyakov ","To":"Johannes Berg ","Cc":"Arjan van de Ven , netdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, ipw2100-devel@lists.sourceforge.net,\n\tlinux-wireless@vger.kernel.org, yi.zhu@intel.com,\n\treinette.chatre@intel.com, jgarzik@pobox.com,\n\tlinville@tuxdriver.com, davem@davemloft.net","Subject":"Re: Mark IPW2100 as BROKEN: Fatal interrupt. Scheduling firmware\n\trestart.","Message-ID":"<20080921193809.GA8735@2ka.mipt.ru>","References":"<20080921172316.GA6306@2ka.mipt.ru>\n\t<20080921110422.1d010b96@infradead.org>\n\t<20080921182835.GA11473@2ka.mipt.ru>\n\t<20080921113513.16677c4e@infradead.org>\n\t<20080921190050.GA20484@2ka.mipt.ru>\n\t<1222024444.3023.53.camel@johannes.berg>","Mime-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<1222024444.3023.53.camel@johannes.berg>","User-Agent":"Mutt/1.5.9i","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"Hi.\n\nOn Sun, Sep 21, 2008 at 09:14:04PM +0200, Johannes Berg (johannes@sipsolutions.net) wrote:\n> > Do you want me to implement ipw2100 driver as a big work structure\n> > which will run ipw2100_init()/wait/ipw2100_exit() in a loop?\n> > And that will be the fix suggested by Intel? That would explain a lot.\n> \n> I think what Arjan is saying is that it would be better to put pressure\n> on the responsible folks (I don't think Arjan is anywhere near them at\n\nBoth maintainers were added to the copy list.\n\n> all) if you'd put in a WARN_ON() for this error and that would make the\n> top entry on kerneloops.org all the time... And additionally put in a\n> workaround for yourself for now.\n\nAs I pointed, I can rewrite the whole driver's initialization process,\nso that it looked like init/wait/exit loop, which can be processed at\nthe module load and when fatal interrupt fires. Do this a fix? This is\nnot even a remotely workaround. We can just add\nrmmod/modprobe/ifdown/ifup to the crontab job. Another users reported in\nbugzilla that they needed to reboot a machine to make card working\nagain. I'm not sure that user tried to do a rmmod/modprobe though.\n\n> And can we keep the flames off this list please? That comment from Wei\n> Weng was absolutely uncalled for, and inciting a flamewar (as you have\n> already blogged) was not really productive either.\n\nIf we will keep silence, no one will notice that problem exists.\n\nI do hope this will result in a progress. Arjan, do you aggree to add\nthis patch to the current tree?","diff":"diff --git a/drivers/net/wireless/ipw2100.c b/drivers/net/wireless/ipw2100.c\nindex 19a401c..9a7b64c 100644\n--- a/drivers/net/wireless/ipw2100.c\n+++ b/drivers/net/wireless/ipw2100.c\n@@ -206,6 +206,8 @@ MODULE_PARM_DESC(disable, \"manually disable the radio (default 0 [radio on])\");\n \n static u32 ipw2100_debug_level = IPW_DL_NONE;\n \n+static int ipw2100_max_fatal_ints = 10;\n+\n #ifdef CONFIG_IPW2100_DEBUG\n #define IPW_DEBUG(level, message...) \\\n do { \\\n@@ -3174,6 +3176,10 @@ static void ipw2100_irq_tasklet(struct ipw2100_priv *priv)\n \tif (inta & IPW2100_INTA_FATAL_ERROR) {\n \t\tprintk(KERN_WARNING DRV_NAME\n \t\t \": Fatal interrupt. Scheduling firmware restart.\\n\");\n+\t\tWARN_ON(1);\n+\n+\t\tBUG_ON(ipw2100_max_fatal_ints-- <= 0);\n+\n \t\tpriv->inta_other++;\n \t\twrite_register(dev, IPW_REG_INTA, IPW2100_INTA_FATAL_ERROR);\n \n","prefixes":[]}