{"id":735,"url":"http://patchwork.ozlabs.org/api/1.0/patches/735/?format=json","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.0/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<1221933153-11874-13-git-send-email-ilpo.jarvinen@helsinki.fi>","date":"2008-09-20T17:52:30","name":"[net-next,12/15] tcp: remove retransmit_skb_hint clearing from failure","commit_ref":null,"pull_url":null,"state":"rejected","archived":true,"hash":"a7533b29cd0e32d1b14f5f597e25a85063f7e5e8","submitter":{"id":255,"url":"http://patchwork.ozlabs.org/api/1.0/people/255/?format=json","name":"Ilpo Järvinen","email":"ilpo.jarvinen@helsinki.fi"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/1221933153-11874-13-git-send-email-ilpo.jarvinen@helsinki.fi/mbox/","series":[],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/735/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Received":["from vger.kernel.org (vger.kernel.org [209.132.176.167])\n\tby ozlabs.org (Postfix) with ESMTP id DC8F7DDEEA\n\tfor ;\n\tSun, 21 Sep 2008 03:53:15 +1000 (EST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751322AbYITRw4 (ORCPT );\n\tSat, 20 Sep 2008 13:52:56 -0400","(majordomo@vger.kernel.org) by vger.kernel.org id S1751430AbYITRww\n\t(ORCPT ); Sat, 20 Sep 2008 13:52:52 -0400","from courier.cs.helsinki.fi ([128.214.9.1]:37645 \"EHLO\n\tmail.cs.helsinki.fi\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751276AbYITRwk (ORCPT\n\t); Sat, 20 Sep 2008 13:52:40 -0400","from wrl-59.cs.helsinki.fi (wrl-59.cs.helsinki.fi\n\t[128.214.166.179])\n\t(AUTH: PLAIN cs-relay, TLS: TLSv1/SSLv3,256bits,AES256-SHA)\n\tby mail.cs.helsinki.fi with esmtp; Sat, 20 Sep 2008 20:52:34 +0300\n\tid 0005BEE1.48D53862.00002DB8","by wrl-59.cs.helsinki.fi (Postfix, from userid 50795)\n\tid 9B8AEA009A; Sat, 20 Sep 2008 20:52:34 +0300 (EEST)"],"From":"\"=?ISO-8859-1?Q?Ilpo_J=E4rvinen?=\" ","To":"David Miller ","Cc":"netdev@vger.kernel.org,\n\t\"=?utf-8?q?Ilpo=20J=E4rvinen?=\" ","Subject":"[PATCH net-next 12/15] tcp: remove retransmit_skb_hint clearing\n\tfrom failure","Date":"Sat, 20 Sep 2008 20:52:30 +0300","Message-Id":"<1221933153-11874-13-git-send-email-ilpo.jarvinen@helsinki.fi>","X-Mailer":"git-send-email 1.5.4.2.156.ge3c5","In-Reply-To":"<1221933153-11874-12-git-send-email-ilpo.jarvinen@helsinki.fi>","References":"<1221933153-11874-1-git-send-email-ilpo.jarvinen@helsinki.fi>\n\t<1221933153-11874-2-git-send-email-ilpo.jarvinen@helsinki.fi>\n\t<1221933153-11874-3-git-send-email-ilpo.jarvinen@helsinki.fi>\n\t<1221933153-11874-4-git-send-email-ilpo.jarvinen@helsinki.fi>\n\t<1221933153-11874-5-git-send-email-ilpo.jarvinen@helsinki.fi>\n\t<1221933153-11874-6-git-send-email-ilpo.jarvinen@helsinki.fi>\n\t<1221933153-11874-7-git-send-email-ilpo.jarvinen@helsinki.fi>\n\t<1221933153-11874-8-git-send-email-ilpo.jarvinen@helsinki.fi>\n\t<1221933153-11874-9-git-send-email-ilpo.jarvinen@helsinki.fi>\n\t<1221933153-11874-10-git-send-email-ilpo.jarvinen@helsinki.fi>\n\t<1221933153-11874-11-git-send-email-ilpo.jarvinen@helsinki.fi>\n\t<1221933153-11874-12-git-send-email-ilpo.jarvinen@helsinki.fi>","MIME-Version":"1.0","Content-Type":"text/plain; charset=ISO-8859-1","Content-Transfer-Encoding":"8bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"This doesn't much sense here afaict, probably never has. Since\nfragmenting and collapsing deal the hints by themselves, there\nshould be very little reason for the rexmit loop to do that.\n\nSigned-off-by: Ilpo Järvinen \n---\n net/ipv4/tcp_output.c | 4 +---\n 1 files changed, 1 insertions(+), 3 deletions(-)","diff":"diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c\nindex 0234b6f..63686bf 100644\n--- a/net/ipv4/tcp_output.c\n+++ b/net/ipv4/tcp_output.c\n@@ -2098,10 +2098,8 @@ begin_fwd:\n \t\tif (sacked & (TCPCB_SACKED_ACKED|TCPCB_SACKED_RETRANS))\n \t\t\tcontinue;\n \n-\t\tif (tcp_retransmit_skb(sk, skb)) {\n-\t\t\ttp->retransmit_skb_hint = NULL;\n+\t\tif (tcp_retransmit_skb(sk, skb))\n \t\t\treturn;\n-\t\t}\n \t\tNET_INC_STATS_BH(sock_net(sk), mib_idx);\n \n \t\tif (skb == tcp_write_queue_head(sk))\n","prefixes":["net-next","12/15"]}