{"id":730,"url":"http://patchwork.ozlabs.org/api/1.0/patches/730/?format=json","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.0/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<1221933153-11874-6-git-send-email-ilpo.jarvinen@helsinki.fi>","date":"2008-09-20T17:52:23","name":"[net-next,05/15] tcp: Kill precaution that's very likely obsolete","commit_ref":null,"pull_url":null,"state":"rejected","archived":true,"hash":"713b3277790b3916018f5b012e993aa2f2fea804","submitter":{"id":255,"url":"http://patchwork.ozlabs.org/api/1.0/people/255/?format=json","name":"Ilpo Järvinen","email":"ilpo.jarvinen@helsinki.fi"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/1221933153-11874-6-git-send-email-ilpo.jarvinen@helsinki.fi/mbox/","series":[],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/730/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Received":["from vger.kernel.org (vger.kernel.org [209.132.176.167])\n\tby ozlabs.org (Postfix) with ESMTP id 8D0AFDDEE3\n\tfor ;\n\tSun, 21 Sep 2008 03:53:12 +1000 (EST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751515AbYITRw5 (ORCPT );\n\tSat, 20 Sep 2008 13:52:57 -0400","(majordomo@vger.kernel.org) by vger.kernel.org id S1751040AbYITRw4\n\t(ORCPT ); Sat, 20 Sep 2008 13:52:56 -0400","from courier.cs.helsinki.fi ([128.214.9.1]:37645 \"EHLO\n\tmail.cs.helsinki.fi\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751061AbYITRwi (ORCPT\n\t); Sat, 20 Sep 2008 13:52:38 -0400","from wrl-59.cs.helsinki.fi (wrl-59.cs.helsinki.fi\n\t[128.214.166.179])\n\t(AUTH: PLAIN cs-relay, TLS: TLSv1/SSLv3,256bits,AES256-SHA)\n\tby mail.cs.helsinki.fi with esmtp; Sat, 20 Sep 2008 20:52:34 +0300\n\tid 0005BED1.48D53862.00002C0C","by wrl-59.cs.helsinki.fi (Postfix, from userid 50795)\n\tid 5A8E5A00A6; Sat, 20 Sep 2008 20:52:34 +0300 (EEST)"],"From":"\"=?ISO-8859-1?Q?Ilpo_J=E4rvinen?=\" ","To":"David Miller ","Cc":"netdev@vger.kernel.org,\n\t\"=?utf-8?q?Ilpo=20J=E4rvinen?=\" ","Subject":"[PATCH net-next 05/15] tcp: Kill precaution that's very likely\n\tobsolete","Date":"Sat, 20 Sep 2008 20:52:23 +0300","Message-Id":"<1221933153-11874-6-git-send-email-ilpo.jarvinen@helsinki.fi>","X-Mailer":"git-send-email 1.5.4.2.156.ge3c5","In-Reply-To":"<1221933153-11874-5-git-send-email-ilpo.jarvinen@helsinki.fi>","References":"<1221933153-11874-1-git-send-email-ilpo.jarvinen@helsinki.fi>\n\t<1221933153-11874-2-git-send-email-ilpo.jarvinen@helsinki.fi>\n\t<1221933153-11874-3-git-send-email-ilpo.jarvinen@helsinki.fi>\n\t<1221933153-11874-4-git-send-email-ilpo.jarvinen@helsinki.fi>\n\t<1221933153-11874-5-git-send-email-ilpo.jarvinen@helsinki.fi>","MIME-Version":"1.0","Content-Type":"text/plain; charset=ISO-8859-1","Content-Transfer-Encoding":"8bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"I suspect it might have been related to the changed amount\nof lost skbs, which was counted by retransmit_cnt_hint that\ngot dropped.\n\nSigned-off-by: Ilpo Järvinen \n---\n net/ipv4/tcp_input.c | 4 ----\n 1 files changed, 0 insertions(+), 4 deletions(-)","diff":"diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c\nindex 84935cf..d7544ec 100644\n--- a/net/ipv4/tcp_input.c\n+++ b/net/ipv4/tcp_input.c\n@@ -2385,10 +2385,6 @@ static void tcp_undo_cwr(struct sock *sk, const int undo)\n \t}\n \ttcp_moderate_cwnd(tp);\n \ttp->snd_cwnd_stamp = tcp_time_stamp;\n-\n-\t/* There is something screwy going on with the retrans hints after\n-\t an undo */\n-\ttcp_clear_all_retrans_hints(tp);\n }\n \n static inline int tcp_may_undo(struct tcp_sock *tp)\n","prefixes":["net-next","05/15"]}