{"id":729,"url":"http://patchwork.ozlabs.org/api/1.0/patches/729/?format=json","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.0/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<1221933153-11874-7-git-send-email-ilpo.jarvinen@helsinki.fi>","date":"2008-09-20T17:52:24","name":"[net-next,06/15] tcp: No need to clear retransmit_skb_hint when SACKing","commit_ref":null,"pull_url":null,"state":"rejected","archived":true,"hash":"a1d65d34defb14fb4adbff886a9cce60213b04e0","submitter":{"id":255,"url":"http://patchwork.ozlabs.org/api/1.0/people/255/?format=json","name":"Ilpo Järvinen","email":"ilpo.jarvinen@helsinki.fi"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/1221933153-11874-7-git-send-email-ilpo.jarvinen@helsinki.fi/mbox/","series":[],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/729/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Received":["from vger.kernel.org (vger.kernel.org [209.132.176.167])\n\tby ozlabs.org (Postfix) with ESMTP id E2CF3DDEE1\n\tfor ;\n\tSun, 21 Sep 2008 03:53:11 +1000 (EST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751467AbYITRwz (ORCPT );\n\tSat, 20 Sep 2008 13:52:55 -0400","(majordomo@vger.kernel.org) by vger.kernel.org id S1751400AbYITRwx\n\t(ORCPT ); Sat, 20 Sep 2008 13:52:53 -0400","from courier.cs.helsinki.fi ([128.214.9.1]:59235 \"EHLO\n\tmail.cs.helsinki.fi\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750990AbYITRwj (ORCPT\n\t); Sat, 20 Sep 2008 13:52:39 -0400","from wrl-59.cs.helsinki.fi (wrl-59.cs.helsinki.fi\n\t[128.214.166.179])\n\t(AUTH: PLAIN cs-relay, TLS: TLSv1/SSLv3,256bits,AES256-SHA)\n\tby mail.cs.helsinki.fi with esmtp; Sat, 20 Sep 2008 20:52:34 +0300\n\tid 0005BED7.48D53862.00002CA6","by wrl-59.cs.helsinki.fi (Postfix, from userid 50795)\n\tid 622D9A00A7; Sat, 20 Sep 2008 20:52:34 +0300 (EEST)"],"From":"\"=?ISO-8859-1?Q?Ilpo_J=E4rvinen?=\" ","To":"David Miller ","Cc":"netdev@vger.kernel.org,\n\t\"=?utf-8?q?Ilpo=20J=E4rvinen?=\" ","Subject":"[PATCH net-next 06/15] tcp: No need to clear retransmit_skb_hint\n\twhen SACKing","Date":"Sat, 20 Sep 2008 20:52:24 +0300","Message-Id":"<1221933153-11874-7-git-send-email-ilpo.jarvinen@helsinki.fi>","X-Mailer":"git-send-email 1.5.4.2.156.ge3c5","In-Reply-To":"<1221933153-11874-6-git-send-email-ilpo.jarvinen@helsinki.fi>","References":"<1221933153-11874-1-git-send-email-ilpo.jarvinen@helsinki.fi>\n\t<1221933153-11874-2-git-send-email-ilpo.jarvinen@helsinki.fi>\n\t<1221933153-11874-3-git-send-email-ilpo.jarvinen@helsinki.fi>\n\t<1221933153-11874-4-git-send-email-ilpo.jarvinen@helsinki.fi>\n\t<1221933153-11874-5-git-send-email-ilpo.jarvinen@helsinki.fi>\n\t<1221933153-11874-6-git-send-email-ilpo.jarvinen@helsinki.fi>","MIME-Version":"1.0","Content-Type":"text/plain; charset=ISO-8859-1","Content-Transfer-Encoding":"8bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"Because lost counter no longer requires tuning, this is\ntrivial to remove (the tuning wouldn't have been too\nhard either) because no \"new\" retransmittable skb appeared\nbelow retransmit_skb_hint when SACKing for sure.\n\nSigned-off-by: Ilpo Järvinen \n---\n net/ipv4/tcp_input.c | 7 -------\n 1 files changed, 0 insertions(+), 7 deletions(-)","diff":"diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c\nindex d7544ec..8a6dec8 100644\n--- a/net/ipv4/tcp_input.c\n+++ b/net/ipv4/tcp_input.c\n@@ -1296,9 +1296,6 @@ static int tcp_sacktag_one(struct sk_buff *skb, struct sock *sk,\n \t\t\t\t\t~(TCPCB_LOST|TCPCB_SACKED_RETRANS);\n \t\t\t\ttp->lost_out -= tcp_skb_pcount(skb);\n \t\t\t\ttp->retrans_out -= tcp_skb_pcount(skb);\n-\n-\t\t\t\t/* clear lost hint */\n-\t\t\t\ttp->retransmit_skb_hint = NULL;\n \t\t\t}\n \t\t} else {\n \t\t\tif (!(sacked & TCPCB_RETRANS)) {\n@@ -1317,9 +1314,6 @@ static int tcp_sacktag_one(struct sk_buff *skb, struct sock *sk,\n \t\t\tif (sacked & TCPCB_LOST) {\n \t\t\t\tTCP_SKB_CB(skb)->sacked &= ~TCPCB_LOST;\n \t\t\t\ttp->lost_out -= tcp_skb_pcount(skb);\n-\n-\t\t\t\t/* clear lost hint */\n-\t\t\t\ttp->retransmit_skb_hint = NULL;\n \t\t\t}\n \t\t}\n \n@@ -1349,7 +1343,6 @@ static int tcp_sacktag_one(struct sk_buff *skb, struct sock *sk,\n \tif (dup_sack && (TCP_SKB_CB(skb)->sacked & TCPCB_SACKED_RETRANS)) {\n \t\tTCP_SKB_CB(skb)->sacked &= ~TCPCB_SACKED_RETRANS;\n \t\ttp->retrans_out -= tcp_skb_pcount(skb);\n-\t\ttp->retransmit_skb_hint = NULL;\n \t}\n \n \treturn flag;\n","prefixes":["net-next","06/15"]}