{"id":692,"url":"http://patchwork.ozlabs.org/api/1.0/patches/692/?format=json","project":{"id":5,"url":"http://patchwork.ozlabs.org/api/1.0/projects/5/?format=json","name":"Linux PowerPC Embedded development","link_name":"linuxppc-embedded","list_id":"linuxppc-embedded.ozlabs.org","list_email":"linuxppc-embedded@ozlabs.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20080920062753.GA12497@pengutronix.de>","date":"2008-09-20T06:27:53","name":"[MPC52XX] Trivial: printk-fixes in mpc52xx_common","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"98da05f83d44f2374e39613d35bddd9205b60cb5","submitter":{"id":263,"url":"http://patchwork.ozlabs.org/api/1.0/people/263/?format=json","name":"Wolfram Sang","email":"w.sang@pengutronix.de"},"delegate":{"id":8,"url":"http://patchwork.ozlabs.org/api/1.0/users/8/?format=json","username":"glikely","first_name":"Grant","last_name":"Likely","email":"grant.likely@secretlab.ca"},"mbox":"http://patchwork.ozlabs.org/project/linuxppc-embedded/patch/20080920062753.GA12497@pengutronix.de/mbox/","series":[],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/692/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-embedded@ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-embedded@ozlabs.org"],"Received":["from ozlabs.org (localhost [127.0.0.1])\n\tby ozlabs.org (Postfix) with ESMTP id 67E43DDFDF\n\tfor ;\n\tSat, 20 Sep 2008 16:28:11 +1000 (EST)","from metis.extern.pengutronix.de (metis.extern.pengutronix.de\n\t[83.236.181.26]) by ozlabs.org (Postfix) with ESMTP id CC7E0DDE3A\n\tfor ;\n\tSat, 20 Sep 2008 16:28:01 +1000 (EST)","from octopus.labnet.pengutronix.de ([10.1.1.3])\n\tby metis.extern.pengutronix.de with esmtp (Exim 4.63)\n\t(envelope-from )\n\tid 1Kgvwh-0002Q6-CQ; Sat, 20 Sep 2008 08:27:55 +0200","from wsa by octopus.labnet.pengutronix.de with local (Exim 4.69)\n\t(envelope-from )\n\tid 1Kgvwf-0003Iu-Vh; Sat, 20 Sep 2008 08:27:53 +0200"],"Date":"Sat, 20 Sep 2008 08:27:53 +0200","From":"Wolfram Sang ","To":"linuxppc-embedded@ozlabs.org","Subject":"Re: [PATCH] [MPC52XX] Trivial: printk-fixes in mpc52xx_common","Message-ID":"<20080920062753.GA12497@pengutronix.de>","References":"<20080919132436.GF4307@pengutronix.de>","MIME-Version":["1.0","1.0"],"In-Reply-To":"<20080919132436.GF4307@pengutronix.de>","User-Agent":"Mutt/1.5.18 (2008-05-17)","X-SA-Exim-Connect-IP":"10.1.1.3","X-SA-Exim-Mail-From":"wsa@pengutronix.de","X-SA-Exim-Scanned":"No (on metis.extern.pengutronix.de);\n\tSAEximRunCond expanded to false","X-BeenThere":"linuxppc-embedded@ozlabs.org","X-Mailman-Version":"2.1.11","Precedence":"list","List-Id":"Linux on Embedded PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"multipart/mixed; boundary=\"===============0688493669==\"","Mime-version":["1.0","1.0"],"Sender":"linuxppc-embedded-bounces+patchwork-incoming=ozlabs.org@ozlabs.org","Errors-To":"linuxppc-embedded-bounces+patchwork-incoming=ozlabs.org@ozlabs.org"},"content":"- one printk was missing a loglevel\n - remove double space while we are here\n\nSigned-off-by: Wolfram Sang \n---\n\nI'm sorry, accidently sent a -p0-patch before :(\n\n arch/powerpc/platforms/52xx/mpc52xx_common.c | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)","diff":"Index: playground/arch/powerpc/platforms/52xx/mpc52xx_common.c\n===================================================================\n--- playground.orig/arch/powerpc/platforms/52xx/mpc52xx_common.c\n+++ playground/arch/powerpc/platforms/52xx/mpc52xx_common.c\n@@ -90,7 +90,7 @@\n \tof_node_put(np);\n \tif (!xlb) {\n \t\tprintk(KERN_ERR __FILE__ \": \"\n-\t\t\t\"Error mapping XLB in mpc52xx_setup_cpu(). \"\n+\t\t\t\"Error mapping XLB in mpc52xx_setup_cpu(). \"\n \t\t\t\"Expect some abnormal behavior\\n\");\n \t\treturn;\n \t}\n@@ -216,7 +216,8 @@\n \t\tout_be32(&mpc52xx_wdt->count, 0x000000ff);\n \t\tout_be32(&mpc52xx_wdt->mode, 0x00009004);\n \t} else\n-\t\tprintk(\"mpc52xx_restart: Can't access wdt. \"\n+\t\tprintk(KERN_ERR __FILE__ \": \"\n+\t\t\t\"mpc52xx_restart: Can't access wdt. \"\n \t\t\t\"Restart impossible, system halted.\\n\");\n \n \twhile (1);\n","prefixes":["MPC52XX"]}