{"id":658,"url":"http://patchwork.ozlabs.org/api/1.0/patches/658/?format=json","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/1.0/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/"},"msgid":"<1221849099-27015-1-git-send-email-galak@kernel.crashing.org>","date":"2008-09-19T18:31:39","name":"powerpc: Fix build warnings introduced by PMC support on 32-bit","commit_ref":"33a7f122740bd820a029faf450a9a0caa9458426","pull_url":null,"state":"accepted","archived":true,"hash":"99f2ce4581c216cb6722d3d09f493cc7d67abeb5","submitter":{"id":5,"url":"http://patchwork.ozlabs.org/api/1.0/people/5/?format=json","name":"Kumar Gala","email":"galak@kernel.crashing.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/1221849099-27015-1-git-send-email-galak@kernel.crashing.org/mbox/","series":[],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/658/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@ozlabs.org"],"Received":["from ozlabs.org (localhost [127.0.0.1])\n\tby ozlabs.org (Postfix) with ESMTP id 710A2DE12A\n\tfor ;\n\tSat, 20 Sep 2008 04:32:55 +1000 (EST)","from gate.crashing.org (gate.crashing.org [63.228.1.57])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\tby ozlabs.org (Postfix) with ESMTPS id 5B019DE42D\n\tfor ; Sat, 20 Sep 2008 04:31:45 +1000 (EST)","from localhost (localhost.localdomain [127.0.0.1])\n\tby gate.crashing.org (8.14.1/8.13.8) with ESMTP id m8JIVdrP019643\n\tfor ; Fri, 19 Sep 2008 13:31:40 -0500"],"From":"Kumar Gala ","To":"linuxppc-dev@ozlabs.org","Subject":"[PATCH] powerpc: Fix build warnings introduced by PMC support on\n\t32-bit","Date":"Fri, 19 Sep 2008 13:31:39 -0500","Message-Id":"<1221849099-27015-1-git-send-email-galak@kernel.crashing.org>","X-Mailer":"git-send-email 1.5.5.1","X-BeenThere":"linuxppc-dev@ozlabs.org","X-Mailman-Version":"2.1.11","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org"},"content":"arch/powerpc/kernel/sysfs.c:197:7: warning: \"CONFIG_6xx\" is not defined\narch/powerpc/kernel/sysfs.c:141: warning: 'run_on_cpu' defined but not used\n\nSigned-off-by: Kumar Gala ","diff":"diff --git a/arch/powerpc/kernel/sysfs.c b/arch/powerpc/kernel/sysfs.c\nindex ef2ad92..86a2ffc 100644\n--- a/arch/powerpc/kernel/sysfs.c\n+++ b/arch/powerpc/kernel/sysfs.c\n@@ -134,6 +134,7 @@ void ppc_enable_pmcs(void)\n }\n EXPORT_SYMBOL(ppc_enable_pmcs);\n \n+#if defined(CONFIG_6xx) || defined(CONFIG_PPC64)\n /* XXX convert to rusty's on_one_cpu */\n static unsigned long run_on_cpu(unsigned long cpu,\n \t\t\t unsigned long (*func)(unsigned long),\n@@ -152,6 +153,7 @@ static unsigned long run_on_cpu(unsigned long cpu,\n \n \treturn ret;\n }\n+#endif\n \n #define SYSFS_PMCSETUP(NAME, ADDRESS) \\\n static unsigned long read_##NAME(unsigned long junk) \\\n@@ -190,11 +192,11 @@ static ssize_t __used \\\n * that are implemented on the current processor\n */\n \n-#ifdef CONFIG_PPC64\n+#if defined(CONFIG_PPC64)\n #define HAS_PPC_PMC_CLASSIC\t1\n #define HAS_PPC_PMC_IBM\t\t1\n #define HAS_PPC_PMC_PA6T\t1\n-#elif CONFIG_6xx\n+#elif defined(CONFIG_6xx)\n #define HAS_PPC_PMC_CLASSIC\t1\n #define HAS_PPC_PMC_IBM\t\t1\n #define HAS_PPC_PMC_G4\t\t1\n","prefixes":[]}